From: Khalil Blaiech <kblaiech@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Leon Romanovsky <leonro@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>
Subject: RE: [PATCH i2c-next v1 6/6] dt-bindings: i2c: Convert DT file to YAML schema
Date: Tue, 3 Nov 2020 14:06:19 +0000 [thread overview]
Message-ID: <MN2PR12MB3616EF176B1E7807D26C16E4AB110@MN2PR12MB3616.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201029153312.GB1905314@bogus>
> On Wed, 28 Oct 2020 18:55:54 -0400, Khalil Blaiech wrote:
> > Write the devicetree binding text file in schema file, JSON
> > compatible subset of YAML.
> > Besides, add an entry within MAINTAINERS file.
> >
> > Fixes: d9becc53b3ade81e ("dt-bindings: i2c: I2C binding for Mellanox
> BlueField SoC")
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> > Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
> > ---
> > .../bindings/i2c/mellanox,i2c-mlxbf.txt | 42 ----------
> > .../bindings/i2c/mellanox,i2c-mlxbf.yaml | 78 +++++++++++++++++++
> > MAINTAINERS | 1 +
> > 3 files changed, 79 insertions(+), 42 deletions(-)
> > delete mode 100644
> Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.txt
> > create mode 100644
> Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml:28:7:
> [warning] wrong indentation: expected 4 but found 6 (indentation)
> ./Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml:31:7:
> [warning] wrong indentation: expected 4 but found 6 (indentation)
>
> dtschema/dtc warnings/errors:
>
>
> See https://patchwork.ozlabs.org/patch/1389582
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
Thank you, Rob. Will do.
prev parent reply other threads:[~2020-11-03 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1603925077.git.kblaiech@nvidia.com>
2020-10-28 22:55 ` [PATCH i2c-next v1 6/6] dt-bindings: i2c: Convert DT file to YAML schema Khalil Blaiech
2020-10-29 15:33 ` Rob Herring
2020-11-03 14:08 ` Khalil Blaiech
2020-10-29 15:33 ` Rob Herring
2020-11-03 14:06 ` Khalil Blaiech [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3616EF176B1E7807D26C16E4AB110@MN2PR12MB3616.namprd12.prod.outlook.com \
--to=kblaiech@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).