devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
@ 2020-11-04 10:55 Lad Prabhakar
  2020-11-09 10:02 ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Lad Prabhakar @ 2020-11-04 10:55 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm, Rob Herring, linux-renesas-soc
  Cc: devicetree, linux-kernel, Biju Das, Prabhakar, Lad Prabhakar

Add audio_clk_b configured as 0 Hz, this will be overridden by the
boards providing the audio clock.

Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Hi Geert,

I have rebased this patch on renesas-arm-dt-for-v5.10 branch.

Cheers,
Prabhakar
---
 arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 9cbf963aa068..c29643442e91 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -28,6 +28,12 @@
 		clock-frequency = <0>;
 	};
 
+	audio_clk_b: audio_clk_b {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <0>;
+	};
+
 	audio_clk_c: audio_clk_c {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
  2020-11-04 10:55 [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b Lad Prabhakar
@ 2020-11-09 10:02 ` Geert Uytterhoeven
  2020-11-09 10:05   ` Prabhakar Mahadev Lad
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-11-09 10:02 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Magnus Damm, Rob Herring, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Biju Das, Prabhakar

On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add audio_clk_b configured as 0 Hz, this will be overridden by the
> boards providing the audio clock.
>
> Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.11.

> I have rebased this patch on renesas-arm-dt-for-v5.10 branch.

Not renesas-arm-dt-for-v5.11?

Anyway, seems to apply cleanly.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
  2020-11-09 10:02 ` Geert Uytterhoeven
@ 2020-11-09 10:05   ` Prabhakar Mahadev Lad
  2020-11-09 10:10     ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Prabhakar Mahadev Lad @ 2020-11-09 10:05 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Magnus Damm, Rob Herring, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Biju Das, Prabhakar

Hi Geert,

Thank you for the review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 09 November 2020 10:02
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-
> renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das
> <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>
> Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
> 
> On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > Add audio_clk_b configured as 0 Hz, this will be overridden by the
> > boards providing the audio clock.
> >
> > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.11.
> 
> > I have rebased this patch on renesas-arm-dt-for-v5.10 branch.
> 
> Not renesas-arm-dt-for-v5.11?
> 
Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-arm-dt-for-v5.10 branch.

Cheers,
Prabhakar

> Anyway, seems to apply cleanly.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
  2020-11-09 10:05   ` Prabhakar Mahadev Lad
@ 2020-11-09 10:10     ` Geert Uytterhoeven
  2020-11-09 10:12       ` Prabhakar Mahadev Lad
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-11-09 10:10 UTC (permalink / raw)
  To: Prabhakar Mahadev Lad
  Cc: Magnus Damm, Rob Herring, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Biju Das, Prabhakar

Hi Prabhakar,

On Mon, Nov 9, 2020 at 11:05 AM Prabhakar Mahadev Lad
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > -----Original Message-----
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > Sent: 09 November 2020 10:02
> > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-
> > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das
> > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>
> > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
> >
> > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > Add audio_clk_b configured as 0 Hz, this will be overridden by the
> > > boards providing the audio clock.
> > >
> > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> > > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v5.11.
> >
> > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch.
> >
> > Not renesas-arm-dt-for-v5.11?
> >
> Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-arm-dt-for-v5.10 branch.

OK. Will queue in renesas-fixes-for-v5.10 instead.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
  2020-11-09 10:10     ` Geert Uytterhoeven
@ 2020-11-09 10:12       ` Prabhakar Mahadev Lad
  0 siblings, 0 replies; 5+ messages in thread
From: Prabhakar Mahadev Lad @ 2020-11-09 10:12 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Magnus Damm, Rob Herring, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Biju Das, Prabhakar

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 09 November 2020 10:10
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-
> renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das
> <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>
> Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
> 
> Hi Prabhakar,
> 
> On Mon, Nov 9, 2020 at 11:05 AM Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Sent: 09 November 2020 10:02
> > > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-
> > > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das
> > > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>
> > > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
> > >
> > > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > > Add audio_clk_b configured as 0 Hz, this will be overridden by the
> > > > boards providing the audio clock.
> > > >
> > > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> > > > Reported-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > i.e. will queue in renesas-devel for v5.11.
> > >
> > > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch.
> > >
> > > Not renesas-arm-dt-for-v5.11?
> > >
> > Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-
> arm-dt-for-v5.10 branch.
> 
> OK. Will queue in renesas-fixes-for-v5.10 instead.
> 
Thank you.

Cheers,
Prabhakar

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-09 10:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 10:55 [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b Lad Prabhakar
2020-11-09 10:02 ` Geert Uytterhoeven
2020-11-09 10:05   ` Prabhakar Mahadev Lad
2020-11-09 10:10     ` Geert Uytterhoeven
2020-11-09 10:12       ` Prabhakar Mahadev Lad

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).