From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Mason Yang <masonccyang@mxic.com.tw>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: RE: [PATCH v2 2/6] dt-bindings: spi: Document Renesas SPIBSC bindings
Date: Mon, 9 Dec 2019 15:45:08 +0000 [thread overview]
Message-ID: <TY1PR01MB1562BC84E2ECF81487A780D38A580@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXW6_tCcx_DE66qBSTK8XmWyWm82ZD6h-N5YX_+xcvBtw@mail.gmail.com>
Hi Geert,
On Mon, Dec 9, 2019, Geert Uytterhoeven wrote:
> > + reg:
> > + minItems: 2
> > + maxItems: 2
> > + items:
> > + - description: Registers
> > + - description: Memory Mapped Address Space
>
> The second one is not needed, if you would add "ranges" for the memory-mapped
> mode.
So for RZ/A2M:
ranges = <0x0 0x20000000 0x10000000>;
> > + # This example is for "External Address Space Read Mode"
> > + spibsc: spi@1f800000 {
> > + compatible = "renesas,r7s9210-spibsc";
> > + reg = <0x1f800000 0x100>, <0x20000000 0x10000000>;
> > + clocks = <&cpg CPG_MOD 83>;
> > + power-domains = <&cpg>;
> > + interrupts = <GIC_SPI 445 IRQ_TYPE_LEVEL_HIGH>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > + flash@20000000 {
>
> This does not describe the hardware topology: the flash node should be a
> subnode of the spibsc node, as it relies on the spibsc being clocked.
So for the "XIP" case, I originally tried adding an "mtd-rom" flash node
under the spibsc node, but then the mtd-rom part never got probed. I
guess that was because it didn't register a SPI controller.
But, I guess if we go your method...
> spibsc: spi@1f800000 {
> compatible = "renesas,r7s9210-spibsc", "simple-pm-bus";
Then after the spibsc driver fails and the "simple-pm-bus" driver tries,
it will succeed and the simple-pm-bus driver will start probing the
subnodes (in my case, the mtd-rom).
> and applying "[PATCH] mtd: maps: physmap: Add minimal Runtime PM support"[1],
> the memory-mapped case should work, without your spibsc driver.
Good.
So we can add the SPI-BSC clocks for RZ/A1 and RZ/A2 (even without the
SPI-BSC driver) and still have a working solution for XIP_KERNEL.
So in the end, this all seems like a very simple solution to get
everything I wanted with minimal complexity.
But, if Sergei is going a completely different route for R-Car, I guess
I need to understand that first what he is trying to do before I really
push for this driver getting in.
Again, this driver was only when using the SPI-BSC HW, not the full
(different) R/W HyperFlash controller HW. That would be a separate driver.
Chris
next prev parent reply other threads:[~2019-12-09 15:45 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 13:41 [PATCH v2 0/6] spi: Add Renesas SPIBSC controller Chris Brandt
2019-12-06 13:41 ` [PATCH v2 1/6] spi: Add SPIBSC driver Chris Brandt
2019-12-12 19:36 ` Sergei Shtylyov
2019-12-12 20:19 ` Chris Brandt
2019-12-13 10:01 ` Geert Uytterhoeven
2019-12-13 14:45 ` Chris Brandt
2019-12-13 14:48 ` Geert Uytterhoeven
2019-12-13 19:37 ` Sergei Shtylyov
2019-12-13 18:36 ` Sergei Shtylyov
2019-12-13 19:40 ` Sergei Shtylyov
2019-12-13 20:43 ` Chris Brandt
2019-12-16 18:47 ` Sergei Shtylyov
2019-12-06 13:41 ` [PATCH v2 2/6] dt-bindings: spi: Document Renesas SPIBSC bindings Chris Brandt
2019-12-09 14:09 ` Geert Uytterhoeven
2019-12-09 15:45 ` Chris Brandt [this message]
2019-12-09 19:34 ` Geert Uytterhoeven
2019-12-10 20:07 ` Sergei Shtylyov
2019-12-10 20:17 ` Geert Uytterhoeven
2019-12-10 20:33 ` Chris Brandt
2019-12-10 20:23 ` Chris Brandt
2019-12-06 13:41 ` [PATCH v2 3/6] clk: renesas: r7s9210: Add SPIBSC clock Chris Brandt
2019-12-06 18:40 ` Sergei Shtylyov
2019-12-06 19:49 ` Chris Brandt
2019-12-20 14:38 ` Geert Uytterhoeven
2019-12-20 14:50 ` Chris Brandt
2019-12-06 13:42 ` [PATCH v2 4/6] ARM: dts: r7s72100: Add SPIBSC devices Chris Brandt
2019-12-06 13:42 ` [PATCH v2 5/6] ARM: dts: r7s9210: Add SPIBSC device Chris Brandt
2019-12-06 13:42 ` [PATCH v2 6/6] ARM: dts: gr-peach: Enable SPIBSC Chris Brandt
2019-12-07 20:28 ` [PATCH v2 0/6] spi: Add Renesas SPIBSC controller Sergei Shtylyov
2019-12-09 15:10 ` Chris Brandt
2019-12-11 19:09 ` Sergei Shtylyov
2019-12-12 14:29 ` Chris Brandt
2019-12-12 15:28 ` Mark Brown
2019-12-12 16:53 ` Chris Brandt
2019-12-12 17:13 ` Mark Brown
2019-12-12 17:25 ` Chris Brandt
2019-12-16 15:21 ` Mark Brown
2019-12-16 20:31 ` Sergei Shtylyov
2019-12-16 22:21 ` Chris Brandt
2019-12-17 19:30 ` Sergei Shtylyov
2019-12-17 20:26 ` Geert Uytterhoeven
2019-12-19 16:57 ` Chris Brandt
2019-12-19 19:01 ` Sergei Shtylyov
2019-12-19 21:04 ` Chris Brandt
2019-12-20 1:45 ` masonccyang
2019-12-20 7:55 ` Geert Uytterhoeven
2019-12-24 16:58 ` Sergei Shtylyov
2019-12-27 0:58 ` Mark Brown
2019-12-17 19:44 ` Sergei Shtylyov
2019-12-18 8:09 ` Boris Brezillon
2019-12-19 16:32 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY1PR01MB1562BC84E2ECF81487A780D38A580@TY1PR01MB1562.jpnprd01.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).