RE: [PATCH v2 2/5] dt-bindings: usb: renesas,usb3-peri: Document HS and SS data bus

[Biju Das <biju.das.jz@bp.renesas.com>]

Hi Shimoda-San,

Thanks for the feedback.

> Subject: RE: [PATCH v2 2/5] dt-bindings: usb: renesas,usb3-peri: Document
> HS and SS data bus
>
> Hi Biju-san,
>
> Thank you for the patch!
>
> > From: Biju Das, Sent: Tuesday, August 11, 2020 5:02 PM
> >
> > Document HS and SS data bus for the "usb-role-switch" enabled case.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> > ---
> > v1->v2: No change
> > Ref:https://patchwork.kernel.org/patch/11669423/
> > ---
> >  .../bindings/usb/renesas,usb3-peri.yaml       | 36 +++++++++++++++----
> >  1 file changed, 30 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usb3-
> peri.yaml
> > b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > index e3cdeab1199f..3eb964af37b8 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> <snip>
> > @@ -79,9 +92,20 @@ examples:
> >          companion = <&xhci0>;
> >          usb-role-switch;
> >
> > -        port {
> > -            usb3_role_switch: endpoint {
> > -                remote-endpoint = <&hd3ss3220_ep>;
> > -            };
> > -        };
> > +    ports {
>
> I think we should use spaces instead of tab here and below.

I have ran dt_binding_check on this file and it did n't complain.

First 5 character must be space, after that if you use tab, it won't complain.
I am not sure is it the correct way or not?

Geert/Shimoda-San can you please comment.
Based on your input, if needed I will send v3 with only spaces.

Cheers,
Biju


> > +    #address-cells = <1>;
> > +    #size-cells = <0>;
> > +    port@0 {
> > +    reg = <0>;
> > +    usb3_hs_ep: endpoint {
> > +    remote-endpoint = <&hs_ep>;
> > +    };
> > +    };
> > +    port@1 {
> > +    reg = <1>;
> > +    usb3_role_switch: endpoint {
> > +    remote-endpoint = <&hd3ss3220_out_ep>;
> > +    };
> > +    };
> > +    };
>
> Best regards,
> Yoshihiro Shimoda
>
> >      };
> > --
> > 2.17.1



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647