From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan-gabriel Mirea Subject: Re: [EXT] Re: [PATCH 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board Date: Sat, 3 Aug 2019 08:00:31 +0000 Message-ID: References: <20190802194702.30249-1-stefan-gabriel.mirea@nxp.com> <20190802194702.30249-2-stefan-gabriel.mirea@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Eddy Petrisor , "will@kernel.org" , "corbet@lwn.net" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , "linux-serial@vger.kernel.org" , "catalin.marinas@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hello Rob, On 8/3/2019 1:38 AM, Rob Herring wrote: > On Fri, Aug 2, 2019 at 1:47 PM Stefan-gabriel Mirea > wrote: >> + - description: S32V234 Customer Evaluation Board > > Most of the entries in this file are for all the boards for an SoC. > >> + items: >> + - enum: >> + - fsl,s32v234-evb > > If that's not going to be the case here, you can use 'const' here. We also intend to submit patches for the SBC-S32V234[1] board in the future and I believe that its 'compatible' should share this entry. Would it therefore be preferable to update the description at this moment and add a comment, like: - description: S32V234 based Boards items: - enum: - fsl,s32v234-evb # S32V234-EVB2 Customer Evaluation Board - const: fsl,s32v234 or just replace the single-value 'enum' with a 'const' for now? Regards, Stefan [1] https://www.nxp.com/design/development-boards/automotive-development-platforms/s32v-mpus-platforms/s32v-vision-and-sensor-fusion-evaluation-board:SBC-S32V234