Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller

From: Leonard Crestez <leonard.crestez@nxp.com>
To: Adam Ford <aford173@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
	Peng Fan <peng.fan@nxp.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Angus Ainslie <angus@akkea.ca>,
	Alexandre Bailon <abailon@baylibre.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Abel Vesa <abel.vesa@nxp.com>,
	Saravana Kannan <saravanak@google.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	Silvano Di Ninno <silvano.dininno@nxp.com>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Anson Huang <anson.huang@nxp.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH v7 0/5] PM / devfreq: Add dynamic scaling for imx8m ddr controller
Date: Mon, 13 Jan 2020 23:36:14 +0000	[thread overview]
Message-ID: <VI1PR04MB7023DA37F366D4C770D7312EEE350@VI1PR04MB7023.eurprd04.prod.outlook.com> (raw)
In-Reply-To: CAHCN7xKjpN_XEGLj-1jMG5mBbF=su67k+10frheLt+L1XaR0-g@mail.gmail.com

On 10.01.2020 20:34, Adam Ford wrote:
> On Wed, Dec 18, 2019 at 10:42 AM Adam Ford <aford173@gmail.com 
> <mailto:aford173@gmail.com>> wrote:
>      > > U-Boot booted and Linux booted, but I still get:
>      > >
>      > >     imx8m-ddrc-devfreq 3d400000.memory-controller: failed to init
>      > > firmware freq info: -19
>      >
>      > Which version of u-boot is that, upstream? I'm subscribed to uboot
>      > mailing list and I see that imx8m support has its own separate issues
>      > but my familiarity is limited :(
> 
>     U-Boot 2020.01-rc4-00244-gf39abbbc53-dirty (Dec 18 2019 - 09:27:40
>     -0600)
> 
>      >
>      > I've only ever tested with NXP uboot and the NXP version of mkimage:
>      >
>      >
>     https://source.codeaurora.org/external/imx/uboot-imx/log/?h=imx_v2019.04_4.19.35_1.1.0
>     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2Flog%2F%3Fh%3Dimx_v2019.04_4.19.35_1.1.0&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735473321&sdata=LhleGMcJzjiNsPbVxmPbvgRVMnl%2F2HxUqVYKcgCFiEg%3D&reserved=0>
>      > https://source.codeaurora.org/external/imx/imx-mkimage/
>     <https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fimx-mkimage%2F&data=02%7C01%7Cleonard.crestez%40nxp.com%7C5babd2cb3fec4dc0a21008d795fbbc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637142780735483320&sdata=enJQ9hgVkIG7frJ9v6QBQAgJBL8j3hWB7RAKa8XhPaw%3D&reserved=0>
> 
>     I will try your versions and see what happens.
> 
>      > My bootloader prints the following BuildInfo:
>      >    - ATF 70fa7bc
>      >
>      >    - U-Boot 2019.04-00019-g4d377539a119
>      >
> 
>     Thanks for your help.
> 
> 
> I wanted to try again after everything was merged into linux-next.
> 
> I am using the U-Boot master (as of 10 Jan 2020), with ATF from 
> 4.19.35_1.1.0 from Code Aurora.  I have tried your ATF, but I don't see 
> any change in behavior.  I have made the DDRC a module, but I still get 
> the same error message.
> 
> [    2.204554] imx8m-ddrc-devfreq 3d400000.memory-controller: failed to 
> init firmware freq info: -19
> 
> Is there something else I can try?

Yes, the NXP branch of uboot from Code Aurora (my commit hash is above).

I understand you want to use uboot and atf master, apparently they both 
need to be patched for this feature to work. It would still be 
interesting to validate.

--
Regards,
Leonard