From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A56C433FE for ; Fri, 4 Dec 2020 00:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F12A3224B1 for ; Fri, 4 Dec 2020 00:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388341AbgLDAdk (ORCPT ); Thu, 3 Dec 2020 19:33:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388323AbgLDAdj (ORCPT ); Thu, 3 Dec 2020 19:33:39 -0500 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BA5CC061A4F for ; Thu, 3 Dec 2020 16:32:53 -0800 (PST) Received: by mail-ot1-x342.google.com with SMTP id f12so3609951oto.10 for ; Thu, 03 Dec 2020 16:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7MdXndgzjeVMMTv3QiHrAis+Wy+JgdC97pj6GXzTuEs=; b=rrhPz0aCBHNoFZGNmmMN3G68Ufo3m06XULdXNz0dtmB8Jcu8E5Dc8VYiNS84HgzrWx nnx7pFHXNx4BaalHJ4+yfLf6g7KIXwb3D+9vQiK+4j13LDYKThsMmRXOixoOv5o47XGt r/Esykp8I56KiF6twfSNhmjCida5oA5rx5yU/nUJHFm0rvX6MNebmH/MmmxBssy/wXn5 eLwSnqZH7LDxGi7QPqaVpepi2cjlvW5l6EihIqrdMsL9gjVC2j9WWRDS1P0DOK1BzZ0o fvv+ZMVlKMdN8u3Zi6LnVBH8DiEeZpf0SQj0WE8+u/hdIKvoQLLEyoZkrV/IYICnelZE 3Z2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7MdXndgzjeVMMTv3QiHrAis+Wy+JgdC97pj6GXzTuEs=; b=Ul732GnBg1kD2dmh9I3MDcXnPSx0c50avEtJtW/ZKgT5arVg81Nf8mDiA1toHNFk7J 7qWobSayfJxG7Xo0JFULFOTU6YYXetIlpMhrWRaZZU29oWfg8NreGmGzpY5mtTJneoWG BmvRnRYqhueA1xEQZ2YbY7phTA5+4NWsfgp3rqM7xjSDb7C73UzGxAoj6t/Ya8Xed0Ho ocxkkdxtmx51Kg8gmj0eYF9557a9StWuabjIjOw5ArBSkz2sEzwZLeJQytb466oGIquw 8/TwQzKVdpalfD6LPo2eFUjl0meycHuHUuIuE0UQO1qeA9MfKTX380cRS16iAJbYshJr pvgQ== X-Gm-Message-State: AOAM533Rufv8DuASaUDkN/SMizfyJtSv1MHS1cCaphXf6WS9du4RyrJq PxsBUo7NRRCbX1de+uHV0HCGCw== X-Google-Smtp-Source: ABdhPJyUhH50Y0gRXUDj8pE+7NFyx2hkbRV6Bio/hg9jUyiQX8C6fqc1MmeIZtnWE9ZZg5d7jPxfIQ== X-Received: by 2002:a9d:d4a:: with SMTP id 68mr1603458oti.101.1607041972646; Thu, 03 Dec 2020 16:32:52 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e3sm293633oot.14.2020.12.03.16.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 16:32:51 -0800 (PST) Date: Thu, 3 Dec 2020 18:32:50 -0600 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Message-ID: References: <20201203191335.927001-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203191335.927001-1-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 03 Dec 13:13 CST 2020, Dmitry Baryshkov wrote: [..] > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml > new file mode 100644 > index 000000000000..1ddeb25cbdc1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,smem.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Shared Memory Manager binding > + > +maintainers: > + - Andy Gross > + - Bjorn Andersson > + > +description: | > + This binding describes the Qualcomm Shared Memory Manager, used to share data > + between various subsystems and OSes in Qualcomm platforms. > + > +properties: > + compatible: y/-/,/ in that compatible, and we only have one. So I think you should instead do: const: "qcom,smem" Apart from that I think the binding looks good. Regards, Bjorn > + enum: > + - "qcom-smem" > +