From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D708FC433E0 for ; Wed, 20 Jan 2021 17:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A9572070A for ; Wed, 20 Jan 2021 17:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727489AbhATRoj (ORCPT ); Wed, 20 Jan 2021 12:44:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387546AbhATRoM (ORCPT ); Wed, 20 Jan 2021 12:44:12 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEC23C061757 for ; Wed, 20 Jan 2021 09:43:10 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id b5so1155668wrr.10 for ; Wed, 20 Jan 2021 09:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R7aUUsfcYcxGvSNOE9xOymWakTzVUOFowM4WuU+q4Pg=; b=szM7sxtOZH9OiVHN21YHTUe8HZnkap3Ywb7gLquh94qffDgX1HUDgtDLdIT2UNAAB/ eGVghpwYfIgYXpIRdlxgBKZnl/GUvG12CahWdRXPAu8cbafSWkHfRraIK8cA60s2s6HC qipvpOKXiaIgTiTIl7asNU7C0HCb57vaJUx4czGiOpLJmJYZ7g/2/nI7Q7eVFSaEtYiM qsFSBfRJ5LYpfvEk7Xn5eKa6w/j9L1fGvGSr30ZmpAqB01ds6MzM62SLmwjmT+D4tSaV Gjfr0iEpHI7h3F4C19eRcjONtPk2QloKq6hgMPYDpqeTsH43a/ITxJzC+XutKf9ybAxL aHqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R7aUUsfcYcxGvSNOE9xOymWakTzVUOFowM4WuU+q4Pg=; b=XI9UO9sJE4aELC3nwFMUFZJiiIvsh2GDrOjL7/RE0RhAwhtXvJbKsSJCI3JbuRJ38J WVmfIgFepYu5B2RNq6l7HMJJeVXPhKN0iHXS+3KUo0ag+g+X4mNYewjUdOZi5VeXsbaP viNvkVq5D/UCxSTSZEtMhbtv97X+gPvye44oglpceSGOvalTGxsQSkfocWWzxVboWhGZ w+CcON2ZTGiu2R+JPYjcqt7/0PxgkO/MuFHNaOAuwKAmW0sbcxj/1hmlQMnobxIDIxj7 mTRG0Yw+7jljMSmWBh4fMkfUSYTaCYn/47kyrxYeaE+8/XBzEntIMwbEG5U5KHJkAESa tn1w== X-Gm-Message-State: AOAM530NKWMcJEGvF2b5VoMsI/BxFmJiv2kfxgtTF+fwOzgj5uEJSWxt +0IVPrgKRa6NGfDsf41K9wGozA== X-Google-Smtp-Source: ABdhPJzpLHHpsQ2g2E4WmLP34m6i58NPSVmOpjvgaXI5blCKQKW8/fkrv6QK9zAcq3kydE0WVN37Ng== X-Received: by 2002:adf:f58f:: with SMTP id f15mr10486618wro.388.1611164589594; Wed, 20 Jan 2021 09:43:09 -0800 (PST) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id j13sm5073106wmi.24.2021.01.20.09.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 09:43:08 -0800 (PST) Date: Wed, 20 Jan 2021 18:42:48 +0100 From: Jean-Philippe Brucker To: Jonathan Cameron Cc: joro@8bytes.org, will@kernel.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, robin.murphy@arm.com, eric.auger@redhat.com, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-accelerators@lists.ozlabs.org, baolu.lu@linux.intel.com, vdumpa@nvidia.com, zhangfei.gao@linaro.org, shameerali.kolothum.thodi@huawei.com, vivek.gautam@arm.com, Arnd Bergmann , Greg Kroah-Hartman , Zhou Wang Subject: Re: [PATCH v9 05/10] uacce: Enable IOMMU_DEV_FEAT_IOPF Message-ID: References: <20210108145217.2254447-1-jean-philippe@linaro.org> <20210108145217.2254447-6-jean-philippe@linaro.org> <20210119122759.000048f9@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119122759.000048f9@Huawei.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jan 19, 2021 at 12:27:59PM +0000, Jonathan Cameron wrote: > On Fri, 8 Jan 2021 15:52:13 +0100 > Jean-Philippe Brucker wrote: > > > The IOPF (I/O Page Fault) feature is now enabled independently from the > > SVA feature, because some IOPF implementations are device-specific and > > do not require IOMMU support for PCIe PRI or Arm SMMU stall. > > > > Enable IOPF unconditionally when enabling SVA for now. In the future, if > > a device driver implementing a uacce interface doesn't need IOPF > > support, it will need to tell the uacce module, for example with a new > > flag. > > > > Signed-off-by: Jean-Philippe Brucker > Hi Jean-Philippe, > > A minor suggestion inline but I'm not that bothered so either way > looks good to me. No problem, I'll add the disable function Thanks, Jean