From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D45C433ED for ; Thu, 1 Apr 2021 04:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8445060BD3 for ; Thu, 1 Apr 2021 04:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232310AbhDAEJx (ORCPT ); Thu, 1 Apr 2021 00:09:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230342AbhDAEJb (ORCPT ); Thu, 1 Apr 2021 00:09:31 -0400 Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [IPv6:2605:2700:0:5::4713:9cab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35617C0613E6; Wed, 31 Mar 2021 21:09:25 -0700 (PDT) Received: from hatter.bewilderbeest.net (unknown [IPv6:2600:6c44:7f:ba20::7c6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id EEF256F; Wed, 31 Mar 2021 21:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1617250163; bh=xmMfpeeniJlU6d7Nfx23h70TUMsB7Ki/f+sL2o7yC2I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kdlFaZDp+5zjWclx7ps6OKfuDJiib1sb3BZsQqHLd38aXr3TZYqUTxJUEA+pHw7v2 leXKIlsarOfpWIU4kpuqSa3+RARc3XxSgm5U7Cje8cqt3WW4v/b4aTU48TfGvP3NaW WbW8ofVx7FaQ2sIEm9QFg3crHzFpHj7iSpU1h+gg= Date: Wed, 31 Mar 2021 23:09:20 -0500 From: Zev Weiss To: Joel Stanley List-Id: Cc: OpenBMC Maillist , Linux ARM , linux-aspeed , Linux Kernel Mailing List , Andrew Jeffery , Arnd Bergmann , Olof Johansson , SoC Team , Rob Herring , devicetree Subject: Re: [PATCH] ARM: dts: aspeed: add ASRock E3C246D4I BMC Message-ID: References: <20210401025104.2278-1-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Mar 31, 2021 at 10:51:42PM CDT, Joel Stanley wrote: >Hi Zev, > >On Thu, 1 Apr 2021 at 02:57, Zev Weiss wrote: >> >> This is a relatively low-cost AST2500-based Xeon E-2100/E-2200 series >> mini-ITX board that we hope can provide a decent platform for OpenBMC >> development. >> >> This initial device-tree provides the necessary configuration for >> basic BMC functionality such as host power control, serial console and >> KVM support, and POST code snooping. > >The patch looks good! Some minor things below. > >When sending subsequent versions, make sure to add -v N to your git >format-patch to mark it as the Nth version. > >You've also set this to be threaded with a previous version of the >patch. We normally don't do that, and in this case it's doubly >confusing as you've split this patch out from the previous series. > >I noticed you cc'd soc@kernel.org. We normally only do this when we >want the soc maintainers to apply a patch directly without going >through another maintainer. In this case the patch should go through >the aspeed maintainer's tree (me), so you don't need to cc that >address. > Hmm, that came from using './scripts/get_maintainer.pl --no-rolestats' with git send-email's --cc-cmd flag; does there happen to be a similarly easy alternative that wouldn't do the "wrong" thing there? Ack on the rest, will send v3 soon. Thanks, Zev >> Signed-off-by: Zev Weiss >> Reviewed-by: Joel Stanley >> --- > >This spot just here is where you should put the changes between v1 and v2. > >> arch/arm/boot/dts/Makefile | 1 + >> .../boot/dts/aspeed-bmc-asrock-e3c246d4i.dts | 202 ++++++++++++++++++ >> 2 files changed, 203 insertions(+) >> create mode 100644 arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 8e5d4ab4e75e..b12911262ca1 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1406,6 +1406,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-ampere-mtjade.dtb \ >> aspeed-bmc-arm-centriq2400-rep.dtb \ >> aspeed-bmc-arm-stardragon4800-rep2.dtb \ >> + aspeed-bmc-asrock-e3c246d4i.dts \ > >This should be the output name (.dtb). > >> aspeed-bmc-bytedance-g220a.dtb \ >> aspeed-bmc-facebook-cmm.dtb \ >> aspeed-bmc-facebook-galaxy100.dtb \ >> diff --git a/arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dts b/arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dts >> new file mode 100644 >> index 000000000000..dcab6e78dfa4 >> --- /dev/null >> +++ b/arch/arm/boot/dts/aspeed-bmc-asrock-e3c246d4i.dts > >The device tree itself looks good! > >If you fix up the things I mentioned and send a v3 I will apply it. > >Cheers, > >Joel > >> @@ -0,0 +1,202 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/dts-v1/; >> + >> +#include "aspeed-g5.dtsi" >> +#include >> +#include >> + >> +/{ >> + model = "ASRock E3C246D4I BMC"; >> + compatible = "asrock,e3c246d4i-bmc", "aspeed,ast2500"; >> + >> + aliases { >> + serial4 = &uart5; >> + }; >> + >> + chosen { >> + stdout-path = &uart5; >> + bootargs = "console=tty0 console=ttyS4,115200 earlyprintk"; >> + }; >> + >> + memory@80000000 { >> + reg = <0x80000000 0x20000000>; >> + }; >> + >> + leds { >> + compatible = "gpio-leds"; >> + >> + heartbeat { >> + /* BMC_HB_LED_N */ >> + gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>; >> + linux,default-trigger = "timer"; >> + }; >> + >> + system-fault { >> + /* SYSTEM_FAULT_LED_N */ >> + gpios = <&gpio ASPEED_GPIO(Z, 2) GPIO_ACTIVE_LOW>; >> + panic-indicator; >> + }; >> + }; >> + >> + gpio-keys { >> + compatible = "gpio-keys"; >> + >> + uid-button { >> + label = "uid-button"; >> + gpios = <&gpio ASPEED_GPIO(F, 1) GPIO_ACTIVE_LOW>; >> + linux,code = ; >> + }; >> + }; >> + >> + iio-hwmon { >> + compatible = "iio-hwmon"; >> + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, >> + <&adc 5>, <&adc 6>, <&adc 7>, <&adc 8>, <&adc 9>, >> + <&adc 10>, <&adc 11>, <&adc 12>; >> + }; >> +}; >> + >> +&fmc { >> + status = "okay"; >> + flash@0 { >> + status = "okay"; >> + m25p,fast-read; >> + label = "bmc"; >> + spi-max-frequency = <100000000>; /* 100 MHz */ >> +#include "openbmc-flash-layout.dtsi" >> + }; >> +}; >> + >> +&uart5 { >> + status = "okay"; >> +}; >> + >> +&vuart { >> + status = "okay"; >> + aspeed,sirq-active-high; >> +}; >> + >> +&mac0 { >> + status = "okay"; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>; >> +}; >> + >> +&i2c1 { >> + status = "okay"; >> + >> + /* thermal sensor, one diode run to a disconnected header */ >> + w83773g@4c { >> + compatible = "nuvoton,w83773g"; >> + reg = <0x4c>; >> + }; >> +}; >> + >> +&i2c3 { >> + status = "okay"; >> + >> + /* FRU EEPROM */ >> + eeprom@57 { >> + compatible = "st,24c128", "atmel,24c128"; >> + reg = <0x57>; >> + pagesize = <16>; >> + }; >> +}; >> + >> +&video { >> + status = "okay"; >> +}; >> + >> +&vhub { >> + status = "okay"; >> +}; >> + >> +&lpc_ctrl { >> + status = "okay"; >> +}; >> + >> +&lpc_snoop { >> + status = "okay"; >> + snoop-ports = <0x80>; >> +}; >> + >> +&gpio { >> + status = "okay"; >> + gpio-line-names = >> + /* A */ "BMC_MAC1_INTB", "BMC_MAC2_INTB", "NMI_BTN_N", "BMC_NMI", >> + "", "", "", "", >> + /* B */ "", "", "", "", "", "IRQ_BMC_PCH_SMI_LPC_N", "", "", >> + /* C */ "", "", "", "", "", "", "", "", >> + /* D */ "BMC_PSIN", "BMC_PSOUT", "BMC_RESETCON", "RESETCON", >> + "", "", "", "", >> + /* E */ "", "", "", "", "", "", "", "", >> + /* F */ "LOCATORLED_STATUS_N", "LOCATORBTN", "", "", >> + "", "", "BMC_PCH_SCI_LPC", "BMC_NCSI_MUX_CTL", >> + /* G */ "HWM_BAT_EN", "CHASSIS_ID0", "CHASSIS_ID1", "CHASSIS_ID2", >> + "BMC_ALERT1_N_R", "BMC_ALERT2_N_R", "BMC_ALERT3_N", "SML0ALERT", >> + /* H */ "FM_ME_RCVR_N", "O_PWROK", "SKL_CNL_R", "D4_DIMM_EVENT_3V_N", >> + "MFG_MODE_N", "BMC_RTCRST", "BMC_HB_LED_N", "BMC_CASEOPEN", >> + /* I */ "", "", "", "", "", "", "", "", >> + /* J */ "BMC_READY", "BMC_PCH_BIOS_CS_N", "BMC_SMI", "", >> + "", "", "", "", >> + /* K */ "", "", "", "", "", "", "", "", >> + /* L */ "BMC_CTS1", "BMC_DCD1", "BMC_DSR1", "BMC_RI1", >> + "BMC_DTR1", "BMC_RTS1", "BMC_TXD1", "BMC_RXD1", >> + /* M */ "BMC_LAN0_DIS_N", "BMC_LAN1_DIS_N", "", "", >> + "", "", "", "", >> + /* N */ "", "", "", "", "", "", "", "", >> + /* O */ "", "", "", "", "", "", "", "", >> + /* P */ "", "", "", "", "", "", "", "", >> + /* Q */ "", "", "", "", >> + "BMC_SBM_PRESENT_1_N", "BMC_SBM_PRESENT_2_N", >> + "BMC_SBM_PRESENT_3_N", "BMC_PCIE_WAKE_N", >> + /* R */ "", "", "", "", "", "", "", "", >> + /* S */ "PCHHOT_BMC_N", "", "RSMRST", >> + "", "", "", "", "", >> + /* T */ "", "", "", "", "", "", "", "", >> + /* U */ "", "", "", "", "", "", "", "", >> + /* V */ "", "", "", "", "", "", "", "", >> + /* W */ "PS_PWROK", /* dummy always-high signal */ >> + "", "", "", "", "", "", "", >> + /* X */ "", "", "", "", "", "", "", "", >> + /* Y */ "SLP_S3", "SLP_S5", "", "", "", "", "", "", >> + /* Z */ "CPU_CATERR_BMC_PCH_N", "", "SYSTEM_FAULT_LED_N", "BMC_THROTTLE_N", >> + "", "", "", "", >> + /* AA */ "CPU1_THERMTRIP_LATCH_N", "", "CPU1_PROCHOT_N", "", >> + "", "", "IRQ_SMI_ACTIVE_N", "FM_BIOS_POST_CMPLT_N", >> + /* AB */ "", "", "ME_OVERRIDE", "BMC_DMI_MODIFY", >> + "", "", "", "", >> + /* AC */ "LAD0", "LAD1", "LAD2", "LAD3", >> + "CK_33M_BMC", "LFRAME", "SERIRQ", "S_PLTRST"; >> + >> + /* Assert BMC_READY so BIOS doesn't sit around waiting for it */ >> + bmc-ready { >> + gpio-hog; >> + gpios = ; >> + output-high; >> + }; >> +}; >> + >> +&adc { >> + status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_adc0_default >> + &pinctrl_adc1_default >> + &pinctrl_adc2_default >> + &pinctrl_adc3_default >> + &pinctrl_adc4_default >> + &pinctrl_adc5_default >> + &pinctrl_adc6_default >> + &pinctrl_adc7_default >> + &pinctrl_adc8_default >> + &pinctrl_adc9_default >> + &pinctrl_adc10_default >> + &pinctrl_adc11_default >> + &pinctrl_adc12_default>; >> +}; >> + >> +&kcs3 { >> + status = "okay"; >> + aspeed,lpc-io-reg = <0xca2>; >> +}; >> -- >> 2.31.1 >>