From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F90C47096 for ; Thu, 3 Jun 2021 15:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B94C613F4 for ; Thu, 3 Jun 2021 15:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbhFCPOh (ORCPT ); Thu, 3 Jun 2021 11:14:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43404 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231846AbhFCPOg (ORCPT ); Thu, 3 Jun 2021 11:14:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=Fb2y9y2wTlsDnlaiZCRMP7KJ4VwgHPLw9e1s4N8XbZc=; b=VU 8SgVaEtfICjnU2iMLl8aKwR5YGpx1SaxE8k6X7CUVI5Mvgz14pQzRFWbHLYDww60eKgmkiklD2nqt 1ByBqbC4n74HsYw/3h/Bk3/ChMm+SWIlhqgzS71abeeAP/iMeXvQA/3p7IhcRVuwqQ7J2YvjmH8rT 7mGe/zMHGGljyVU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lop1L-007dj0-UZ; Thu, 03 Jun 2021 17:12:31 +0200 Date: Thu, 3 Jun 2021 17:12:31 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Igal Liberman , Shruti Kanetkar , Emil Medve , Scott Wood , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Madalin Bucur , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts Message-ID: References: <20210603143453.if7hgifupx5k433b@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210603143453.if7hgifupx5k433b@pali> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 03, 2021 at 04:34:53PM +0200, Pali Rohár wrote: > Hello! > > In commit 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to > the board device tree(s)") was added following DT property into DT node: > arch/powerpc/boot/dts/fsl/t1023rdb.dts fm1mac3: ethernet@e4000 > > phy-connection-type = "sgmii-2500"; > > But currently kernel does not recognize this "sgmii-2500" phy mode. See > file include/linux/phy.h. In my opinion it should be "2500base-x" as > this is mode which operates at 2.5 Gbps. > > I do not think that sgmii-2500 mode exist at all (correct me if I'm > wrong). Kind of exist, unofficially. Some vendors run SGMII over clocked at 2500. But there is no standard for it, and it is unclear how inband signalling should work. Whenever i see code saying 2.5G SGMII, i always ask, are you sure, is it really 2500BaseX? Mostly it gets changed to 2500BaseX after review. PHY mode sgmii-2500 does not exist in mainline. Andrew