From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 02/14] soc: renesas: Identify R-Car H3e-2G and M3e-2G
Date: Mon, 14 Jun 2021 21:31:02 +0300 [thread overview]
Message-ID: <YMegZv0klDVDdsdN@pendragon.ideasonboard.com> (raw)
In-Reply-To: <8e5f14d720f6462fbbcd2caed26c57f1d81166bb.1623315732.git.geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Thu, Jun 10, 2021 at 11:37:15AM +0200, Geert Uytterhoeven wrote:
> Add support for identifying the R-Car H3e-2G (R8A779M1) and R-Car M3e-2G
> (R8A779M3) SoCs.
>
> As these are different gradings of the already supported R-Car H3 ES3.0
> (R8A77951) and M3-W+ (R8A77961) SoCs, support for them is enabled
> through the existing ARCH_R8A77951 and ARCH_R8A77961 configuration
> symbols.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Question: Should we drop fam_rcar_gen3e and soc_rcar_[hm]3e, and just
> use the existing soc_rcar_h3 and soc_rcar_m3_w?
I'd vote for that, as there's no functional difference in the code below
between fam_rcar_gen3e and fam_rcar_gen3.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/soc/renesas/Kconfig | 2 ++
> drivers/soc/renesas/renesas-soc.c | 19 +++++++++++++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> index 4fe0247189a615b0..089c7c50e3ca4c3b 100644
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -213,6 +213,7 @@ config ARCH_R8A77951
> help
> This enables support for the Renesas R-Car H3 SoC (revisions 2.0 and
> later).
> + This includes different gradings like R-Car H3e-2G.
>
> config ARCH_R8A77965
> bool "ARM64 Platform support for R-Car M3-N"
> @@ -234,6 +235,7 @@ config ARCH_R8A77961
> select SYSC_R8A77961
> help
> This enables support for the Renesas R-Car M3-W+ SoC.
> + This includes different gradings like R-Car M3e-2G.
>
> config ARCH_R8A77980
> bool "ARM64 Platform support for R-Car V3H"
> diff --git a/drivers/soc/renesas/renesas-soc.c b/drivers/soc/renesas/renesas-soc.c
> index 0f8eff4a641a21b7..2851fd9c44ce8e3f 100644
> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -33,6 +33,11 @@ static const struct renesas_family fam_rcar_gen3 __initconst __maybe_unused = {
> .reg = 0xfff00044, /* PRR (Product Register) */
> };
>
> +static const struct renesas_family fam_rcar_gen3e __initconst __maybe_unused = {
> + .name = "R-Car Gen3e",
> + .reg = 0xfff00044, /* PRR (Product Register) */
> +};
> +
> static const struct renesas_family fam_rmobile __initconst __maybe_unused = {
> .name = "R-Mobile",
> .reg = 0xe600101c, /* CCCR (Common Chip Code Register) */
> @@ -205,6 +210,16 @@ static const struct renesas_soc soc_rcar_v3u __initconst __maybe_unused = {
> .id = 0x59,
> };
>
> +static const struct renesas_soc soc_rcar_h3e __initconst __maybe_unused = {
> + .family = &fam_rcar_gen3e,
> + .id = 0x4f,
> +};
> +
> +static const struct renesas_soc soc_rcar_m3e __initconst __maybe_unused = {
> + .family = &fam_rcar_gen3e,
> + .id = 0x52,
> +};
> +
> static const struct renesas_soc soc_shmobile_ag5 __initconst __maybe_unused = {
> .family = &fam_shmobile,
> .id = 0x37,
> @@ -275,11 +290,15 @@ static const struct of_device_id renesas_socs[] __initconst = {
> #if defined(CONFIG_ARCH_R8A77950) || defined(CONFIG_ARCH_R8A77951)
> { .compatible = "renesas,r8a7795", .data = &soc_rcar_h3 },
> #endif
> +#ifdef CONFIG_ARCH_R8A77951
> + { .compatible = "renesas,r8a779m1", .data = &soc_rcar_h3e },
> +#endif
> #ifdef CONFIG_ARCH_R8A77960
> { .compatible = "renesas,r8a7796", .data = &soc_rcar_m3_w },
> #endif
> #ifdef CONFIG_ARCH_R8A77961
> { .compatible = "renesas,r8a77961", .data = &soc_rcar_m3_w },
> + { .compatible = "renesas,r8a779m3", .data = &soc_rcar_m3e },
> #endif
> #ifdef CONFIG_ARCH_R8A77965
> { .compatible = "renesas,r8a77965", .data = &soc_rcar_m3_n },
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-06-14 18:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 9:37 [PATCH 00/14] arm64: renesas: Add support for R Car H3e 2G-and M3e-2G Geert Uytterhoeven
2021-06-10 9:37 ` [PATCH 01/14] dt-bindings: arm: renesas: Document R-Car H3e-2G and M3e-2G SoCs and boards Geert Uytterhoeven
2021-06-13 1:13 ` Laurent Pinchart
2021-06-14 11:25 ` Geert Uytterhoeven
2021-06-14 18:24 ` Laurent Pinchart
2021-06-16 17:56 ` Rob Herring
2021-06-23 10:01 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 02/14] soc: renesas: Identify R-Car H3e-2G and M3e-2G Geert Uytterhoeven
2021-06-14 18:31 ` Laurent Pinchart [this message]
2021-06-23 10:13 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 03/14] pinctrl: renesas: Fix pin control matching on R-Car H3e-2G Geert Uytterhoeven
2021-06-14 18:38 ` Laurent Pinchart
2021-06-14 19:16 ` Geert Uytterhoeven
2021-06-23 10:34 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 04/14] mmc: renesas_sdhi: Add support for R-Car H3e-2G and M3e-2G Geert Uytterhoeven
2021-06-14 18:42 ` Laurent Pinchart
2021-06-14 19:32 ` Geert Uytterhoeven
2021-06-24 2:25 ` Yoshihiro Shimoda
2021-06-24 6:14 ` Wolfram Sang
2021-06-24 10:54 ` Yoshihiro Shimoda
2021-06-24 15:19 ` Wolfram Sang
2021-06-25 4:54 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 05/14] arm64: dts: renesas: Add Renesas R8A779M1 SoC support Geert Uytterhoeven
2021-06-14 18:43 ` Laurent Pinchart
2021-06-24 4:56 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 06/14] arm64: dts: renesas: Add Renesas R8A779M3 " Geert Uytterhoeven
2021-06-24 5:08 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 07/14] arm64: dts: renesas: Add support for Salvator-XS with R-Car H3e-2G Geert Uytterhoeven
2021-06-14 18:45 ` Laurent Pinchart
2021-06-14 19:34 ` Geert Uytterhoeven
2021-06-24 5:27 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH 08/14] arm64: dts: renesas: Add support for H3ULCB " Geert Uytterhoeven
2021-06-14 18:46 ` Laurent Pinchart
2021-06-10 9:37 ` [PATCH 09/14] arm64: dts: renesas: Add support for H3ULCB+Kingfisher " Geert Uytterhoeven
2021-06-14 18:46 ` Laurent Pinchart
2021-06-10 9:37 ` [PATCH 10/14] arm64: dts: renesas: Add support for Salvator-XS with R-Car M3e-2G Geert Uytterhoeven
2021-06-14 18:48 ` Laurent Pinchart
2021-06-10 9:37 ` [PATCH 11/14] arm64: dts: renesas: Add support for M3ULCB " Geert Uytterhoeven
2021-06-14 18:48 ` Laurent Pinchart
2021-06-10 9:37 ` [PATCH 12/14] arm64: dts: renesas: Add support for M3ULCB+Kingfisher " Geert Uytterhoeven
2021-06-14 18:48 ` Laurent Pinchart
2021-06-10 9:37 ` [PATCH/RFC 13/14] arm64: dts: renesas: r8a779m1: Add Cortex-A57 2 GHz opp Geert Uytterhoeven
2021-06-16 11:25 ` Yoshihiro Shimoda
2021-06-10 9:37 ` [PATCH/RFC 14/14] arm64: dts: renesas: r8a779m3: " Geert Uytterhoeven
2021-06-16 11:27 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMegZv0klDVDdsdN@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).