From: Greg KH <gregkh@linuxfoundation.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: robh+dt@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, balbi@kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
jackp@codeaurora.org, fntoth@gmail.com
Subject: Re: [PATCH v11 4/5] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default
Date: Fri, 2 Jul 2021 10:19:47 +0200 [thread overview]
Message-ID: <YN7MIzqOxf/3b8zl@kroah.com> (raw)
In-Reply-To: <83237faa-9840-5d31-43da-8ce551e75067@codeaurora.org>
On Fri, Jul 02, 2021 at 01:10:13AM -0700, Wesley Cheng wrote:
>
>
> On 7/1/2021 10:06 PM, Greg KH wrote:
> > On Wed, Jun 30, 2021 at 02:00:41AM -0700, Wesley Cheng wrote:
> >> In order to take advantage of the TX fifo resizing logic, manually add
> >> these properties to the DWC3 child node by default. This will allow
> >> the DWC3 gadget to resize the TX fifos for the IN endpoints, which
> >> help with performance.
> >>
> >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> >> ---
> >> drivers/usb/dwc3/dwc3-qcom.c | 21 +++++++++++++++++++++
> >> 1 file changed, 21 insertions(+)
> >>
> >> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> >> index 49e6ca9..cec4f4a 100644
> >> --- a/drivers/usb/dwc3/dwc3-qcom.c
> >> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> >> @@ -640,6 +640,25 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev)
> >> return ret;
> >> }
> >>
> >> +#ifdef CONFIG_OF
> >> +static void dwc3_qcom_add_dt_props(struct device *dev, struct device_node *np)
> >> +{
> >> + struct property *prop;
> >> + int ret;
> >> +
> >> + prop = devm_kzalloc(dev, sizeof(*prop), GFP_KERNEL);
> >> + if (prop) {
> >> + prop->name = "tx-fifo-resize";
> >> + ret = of_add_property(np, prop);
> >> + if (ret < 0)
> >> + dev_info(dev, "unable to add tx-fifo-resize prop\n");
>
> Hi Greg,
> >
> > Is that really an "informational" error? :(
> >
> >
> We can remove it. If anything we can always check the sysfs if the
> property is present or not.
Sorry for being vague. That message should be dev_err(), and not
dev_info(), right?
> >> + }
> >
> > So if you can not allocate memory, you just fail quietly? Are you sure
> > that is ok?
> >
> > Please properly handle errors.
> >
> OK, will handle the case where we can't allocate memory for the property.
And the case for when of_add_property() fails.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-02 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 9:00 [PATCH v11 0/5] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-06-30 9:00 ` [PATCH v11 1/5] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-07-02 5:00 ` Greg KH
2021-07-02 8:00 ` Wesley Cheng
2021-06-30 9:00 ` [PATCH v11 2/5] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-06-30 9:00 ` [PATCH v11 3/5] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-06-30 9:00 ` [PATCH v11 4/5] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-07-01 1:09 ` kernel test robot
2021-07-02 5:06 ` Greg KH
2021-07-02 8:10 ` Wesley Cheng
2021-07-02 8:19 ` Greg KH [this message]
2021-06-30 9:00 ` [PATCH v11 5/5] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
2021-07-02 5:04 ` [PATCH v11 0/5] Re-introduce TX FIFO resize for larger EP bursting Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7MIzqOxf/3b8zl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fntoth@gmail.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).