From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A93C6377C for ; Mon, 19 Jul 2021 21:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31D45610C7 for ; Mon, 19 Jul 2021 21:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236880AbhGSVGX (ORCPT ); Mon, 19 Jul 2021 17:06:23 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([81.169.146.171]:14767 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383548AbhGSR5E (ORCPT ); Mon, 19 Jul 2021 13:57:04 -0400 X-Greylist: delayed 25816 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Jul 2021 13:56:52 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1626719817; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=f0gx+hbPGHoJTeefnShjVBvl/0tmGDqiZQWxHwnZwpE=; b=pDkiuvAyWPPi0eMORswRqUx88I3TLpQRnGV0HsDL3gbAAlciOZW1+gXEeCCSYNIp2X zn9U/S05tyTlcItOWvvliU8qIhGpCMmYenSJeZrXLhLpTJI2TL0FHzPx83hDK+wPtq72 nAnyl2OhdaQFgMbOqxkWEIjWOqc6jwDuVKVWYvoOAg/qTqFgE/LiHj3L6w5wqQWR61XC KabeY/O+CpPWtt+kO060nkEfj4IxtHh4FQxfqQZiB7WZUbkHks7uJjBPPSaLXlaBFvvS d2d+7JsjOSc22i6vjfja2Ec1YjAnIqbIqORonz2L2w0SuO0xHw5N4iTF4pCvwN945WpZ j5Ow== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8j4Icup" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.28.1 DYNA|AUTH) with ESMTPSA id g02a44x6JIav66d (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 19 Jul 2021 20:36:57 +0200 (CEST) Date: Mon, 19 Jul 2021 20:36:51 +0200 From: Stephan Gerhold To: Andy Shevchenko Cc: Linus Walleij , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , linux-iio , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hans de Goede , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Hans de Goede , Andy Shevchenko ," <~postmarketos/upstreaming@lists.sr.ht>, Nikita Travkin Subject: Re: [PATCH 3/4] iio: accel: bmc150: Make it possible to configure INT2 instead of INT1 Message-ID: References: <20210719112156.27087-1-stephan@gerhold.net> <20210719112156.27087-4-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 19, 2021 at 09:05:48PM +0300, Andy Shevchenko wrote: > On Mon, Jul 19, 2021 at 8:29 PM Stephan Gerhold wrote: > > > > On Mon, Jul 19, 2021 at 07:19:05PM +0300, Andy Shevchenko wrote: > > > On Mon, Jul 19, 2021 at 6:11 PM Stephan Gerhold wrote: > > > > On Mon, Jul 19, 2021 at 06:01:01PM +0300, Andy Shevchenko wrote: > > > > > On Mon, Jul 19, 2021 at 5:07 PM Linus Walleij wrote: > > > > > > On Mon, Jul 19, 2021 at 1:26 PM Stephan Gerhold wrote: > > ... > > > > > > > > #include > > > > > > > +#include > > > > > > (...) > > > > > > > + irq_info = bmc150_accel_interrupts_int1; > > > > > > > + if (irq == of_irq_get_byname(dev->of_node, "INT2")) > > > > > > > + irq_info = bmc150_accel_interrupts_int2; > > > > > > > > > > > > This looks a bit DT-specific, but I don't see that ACPI has > > > > > > named IRQs so I don't know what to do about it either. > > > > > > > > > > Yeah, we only have so far the (de facto) established way of naming > > > > > GPIO based IRQs, and not IOxAPIC ones. > > > > > > > > > > > What does platform_get_irq_byname() do on ACPI systems? > > > > > > > > > > See above. > > > > > > > > > > > If there is no obvious fix I would leave it like this until the > > > > > > first ACPI used needing this comes along, but I think maybe > > > > > > Andy has suggestions. > > > > > > > > > > The platform_get_irq_byname() should do something similar that has > > > > > been done in platform_get_irq() WRT ACPI. > > > > > Here for sure the platform_get_irq_byname() or its optional variant > > > > > should be used. > > > > > > > > I don't think there is a platform device here, we only have the > > > > i2c_client or spi_device. That's why I didn't use > > > > platform_get_irq_byname(). :) > > > > > > > > Is there something equivalent for I2C/SPI drivers? > > > > > > Not yet. You probably need to supply some code there to allow > > > multi-IRQ devices (in resource provider agnostic way). > > > > > > You need to provide fwnode_get_irq_byname() to be similar with > > > https://elixir.bootlin.com/linux/latest/source/drivers/base/property.c#L1010 > > > > > > Then use it in the drivers. > > > > > > And/or integrate into frameworks somehow (something in between the > > > lines: https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L461). > > > > > > > Well, I don't think anyone has an ACPI use case for this right now so > > it's probably better if this is done by someone who actually needs this > > and can test it somewhere. :) > > > > I actually just "copied" this approach from some other IIO drivers where > > this is done similarly (and additionally checked the source code to make > > sure this won't break anything for ACPI platforms). > > I see in today's Linux Next snapshot: > > drivers/iio/accel/fxls8962af-core.c:774: irq = > of_irq_get_byname(of_node, "INT2"); > drivers/iio/accel/mma8452.c:1616: irq2 = > of_irq_get_byname(client->dev.of_node, "INT2"); > drivers/iio/gyro/fxas21002c_core.c:834: irq1 = of_irq_get_byname(np, "INT1"); > drivers/iio/imu/adis16480.c:1265: irq = > of_irq_get_byname(of_node, adis16480_int_pin_names[i]); > drivers/iio/imu/bmi160/bmi160_core.c:655: irq = > of_irq_get_byname(of_node, "INT1"); > drivers/iio/imu/bmi160/bmi160_core.c:661: irq = > of_irq_get_byname(of_node, "INT2"); > > I believe we may stop distributing this and actually start using a > common API. I don't want this to be spread again over all IIO. Btw, I > have LSM9DS0, which supports two INT pins for IMU and currently it > uses hard coded pin mapping. > Hm, I'm not quite sure how to implement this. Could you prepare a patch that would implement such a common API? I would be happy to test it for the device tree and make use of it in this patch. To be honest, I mainly implemented support for the interrupt-names because Jonathan mentioned this would be nice to have [1] and it kind of fit well together with the BMC156 patch that needs the INT2 support. I actually just use the if (data->type == BOSCH_BMC156) part from PATCH 4/4 which does not depend on of_irq_get_byname(). Thanks, Stephan [1]: https://lore.kernel.org/linux-iio/20210611185941.3487efc6@jic23-huawei/