devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Konrad Dybcio <konradybcio@gmail.com>,
	Alexey Minnekhanov <alexeymin@postmarketos.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem
Date: Sat, 24 Jul 2021 20:56:26 +0200	[thread overview]
Message-ID: <YPxiWvUasvLFjG8e@pevik> (raw)
In-Reply-To: <20210622191019.23771-1-petr.vorel@gmail.com>

Hi Bjorn,

could you please queue also this fix? Angler needs it for booting.

Kind regards,
Petr

> As the default definition breaks booting angler:
> [    1.862561] printk: console [ttyMSM0] enabled
> [    1.872260] msm_serial: driver initialized
> D -     15524 - pm_driver_init, Delta

> cont_splash_mem was introduced in 74d6d0a145835, but the problem
> manifested after 86588296acbf ("fdt: Properly handle "no-map" field
> in the memory region").

> Disabling it because Angler's firmware does not report where the memory
> is allocated (dmesg from downstream kernel):
> [    0.000000] cma: Found cont_splash_mem@0, memory base 0x0000000000000000, size 16 MiB, limit 0x0000000000000000
> [    0.000000] cma: CMA: reserved 16 MiB at 0x0000000000000000 for cont_splash_mem

> Similar issue might be on Google Nexus 5X (lg-bullhead). Other MSM8992/4
> are known to report correct address.

> Fixes: 74d6d0a145835 ("arm64: dts: qcom: msm8994/8994-kitakami: Fix up
> the memory map")

> Suggested-by: Konrad Dybcio <konradybcio@gmail.com>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Changes v3->v4:
> * add a comment in dts (asked by Konrad)

> Kind regards,
> Petr

>  arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 ++++
>  1 file changed, 4 insertions(+)

> diff --git a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> index ffe1a9bd8f70..c096b7758aa0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8994-angler-rev-101.dts
> @@ -1,12 +1,16 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /* Copyright (c) 2015, Huawei Inc. All rights reserved.
>   * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
>   */

>  /dts-v1/;

>  #include "msm8994.dtsi"

> +/* Angler's firmware does not report where the memory is allocated */
> +/delete-node/ &cont_splash_mem;
> +
>  / {
>  	model = "Huawei Nexus 6P";
>  	compatible = "huawei,angler", "qcom,msm8994";

      parent reply	other threads:[~2021-07-24 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 19:10 [PATCH v4 1/1] arm64: dts: qcom: msm8994-angler: Disable cont_splash_mem Petr Vorel
2021-07-08 19:08 ` Petr Vorel
2021-07-24 18:56 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPxiWvUasvLFjG8e@pevik \
    --to=petr.vorel@gmail.com \
    --cc=agross@kernel.org \
    --cc=alexeymin@postmarketos.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).