From: Rob Herring <robh@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
shawnguo@kernel.org, kernel@pengutronix.de, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property
Date: Tue, 17 Aug 2021 14:58:00 -0500 [thread overview]
Message-ID: <YRwUyLsvoSpFI9X8@robh.at.kernel.org> (raw)
In-Reply-To: <6e3f6881-929d-1663-58f1-39bf35069175@linaro.org>
On Wed, Aug 11, 2021 at 11:16:49AM +0100, Srinivas Kandagatla wrote:
>
>
> On 10/08/2021 08:35, Joakim Zhang wrote:
> > Introduce "reverse-data" property for nvmem provider to reverse buffer.
> >
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > ---
> > Documentation/devicetree/bindings/nvmem/nvmem.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > index b8dc3d2b6e92..bc745083fc64 100644
> > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > @@ -61,6 +61,11 @@ patternProperties:
> > description:
> > Size in bit within the address range specified by reg.
> > + reverse-data:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description:
> > + Reverse the data that read from the storage device.
> > +
>
> This new property is only going to solve one of the reverse order issue
> here.
> If I remember correctly we have mac-address stored in various formats ex:
> from old thread I can see
>
> Type 1: Octets in ASCII without delimiters. (Swapped/non-Swapped)
> Type 2: Octets in ASCII with delimiters like (":", ",", ".", "-"... so on)
> (Swapped/non-Swapped)
> Type 3: Is the one which stores mac address in Type1/2 but this has to be
> incremented to be used on other instances of eth.
> Type 4: Octets as bytes/u8, swapped/non-swapped
>
> I think its right time to consider adding compatibles to nvmem-cells to be
> able to specify encoding information and handle post processing.
Yes. Trying to handle this with never ending new properties will end up
with a mess. At some point, you just need code to parse the data.
Rob
next prev parent reply other threads:[~2021-08-17 19:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 7:35 [PATCH V1 0/4] nvmem: introduce "reverse-data" property Joakim Zhang
2021-08-10 7:35 ` [PATCH V1 1/4] bindings: " Joakim Zhang
2021-08-10 15:14 ` Jan Lübbe
2021-08-11 8:05 ` Joakim Zhang
2021-08-11 8:06 ` Joakim Zhang
2021-08-11 9:05 ` Jan Lübbe
2021-08-11 10:16 ` Srinivas Kandagatla
2021-08-17 19:58 ` Rob Herring [this message]
2021-08-18 7:54 ` Joakim Zhang
2021-08-24 6:31 ` Joakim Zhang
2021-09-03 12:37 ` Srinivas Kandagatla
2021-09-06 8:58 ` Joakim Zhang
2021-09-07 10:11 ` Srinivas Kandagatla
2021-09-08 7:14 ` Joakim Zhang
2021-09-08 8:48 ` Srinivas Kandagatla
2021-09-08 8:57 ` Joakim Zhang
2021-09-08 9:21 ` Srinivas Kandagatla
2021-08-10 7:35 ` [PATCH V1 2/4] nvmem: core: introduce "reverse-data" property to reverse buffer Joakim Zhang
2021-08-11 9:52 ` Srinivas Kandagatla
2021-08-11 10:16 ` Joakim Zhang
2021-08-10 7:35 ` [PATCH V1 3/4] arm64: dts: imx8m: add "reverse-data" property for MAC ocopt Joakim Zhang
2021-08-10 7:35 ` [PATCH V1 4/4] arm64: dts: imx8m: remove unused "nvmem_macaddr_swap" property for FEC Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRwUyLsvoSpFI9X8@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).