From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
agross@kernel.org, dianders@chromium.org, linux@roeck-us.net,
rnayak@codeaurora.org, lsrao@codeaurora.org,
Mahesh Sivasubramanian <msivasub@codeaurora.org>,
devicetree@vger.kernel.org, Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings
Date: Fri, 24 Sep 2021 18:23:12 -0500 [thread overview]
Message-ID: <YU5d4PhKRvF3wzGX@builder.lan> (raw)
In-Reply-To: <1630906083-32194-2-git-send-email-mkshah@codeaurora.org>
On Mon 06 Sep 00:27 CDT 2021, Maulik Shah wrote:
> From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>
> Add device binding documentation for Qualcomm Technologies, Inc. (QTI)
> SoC sleep stats driver. The driver is used for displaying SoC sleep
> statistic maintained by Always On Processor or Resource Power Manager.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
> .../bindings/soc/qcom/soc-sleep-stats.yaml | 48 ++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
> new file mode 100644
> index 0000000..4161156
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
> +
> +maintainers:
> + - Maulik Shah <mkshah@codeaurora.org>
> + - Lina Iyer <ilina@codeaurora.org>
Lina's address is no longer valid.
> +
> +description:
> + Always On Processor/Resource Power Manager maintains statistics of the SoC
> + sleep modes involving powering down of the rails and oscillator clock.
> +
> + Statistics includes SoC sleep mode type, number of times low power mode were
> + entered, time of last entry, time of last exit and accumulated sleep duration.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,rpmh-sleep-stats
> + - qcom,rpm-sleep-stats
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + # Example of rpmh sleep stats
> + - |
> + aop_msgram@c3f0048 {
> + compatible = "qcom,rpmh-sleep-stats";
> + reg = <0x0c3f0048 0x400>;
As I tested this series I did find it quite odd that the start address
of this block is $48 bytes into a page and still the length is an even
$400.
Is there any single platform where qcom,rpmh-sleep-stats doesn't start
at an offset of $48 from the beginning of its msgram? Could we move this
number to the driver?
Regards,
Bjorn
> + };
> + # Example of rpm sleep stats
> + - |
> + rpm_msgram@4690000 {
> + compatible = "qcom,rpm-sleep-stats";
> + reg = <0x04690000 0x400>;
> + };
> +...
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2021-09-24 23:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1630906083-32194-1-git-send-email-mkshah@codeaurora.org>
2021-09-06 5:27 ` [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings Maulik Shah
2021-09-07 19:58 ` Stephen Boyd
2021-09-24 23:23 ` Bjorn Andersson [this message]
2021-10-05 8:53 ` Maulik Shah
2021-09-06 5:28 ` [PATCH v9 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Maulik Shah
2021-09-06 5:28 ` [PATCH v9 5/5] arm64: dts: qcom: sc7280: " Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU5d4PhKRvF3wzGX@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).