From: Rob Herring <robh@kernel.org>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: linus.walleij@linaro.org, mark.rutland@arm.com,
matthias.bgg@gmail.com, sean.wang@kernel.org,
srv_heupstream@mediatek.com, hui.liu@mediatek.com,
light.hsieh@mediatek.com, biao.huang@mediatek.com,
hongzhou.yang@mediatek.com, sean.wang@mediatek.com,
seiya.wang@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v14 2/5] dt-bindings: pinctrl: mt8195: change pull up/down description
Date: Wed, 29 Sep 2021 16:47:56 -0500 [thread overview]
Message-ID: <YVTfDJNW5Pe3iAR/@robh.at.kernel.org> (raw)
In-Reply-To: <20210924080632.28410-3-zhiyong.tao@mediatek.com>
On Fri, Sep 24, 2021 at 04:06:29PM +0800, Zhiyong Tao wrote:
> For supporting SI units in "bias-pull-down" & "bias-pull-up",
> change pull up/down description
> and add "mediatek,rsel_resistance_in_si_unit" description.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
> .../bindings/pinctrl/pinctrl-mt8195.yaml | 86 ++++++++++++++++++-
> 1 file changed, 84 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> index 2f12ec59eee5..5f642bef72af 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> @@ -49,6 +49,12 @@ properties:
> description: The interrupt outputs to sysirq.
> maxItems: 1
>
> + mediatek,rsel_resistance_in_si_unit:
s/_/-/
> + type: boolean
> + description: |
> + Identifying i2c pins pull up/down type which is RSEL. It can support
> + RSEL define or si unit value(ohm) to set different resistance.
Aren't the RSEL and ohms disjoint values? 0-207 for RSEL and >1000 for
ohms. Why is this property even needed.
> +
> #PIN CONFIGURATION NODES
> patternProperties:
> '-pins$':
> @@ -85,9 +91,85 @@ patternProperties:
> 2/4/6/8/10/12/14/16mA in mt8195.
> enum: [0, 1, 2, 3, 4, 5, 6, 7]
>
> - bias-pull-down: true
> + bias-pull-down:
> + description: |
> + For pull down type is normal, it don't need add RSEL & R1R0 define
> + and resistance value.
> + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to
> + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> + define in mt8195.
> + For pull down type is RSEL, it can add RSEL define & resistance value(ohm)
> + to set different resistance by identifying property "mediatek,rsel_resistance_in_si_unit".
> + It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
> + & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & "MTK_PULL_SET_RSEL_100"
> + & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & "MTK_PULL_SET_RSEL_111"
> + define in mt8195. It can also support resistance value(ohm) "75000" & "5000" in mt8195.
> + oneOf:
Because of the indentation, this is all just part of 'description'.
> + - enum: [100, 101, 102, 103]
> + - description: mt8195 pull down PUPD/R0/R1 type define value.
This entry is always true.
> + - enum: [200, 201, 202, 203, 204, 205, 206, 207]
Are these supposed to be hex?
> + - description: mt8195 pull down RSEL type define value.
And so is this one. That makes 'oneOf' always false.
> + - enum: [75000, 5000]
> + - description: mt8195 pull down RSEL type si unit value(ohm).
> +
> + An example of using RSEL define:
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-down = <MTK_PULL_SET_RSEL_001>;
> + };
> + };
> + An example of using si unit resistance value(ohm):
> + &pio {
> + mediatek,rsel_resistance_in_si_unit;
> + }
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-down = <75000>;
> + };
> + };
>
> - bias-pull-up: true
> + bias-pull-up:
> + description: |
> + For pull up type is normal, it don't need add RSEL & R1R0 define
> + and resistance value.
> + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to
> + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> + define in mt8195.
> + For pull up type is RSEL, it can add RSEL define & resistance value(ohm)
> + to set different resistance by identifying property "mediatek,rsel_resistance_in_si_unit".
> + It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
> + & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & "MTK_PULL_SET_RSEL_100"
> + & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & "MTK_PULL_SET_RSEL_111"
> + define in mt8195. It can also support resistance value(ohm)
> + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195.
> + oneOf:
> + - enum: [100, 101, 102, 103]
> + - description: mt8195 pull up PUPD/R0/R1 type define value.
> + - enum: [200, 201, 202, 203, 204, 205, 206, 207]
> + - description: mt8195 pull up RSEL type define value.
> + - enum: [1000, 1500, 2000, 3000, 4000, 5000, 10000, 75000]
> + - description: mt8195 pull up RSEL type si unit value(ohm).
Same issues here.
> + An example of using RSEL define:
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-up = <MTK_PULL_SET_RSEL_001>;
> + };
> + };
> + An example of using si unit resistance value(ohm):
> + &pio {
> + mediatek,rsel_resistance_in_si_unit;
> + }
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-up = <1000>;
> + };
> + };
>
> bias-disable: true
>
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-09-29 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 8:06 [PATCH v14 0/5] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-09-24 8:06 ` [PATCH v14 1/5] dt-bindings: pinctrl: mt8195: add rsel define Zhiyong Tao
2021-09-24 8:06 ` [PATCH v14 2/5] dt-bindings: pinctrl: mt8195: change pull up/down description Zhiyong Tao
2021-09-29 21:47 ` Rob Herring [this message]
2021-09-30 15:41 ` Linus Walleij
[not found] ` <37eac06e20d82c0fe37a5d8e5633cbbc48d4af29.camel@mediatek.com>
2021-09-30 15:38 ` Linus Walleij
2021-10-13 6:49 ` Chen-Yu Tsai
2021-09-24 8:06 ` [PATCH v14 3/5] pinctrl: mediatek: fix coding style Zhiyong Tao
2021-09-24 8:06 ` [PATCH v14 4/5] pinctrl: mediatek: support rsel feature Zhiyong Tao
2021-09-24 8:55 ` Chen-Yu Tsai
2021-09-24 8:06 ` [PATCH v14 5/5] pinctrl: mediatek: add rsel setting on MT8195 Zhiyong Tao
2021-09-28 22:01 ` [PATCH v14 0/5] Mediatek pinctrl patch on mt8195 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVTfDJNW5Pe3iAR/@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hongzhou.yang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=light.hsieh@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).