From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD872C433EF for ; Tue, 19 Oct 2021 20:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C105B60FC2 for ; Tue, 19 Oct 2021 20:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbhJSU7d (ORCPT ); Tue, 19 Oct 2021 16:59:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbhJSU7c (ORCPT ); Tue, 19 Oct 2021 16:59:32 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE038C061746 for ; Tue, 19 Oct 2021 13:57:19 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id x27-20020a9d459b000000b0055303520cc4so5660154ote.13 for ; Tue, 19 Oct 2021 13:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bCvmWzHQrYIfnO0ni9WAgMr+c10EzSFOwZC7pgW4XHI=; b=uiCrBAiRW2zOddDPJJEsxpT1djYlOt7sAS8zE/E6GGuHPVZOiSEQPa2Nicjk5NGnDS inye6mIny+cC380QqBW7vlpo8qwc8TZNbfskz/jOD6HvnbqQ2clH7C/mgWj/8evaxOmC VUPXz5bEVkcojmwV9hfKJl61c6wPtshobWJXVYEzkqXcpTqZzztEAjYgRbLMjFylCtIQ /bULOvTGm6JPbHw4B49Mlvfd83GeinfF3giG0vW87248ZYHyC/j9uOGBZJySHlpoSbT+ 26M8b8bIM/wtGlM+0TzgzdkSJ8z7u94AzAybdG3u1raDZXlGMP3S4yyMztmcAkvxiMtm U3Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bCvmWzHQrYIfnO0ni9WAgMr+c10EzSFOwZC7pgW4XHI=; b=DsIdpcUoCkAaTHmGFrf3jJ5vWu6zfzi+VmowOD7p87X3Tj1keGqOdTUjY25QZKYH+r Y5zqo89x+91xPePpt9Dxoj3kAgIL9Ud8AIUa55hyixBzwpPAUBDI94dVyaYiyLkfIPQt 5UGJl5sEQO9BsC617VEK7RuZkTRjWJTE539KTYshUE0tUG9GczL99WSmHAZiufw9F6/P NXsZlxKFQcWXsUEh25n0QMyzm5gSiJausck35CKGFJDqN7zy8jsCDJUhtChFociZJXRY vmSa0u6dvUBW0D1zZlGL+TjY/lGkX1U4ctdHKnJPbF4ic6LYWO3rk9w5Tx70KF9G1Gc8 tz4Q== X-Gm-Message-State: AOAM530G58N4lRRW4AseOyIZDA2eqbTfwm9DWGbvtadRGGF3ttMZdFku /2g8ARa/FkkwPQVDvFhXzuJpAQ== X-Google-Smtp-Source: ABdhPJxYKbXVgJME4uWfjnB1za8f5xBVAtcttFEGbUiN1i8iAO/vSf6B027OrhcBA1UCQTNb1JZjIw== X-Received: by 2002:a05:6830:24a9:: with SMTP id v9mr7189676ots.326.1634677038861; Tue, 19 Oct 2021 13:57:18 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id e23sm29938oih.40.2021.10.19.13.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 13:57:18 -0700 (PDT) Date: Tue, 19 Oct 2021 13:59:03 -0700 From: Bjorn Andersson To: Arnd Bergmann , Rajesh Patil Cc: Andy Gross , Rob Herring , linux-arm-msm , Linux Kernel Mailing List , DTML , Rajendra Nayak , Sai Prakash Ranjan , msavaliy@qti.qualcomm.com, satya priya , Stephen Boyd , Matthias Kaehlcke , Doug Anderson Subject: Re: [PATCH V10 8/8] arm64: dts: sc7280: Add aliases for I2C and SPI Message-ID: References: <1632399378-12229-1-git-send-email-rajpat@codeaurora.org> <1632399378-12229-9-git-send-email-rajpat@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 19 Oct 13:43 PDT 2021, Arnd Bergmann wrote: > On Thu, Sep 23, 2021 at 2:18 PM Rajesh Patil wrote: > > > > Add aliases for i2c and spi for sc7280 soc. > > > > Signed-off-by: Rajesh Patil > > Reviewed-by: Stephen Boyd > > I saw this in the pull request, can this please be reverted? > Yes, this can certainly be corrected. > Putting the aliases into the .dtsi file is really silly, as there are > likely boards that > don't connect every single one of those, and then will have to > override and renumber > them. > > Please only list the aliases that are actually connected on a particular > board. > > Arnd > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > index c26647a..e5fefd1 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > @@ -26,8 +26,40 @@ > > chosen { }; > > > > aliases { > > + i2c0 = &i2c0; > > + i2c1 = &i2c1; > > + i2c2 = &i2c2; > > + i2c3 = &i2c3; > > + i2c4 = &i2c4; > > + i2c5 = &i2c5; > > + i2c6 = &i2c6; > > + i2c7 = &i2c7; > > + i2c8 = &i2c8; > > + i2c9 = &i2c9; > > + i2c10 = &i2c10; > > + i2c11 = &i2c11; > > + i2c12 = &i2c12; > > + i2c13 = &i2c13; > > + i2c14 = &i2c14; > > + i2c15 = &i2c15; > > mmc1 = &sdhc_1; > > mmc2 = &sdhc_2; > > The mmc ones should probably go away as well. > I should have paid more attention when applying this patch, because the commit message should have stated why any of these were introduced. @Rajesh, can you please help me understand the need for any of these and prepare a patch that introduce the specific ones needed in the individual board dts(i) files - with reasoning for the aliases in the commit message. Thanks, Bjorn > > + spi0 = &spi0; > > + spi1 = &spi1; > > + spi2 = &spi2; > > + spi3 = &spi3; > > + spi4 = &spi4; > > + spi5 = &spi5; > > + spi6 = &spi6; > > + spi7 = &spi7; > > + spi8 = &spi8; > > + spi9 = &spi9; > > + spi10 = &spi10; > > + spi11 = &spi11; > > + spi12 = &spi12; > > + spi13 = &spi13; > > + spi14 = &spi14; > > + spi15 = &spi15; > > }; > >