From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812F2C4332F for ; Thu, 14 Oct 2021 10:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DE01611AD for ; Thu, 14 Oct 2021 10:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbhJNKuF (ORCPT ); Thu, 14 Oct 2021 06:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230265AbhJNKuE (ORCPT ); Thu, 14 Oct 2021 06:50:04 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC17EC061570 for ; Thu, 14 Oct 2021 03:47:59 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id x27so24836248lfa.9 for ; Thu, 14 Oct 2021 03:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Y5SU88VxmkbI0mbNF2Xaeysw2Rm83gIlpNsXvM/RlQ0=; b=4RgwXXXSWg3C2mppMJSND+KOR94oio05+Xw63mT7iar0p7GhNdHyDkT/Lozhx5izV2 UzmxuboW6Rk3kCgQWDR2EGckgx8pVIxL8wBbky1TRC1Cw9CefYgON7p8aX4/SG+wqSWQ RT6D5W8HEJVxoAdgA0/o25eP2+uGpob+EIMlgtQhO+wY3acAnf0wN1K2mA5EO+a6AD/B zHUTZbAnFCnMVov1FsUWbUmBEi98Wij7diWFlsOPMN9sZa/YupuWKzoG2Gi/vSEQYBvN ezTEJvpQvPnQ2geBDtH9OZ0YMqIpClHnHD9YY6ps/Gc1bACqd4k6czH5ongLS8qQz1ke aQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Y5SU88VxmkbI0mbNF2Xaeysw2Rm83gIlpNsXvM/RlQ0=; b=1NauX4RmaHx7N7kWrTm+29es9dzlM5iEH60QBoneoWOEsE6SipNd9ocuT9K0evHTio rNVwIt3CwNy6u37ukkURnD/b6i7xsn9FsvD5LLYGHwKczO//2MXih8iy4wIkSqxtX0T7 eVPibJUUTowr6LnVaZXKHOXBZnnnfIgCVfzBQxMyOrRqyM8RHIQHxIOhpo+NKPMdmSvu e50S2mcPynOi71m9Zw3N0zXyUzYMIbIsdHr1NEWD2jz/XsnS6NUBwJS4Ygkxv5nIzpfs Zek6S5qmyJLFzjfVmCh+U2IttOddwID48SEWqIcnYX9bq7ULfQxBjtPN3sg821wfUFwC XUzQ== X-Gm-Message-State: AOAM533J0lBD+DhZTJ9FOQsDFkFeTmvVCkCSuY81Isqvi4dWoW0dknsd 8b2MKQctnLSZAGPxZD1EZLGXM7HooxCvOFVc X-Google-Smtp-Source: ABdhPJzcdE5baOuW79vInqMNEd95GdH46CZDxL0qynIX10cSbctJtc/a9FLLrvy1gtxkc5/UmSGp6Q== X-Received: by 2002:ac2:5a0c:: with SMTP id q12mr4440494lfn.133.1634208478334; Thu, 14 Oct 2021 03:47:58 -0700 (PDT) Received: from localhost (h-46-59-88-219.A463.priv.bahnhof.se. [46.59.88.219]) by smtp.gmail.com with ESMTPSA id x1sm195759lfr.83.2021.10.14.03.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 03:47:57 -0700 (PDT) Date: Thu, 14 Oct 2021 12:47:57 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Rob Herring , Kieran Bingham , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Media Mailing List , Linux-Renesas Subject: Re: [PATCH] dt-bindings: adv748x: Convert bindings to json-schema Message-ID: References: <20211012183324.717975-1-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Geert, Thanks for your review. On 2021-10-13 17:08:44 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > Thanks for your patch! > > On Tue, Oct 12, 2021 at 8:48 PM Niklas Söderlund > wrote: > > Convert ADV748X analog video decoder documentation to json-schema. > > You may want to list what changes you made: > - Add missing ports subnode > - Anything else I didn't notice? ;-) Wops, I intended to mention the addition of ports node. Thanks for noticing, will send a v2. > > > Signed-off-by: Niklas Söderlund > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.yaml > > > + reg-names: > > + minItems: 1 > > + items: > > + - const: main > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > + - enum: [ dpll, cp, hdmi, edid, repeater, infoframe, cbus, cec, sdp, txa, txb ] > > They can really appear in any order? Yes they are refereed by i2c_new_ancillary_device() so any order is fine. They can only appear once tho, but I'm not sure how to enforce that. > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: adi,adv7481 > > + then: > > + properties: > > + interrupts: > > + minItems: 1 > > + maxItems: 3 > > + > > + interrupt-names: > > + minItems: 1 > > + items: > > + - enum: [ intrq1, intrq2, intrq3 ] > > + - enum: [ intrq1, intrq2, intrq3 ] > > + - enum: [ intrq1, intrq2, intrq3 ] > > They can really appear in any order? Yes, as not all interrupt lines may be wired up. It would be nice to enforce that intrq2 must come before intrq3 if both are wired but I'm not sure how to express that. > > > + else: > > + properties: > > + interrupts: > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupt-names: > > + minItems: 1 > > + items: > > + - enum: [ intrq1, intrq2 ] > > + - enum: [ intrq1, intrq2 ] > > They can really appear in any order? > > If not, you can merge the entries, and just override maxItems. > > The rest looks good to me, but I'm no graph expert. > Reviewed-by: Geert Uytterhoeven Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Niklas Söderlund