Re: [PATCH] dt-bindings: adv748x: Convert bindings to json-schema

["Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>]

Hi Geert,

On 2021-10-14 14:14:26 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> On Thu, Oct 14, 2021 at 1:39 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > On 2021-10-14 13:07:30 +0200, Geert Uytterhoeven wrote:
> > > On Thu, Oct 14, 2021 at 12:48 PM Niklas Söderlund
> > > <niklas.soderlund+renesas@ragnatech.se> wrote:
> > > > On 2021-10-13 17:08:44 +0200, Geert Uytterhoeven wrote:
> > > > > On Tue, Oct 12, 2021 at 8:48 PM Niklas Söderlund
> > > > > <niklas.soderlund+renesas@ragnatech.se> wrote:
> > > > > > Convert ADV748X analog video decoder documentation to json-schema.
> > >
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.yaml
> > >
> > > > > > +allOf:
> > > > > > +  - if:
> > > > > > +      properties:
> > > > > > +        compatible:
> > > > > > +          contains:
> > > > > > +            const: adi,adv7481
> > > > > > +    then:
> > > > > > +      properties:
> > > > > > +        interrupts:
> > > > > > +          minItems: 1
> > > > > > +          maxItems: 3
> > > > > > +
> > > > > > +        interrupt-names:
> > > > > > +          minItems: 1
> > > > > > +          items:
> > > > > > +            - enum: [ intrq1, intrq2, intrq3 ]
> > > > > > +            - enum: [ intrq1, intrq2, intrq3 ]
> > > > > > +            - enum: [ intrq1, intrq2, intrq3 ]
> > > > >
> > > > > They can really appear in any order?
> > > >
> > > > Yes, as not all interrupt lines may be wired up. It would be nice to
> > > > enforce that intrq2 must come before intrq3 if both are wired but I'm
> > > > not sure how to express that.
> > >
> > > You mean
> > >
> > >     items:
> > >       - const: intrq1
> > >       - const: intrq2
> > >       - const: intrq3
> >
> > Will this not enforce that if intrq2 is present intrq1 must be too?
> >
> > >
> > > ?
> > >
> > > If the first two might be exchanged, you can still fix the last one:
> > >
> > >     items:
> > >       - const: [ intrq1, intrq2 ]
> > >       - const: [ intrq1, intrq2 ]
> > >       - const: intrq3
> >
> > Same here, will this not fail if only intrq3 is given?
> 
> Right. And these combinations are all valid?

Yes, there is two or three depending on model irq pins on the device 
itself and all, none or any combination of them could be wired up.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Regards,
Niklas Söderlund