From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EBFC433F5 for ; Mon, 29 Nov 2021 22:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233657AbhK2WlB (ORCPT ); Mon, 29 Nov 2021 17:41:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233215AbhK2Wjz (ORCPT ); Mon, 29 Nov 2021 17:39:55 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 207CFC1262BA for ; Mon, 29 Nov 2021 10:02:22 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id i12so17725561pfd.6 for ; Mon, 29 Nov 2021 10:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QXp6Rjdb9so9tn9PWuGIbuOUwfs9Jwsb1LIx5Ujs/yw=; b=OWuHk7RoCEwXKDMDXfCljE037wZMeREf4yKV9u6svRDiDf1m8rOYK2y6iK2FrztOTt ulu8jIK1sFPK88tkYTVGUMBm/iwGCD1nk1R1B5xcDAuMU8MRkTSuxNThPJ+ExZYIGyG+ qn/tj3SRQs4Igp74uqeU0o/fqEg5xwKxZp3CU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QXp6Rjdb9so9tn9PWuGIbuOUwfs9Jwsb1LIx5Ujs/yw=; b=nFIljnTIP0L2OACP36zpNJBvuQ+LfNup97xZ/tQX5Q79OdKSBTh22RvDOIE+NBeJ7p iKv5NVH2jAgU1ZYbNIFf7/eHNOXEAYZdJJhRkwrQhR7inB7aAL1i8fEq8mlML3bJQNDD LRzkEq0TBizR4fLcG31/t8js2bdUycWZHBWkJIwA0QMfuh8Zg2TrHr8y3YmyA+/QW8JJ vzKM8KPxIgisWco/pGRV2RIVOOnlRwo+NsEzADlGx2EmtKlQN0+MnizH5/JRtdp8vJh9 yFEztmQGaanuJfh224NlOLCYflqLfIeTZPWE9Qg9NwZpjjYDTlsv5+Pv+jZ1OqW0KpgJ ImiQ== X-Gm-Message-State: AOAM533U5OKC+yff90SJwtl8PFdugx3+7J0nhe7uCrEtMqjhs3CW08hI h2xhdN8/2y3XmhJBJzqrcWDIPQ== X-Google-Smtp-Source: ABdhPJzmsIA11/pFaCm4cakUSOz2ziL/uU5FLtsc2LHAl9CDHjLHoupWOsGCvTUPwfVjMQ9Wn70QUw== X-Received: by 2002:a63:1956:: with SMTP id 22mr36174289pgz.452.1638208941713; Mon, 29 Nov 2021 10:02:21 -0800 (PST) Received: from localhost ([2620:15c:202:201:d16f:3a09:ab7a:238e]) by smtp.gmail.com with UTF8SMTPSA id k19sm18083179pff.20.2021.11.29.10.02.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Nov 2021 10:02:21 -0800 (PST) Date: Mon, 29 Nov 2021 10:02:20 -0800 From: Matthias Kaehlcke To: Sandeep Maheswaram Cc: Rob Herring , Andy Gross , Bjorn Andersson , Stephen Boyd , Doug Anderson , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com Subject: Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi Message-ID: References: <1637837815-8532-1-git-send-email-quic_c_sanm@quicinc.com> <1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote: > Remove USB2 controller and phy nodes from common dtsi file as it is > required only for SKU1 board. > > Signed-off-by: Sandeep Maheswaram A series shouldn't break things if it is only applied partially (in order). In this case the USB2 controller wouldn't work on the SKU1 board if only this patch is applied. It should be squashed with patch 2 of this series ("arm64: qcom: sc7280: Add USB2 controller and phy nodes for SKU1 board"). Also doing the move in a single patch instead of two separate patches for remove and add makes it easier to review the latter part, since it's evident from the patch itself that it's just a move.