From: Rob Herring <robh@kernel.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, pure.logic@nexus-software.ie,
bjorn.andersson@linaro.org, greg@kroah.com,
linux-kernel@vger.kernel.org, quic_tsoni@quicinc.com,
quic_psodagud@quicinc.com, quic_satyap@quicinc.com,
quic_pheragu@quicinc.com, quic_rjendra@quicinc.com,
quic_sibis@quicinc.com, quic_saipraka@quicinc.com
Subject: Re: [PATCH V2 6/8] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector
Date: Mon, 13 Dec 2021 13:59:01 -0600 [thread overview]
Message-ID: <YbemBSexMQRCVGYl@robh.at.kernel.org> (raw)
In-Reply-To: <d035e37829c6f9ec8f01d1137020af635e34966f.1638430506.git.quic_schowdhu@quicinc.com>
On Thu, Dec 02, 2021 at 03:21:25PM +0530, Souradeep Chowdhury wrote:
> Add the Embedded USB Debugger(EUD) device tree node. The
> node contains EUD base register region and EUD mode
> manager register regions along with the interrupt entry.
> Also add the connector to EUD which is mapped as the child
> of dwc3. The connector is attached to EUD via port. Also add
> the role-switch property to dwc3 node.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 53a21d0..2d14e5c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1315,6 +1315,18 @@
> phys = <&usb_2_hsphy>;
> phy-names = "usb2-phy";
> maximum-speed = "high-speed";
> + usb-role-switch;
> + usb_con: eud_usb_connector {
> + compatible = "qcom,usb-connector-eud",
> + "usb-c-connector";
> + ports {
> + port@0 {
It is already defined that port@0 of the connector is USB HS data. Is
that the case here? What about the SS lines?
From the description, it sounds like the data path is DWC3 -> EUD ->
connector. The DT structure doesn't match that.
> + usb2_role_switch: endpoint {
> + remote-endpoint = <&eud_ep>;
> + };
> + };
> + };
> + };
> };
> };
>
> @@ -1339,6 +1351,19 @@
> interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + eud: eud@88e0000 {
> + compatible = "qcom,sc7280-eud","qcom,eud";
> + reg = <0 0x88e0000 0 0x2000>,
> + <0 0x88e2000 0 0x1000>;
> + interrupt-parent = <&pdc>;
> + interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> + port {
> + eud_ep: endpoint {
> + remote-endpoint = <&usb2_role_switch>;
> + };
> + };
> + };
> +
> nsp_noc: interconnect@a0c0000 {
> reg = <0 0x0a0c0000 0 0x10000>;
> compatible = "qcom,sc7280-nsp-noc";
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2021-12-13 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:51 [PATCH V2 0/8] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 1/8] dt-bindings: Add the yaml bindings for EUD Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 2/8] dt-bindings: connector: Add property for EUD type-C connector Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 3/8] bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 4/8] usb: dwc3: drd: Register the eud connector child node for dwc3 Souradeep Chowdhury
2021-12-13 20:03 ` Rob Herring
2021-12-15 12:06 ` Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 5/8] soc: qcom: eud: Add driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2021-12-03 11:04 ` Greg KH
2021-12-06 4:54 ` Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 6/8] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector Souradeep Chowdhury
2021-12-13 19:59 ` Rob Herring [this message]
2021-12-15 12:36 ` Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 7/8] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2021-12-02 9:51 ` [PATCH V2 8/8] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbemBSexMQRCVGYl@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=quic_pheragu@quicinc.com \
--cc=quic_psodagud@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).