From: Rob Herring <robh@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Akhil R <akhilrajeev@nvidia.com>,
andy.shevchenko@gmail.com, christian.koenig@amd.com,
dri-devel@lists.freedesktop.org, jonathanh@nvidia.com,
ldewangan@nvidia.com, linaro-mm-sig@lists.linaro.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-tegra@vger.kernel.org,
p.zabel@pengutronix.de, sumit.semwal@linaro.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] Add SMBus features to Tegra I2C
Date: Wed, 15 Dec 2021 12:42:32 -0600 [thread overview]
Message-ID: <Ybo3GNYSZ9HLIwqj@robh.at.kernel.org> (raw)
In-Reply-To: <YbMWPGMcHEQXGkHf@orome>
On Fri, Dec 10, 2021 at 09:56:28AM +0100, Thierry Reding wrote:
> On Thu, Dec 09, 2021 at 07:04:30PM +0300, Dmitry Osipenko wrote:
> > 09.12.2021 18:05, Akhil R пишет:
> > > Add support for SMBus Alert and SMBus block read functions to
> > > i2c-tegra driver
> > >
> > > Akhil R (2):
> > > dt-bindings: i2c: tegra: Add SMBus feature properties
> > > i2c: tegra: Add SMBus block read and SMBus alert functions
> > >
> > > .../devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 4 ++
> > > drivers/i2c/busses/i2c-tegra.c | 54 +++++++++++++++++++++-
> > > 2 files changed, 57 insertions(+), 1 deletion(-)
> > >
> >
> > How this was tested? This series must include the DT patch. If there is
> > no real user in upstream for this feature, then I don't think that we
> > should bother at all about it.
>
> This is primarily used by a device that uses ACPI and the driver uses
> the firmware-agnostic APIs to get at this. However, it also means that
> the driver effectively provides this same support for DT via those APIs
> and therefore it makes sense to document that part even if there are no
> current users of the DT bits.
Then definitely a NAK.
> One big advantage of this is that it helps keep the ACPI and DT bindings
> in sync, and document this on the DT side also allows us to document the
> ACPI side of things where no formal documentation exists, as far as I
> know.
I have no bandwidth to review ACPI bindings and don't think the whole
use DT bindings in ACPI is a good idea either. If someone wants this to
be a thing, then they need to step up and review bindings.
Rob
prev parent reply other threads:[~2021-12-15 18:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:05 [PATCH 0/2] Add SMBus features to Tegra I2C Akhil R
2021-12-09 15:05 ` [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties Akhil R
2021-12-09 15:30 ` Andy Shevchenko
2021-12-15 18:37 ` Rob Herring
2021-12-09 15:05 ` [PATCH 2/2] i2c: tegra: Add SMBus block read and SMBus alert functions Akhil R
2021-12-09 15:27 ` Dmitry Osipenko
2021-12-10 9:38 ` Akhil R
2021-12-11 20:07 ` Dmitry Osipenko
2021-12-11 20:12 ` Dmitry Osipenko
2021-12-09 15:30 ` Dmitry Osipenko
2021-12-09 15:33 ` Andy Shevchenko
2021-12-09 15:42 ` Dmitry Osipenko
2021-12-09 15:43 ` Dmitry Osipenko
2021-12-09 16:04 ` [PATCH 0/2] Add SMBus features to Tegra I2C Dmitry Osipenko
2021-12-10 8:56 ` Thierry Reding
2021-12-15 18:42 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybo3GNYSZ9HLIwqj@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=christian.koenig@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).