From: Rob Herring <robh@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
Lin Huang <hl@rock-chips.com>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-pm@vger.kernel.org, Derek Basehore <dbasehore@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] dt-bindings: devfreq: rk3399_dmc: Add more disable-freq properties
Date: Tue, 11 Jan 2022 20:04:04 -0600 [thread overview]
Message-ID: <Yd43FL2JihCdn8Ta@robh.at.kernel.org> (raw)
In-Reply-To: <20220107155215.4.I382d4de737198ea52deb118c9bdc4d93d76e009e@changeid>
On Fri, Jan 07, 2022 at 03:53:14PM -0800, Brian Norris wrote:
> DDR DVFS tuning has found that several power-saving features don't have
> good tradeoffs at higher frequencies -- at higher frequencies, we'll see
> glitches or other errors. Provide tuning controls so these can be
> disabled at higher OPPs, and left active only at the lower ones.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>
> .../bindings/devfreq/rk3399_dmc.yaml | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml
> index 2c871c57fd97..357d07c5a3df 100644
> --- a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml
> @@ -271,6 +271,43 @@ properties:
> When the DRAM type is LPDDR4, this parameter defines the PHY side ODT
> strength. Default value is 60.
>
> + rockchip,pd_idle_dis_freq:
s/_/-/
on all the new properties.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Defines the power-down idle disable frequency in Hz. When the DDR
> + frequency is greater than pd_idle_dis_freq, power-down idle is disabled.
> + See also rockchip,pd_idle.
> +
> + rockchip,sr_idle_dis_freq:
'-hz' suffix. Let's not repeat the same problem.
> + $ref: /schemas/types.yaml#/definitions/uint32
And then the type can be dropped.
> + description:
> + Defines the self-refresh idle disable frequency in Hz. When the DDR
> + frequency is greater than sr_idle_dis_freq, self-refresh idle is
> + disabled. See also rockchip,sr_idle.
> +
> + rockchip,sr_mc_gate_idle_dis_freq:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Defines the self-refresh and memory-controller clock gating disable
> + frequency in Hz. When the DDR frequency is greater than
> + sr_mc_gate_idle_dis_freq, the clock will not be gated when idle. See also
> + rockchip,sr_mc_gate_idle.
> +
> + rockchip,srpd_lite_idle_dis_freq:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Defines the self-refresh power down idle disable frequency in Hz. When
> + the DDR frequency is greater than srpd_lite_idle_dis_freq, memory will
> + not be placed into self-refresh power down mode when idle. See also
> + rockchip,srpd_lite_idle.
> +
> + rockchip,standby_idle_dis_freq:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Defines the standby idle disable frequency in Hz. When the DDR frequency
> + is greater than standby_idle_dis_freq, standby idle is disabled. See also
> + rockchip,standby_idle.
> +
> additionalProperties: false
>
> examples:
> @@ -294,4 +331,9 @@ examples:
> rockchip,ddr3_odt_dis_freq = <333000000>;
> rockchip,lpddr3_odt_dis_freq = <333000000>;
> rockchip,lpddr4_odt_dis_freq = <333000000>;
> + rockchip,pd_idle_dis_freq = <1000000000>;
> + rockchip,sr_idle_dis_freq = <1000000000>;
> + rockchip,sr_mc_gate_idle_dis_freq = <1000000000>;
> + rockchip,srpd_lite_idle_dis_freq = <0>;
> + rockchip,standby_idle_dis_freq = <928000000>;
> };
> --
> 2.34.1.575.g55b058a8bb-goog
>
>
next prev parent reply other threads:[~2022-01-12 2:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 23:53 [PATCH 00/10] rk3399: Clean up and enable DDR DVFS Brian Norris
2022-01-07 23:53 ` [PATCH 01/10] dt-bindings: devfreq: rk3399_dmc: Convert to YAML Brian Norris
2022-01-09 16:33 ` Rob Herring
2022-01-10 17:16 ` Rob Herring
2022-01-07 23:53 ` [PATCH 02/10] dt-bindings: devfreq: rk3399_dmc: Deprecate unused/redundant properties Brian Norris
2022-01-12 1:59 ` Rob Herring
2022-01-07 23:53 ` [PATCH 03/10] dt-bindings: devfreq: rk3399_dmc: Fix Hz units Brian Norris
2022-01-12 2:01 ` Rob Herring
2022-01-07 23:53 ` [PATCH 04/10] dt-bindings: devfreq: rk3399_dmc: Add more disable-freq properties Brian Norris
2022-01-12 2:04 ` Rob Herring [this message]
2022-01-07 23:53 ` [PATCH 05/10] PM / devfreq: rk3399_dmc: Drop undocumented ondemand DT props Brian Norris
2022-01-07 23:53 ` [PATCH 06/10] PM / devfreq: rk3399_dmc: Drop excess timing properties Brian Norris
2022-01-07 23:53 ` [PATCH 07/10] PM / devfreq: rk3399_dmc: Use bitfield macro definitions for ODT_PD Brian Norris
2022-01-07 23:53 ` [PATCH 08/10] PM / devfreq: rk3399_dmc: Support new disable-freq properties Brian Norris
2022-01-07 23:53 ` [PATCH 09/10] arm64: dts: rk3399: Add dfi and dmc nodes Brian Norris
2022-01-07 23:53 ` [PATCH 10/10] arm64: dts: rockchip: Enable dmc and dfi nodes on gru Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd43FL2JihCdn8Ta@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=briannorris@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).