From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Watson Chow <watson.chow@avnet.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulators: Add bindings for Maxim MAX20086-MAX20089
Date: Tue, 4 Jan 2022 16:43:12 +0200 [thread overview]
Message-ID: <YdRdAI4S0+85CuDy@pendragon.ideasonboard.com> (raw)
In-Reply-To: <YdRZJWbOxkgkVgje@sirena.org.uk>
Hi Mark,
Thank you for the review.
On Tue, Jan 04, 2022 at 02:26:45PM +0000, Mark Brown wrote:
> On Sun, Jan 02, 2022 at 11:11:23PM +0200, Laurent Pinchart wrote:
>
> > + patternProperties:
> > + "^OUT[1-4]$":
> > + type: object
> > + $ref: regulator.yaml#
> > +
> > + required:
> > + - OUT1
> > + - OUT2
>
> Why are we requiring that there be machine constraints for the
> individual regulators? There's already a problem with people just
> using the maximum possible control a regulator has as the default for
> devices without regard to what the specific system can support.
Could you elaborate a bit, keeping in mind that I'm a newbie when it
comes to the regulator framework ? :-)
The MAX2008[6789] can't control the voltage or current. The outputs can
be enabled or disabled individually, but their voltage is fixed to the
input voltage. There's overcurrent protection, with a threshold set by a
resistor and not known to the driver. The voltage (and current I
believe) can be measured, and alarms can be raised through an interrupt.
How should I modify the DT bindings to match that correctly ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-01-04 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220102211124.18435-1-laurent.pinchart+renesas@ideasonboard.com>
2022-01-02 21:11 ` [PATCH 1/2] dt-bindings: regulators: Add bindings for Maxim MAX20086-MAX20089 Laurent Pinchart
2022-01-04 14:26 ` Mark Brown
2022-01-04 14:43 ` Laurent Pinchart [this message]
2022-01-04 14:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdRdAI4S0+85CuDy@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=watson.chow@avnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).