From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: leds: maxim,max77693: convert to dtschema
Date: Tue, 4 Jan 2022 09:09:41 -0600 [thread overview]
Message-ID: <YdRjNUMht6HjVM7s@robh.at.kernel.org> (raw)
In-Reply-To: <bedc4126-7536-a7f9-b833-d06f383ec15d@canonical.com>
On Thu, Dec 30, 2021 at 11:53:37AM +0100, Krzysztof Kozlowski wrote:
> On 29/12/2021 18:34, Rob Herring wrote:
> > On Tue, 28 Dec 2021 17:39:27 +0100, Krzysztof Kozlowski wrote:
> >> Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format.
> >> The existing bindings were defined in ../bindings/mfd/max77693.txt.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >> ---
> >> .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++
> >> 1 file changed, 105 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml
> >>
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/common.example.dt.yaml: led-controller@0: 'reg' does not match any of the regexes: '^([a-z]+-)?led[01]?$', 'pinctrl-[0-9]+'
> > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/maxim,max77693.yaml
> >
> > doc reference errors (make refcheckdocs):
> > Documentation/devicetree/bindings/leds/maxim,max77693.yaml: Documentation/devicetree/bindings/mfd/maxim,max77693.yaml
> >
> > See https://patchwork.ozlabs.org/patch/1573762
> >
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> >
>
> I updated my yamllint and dtschema, run with DT_CHECKER_FLAGS=-m but
> still cannot reproduce it. Probably because I based on linux-next, so
> maybe this was a fixed issue in leds/common.yaml.
Are you setting DT_SCHEMA_FILES, because the error is in
common.yaml but caused by this schema.
Clearly, 'reg' is not defined here. And there is no change to
common.yaml in next.
Rob
next prev parent reply other threads:[~2022-01-04 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 16:39 [PATCH 0/4] leds/power/regulator/mfd: dt-bindings: maxim,max77693: convert to dtschema Krzysztof Kozlowski
2021-12-28 16:39 ` [PATCH 1/4] dt-bindings: leds: " Krzysztof Kozlowski
2021-12-29 17:34 ` Rob Herring
2021-12-30 10:53 ` Krzysztof Kozlowski
2022-01-04 15:09 ` Rob Herring [this message]
2022-01-11 15:03 ` Krzysztof Kozlowski
2021-12-28 16:39 ` [PATCH 2/4] dt-bindings: power: supply: " Krzysztof Kozlowski
2022-01-10 19:08 ` Rob Herring
2021-12-28 16:39 ` [PATCH 3/4] regulator: dt-bindings: " Krzysztof Kozlowski
2022-01-04 15:29 ` Rob Herring
2022-01-11 16:26 ` Krzysztof Kozlowski
2021-12-28 16:39 ` [PATCH 4/4] dt-bindings: mfd: " Krzysztof Kozlowski
2022-01-10 19:10 ` Rob Herring
2022-01-11 16:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdRjNUMht6HjVM7s@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).