From: Abel Vesa <abel.vesa@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Jesse Taube <mr.bossman075@gmail.com>,
linux-imx@nxp.com, mturquette@baylibre.com, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch,
linus.walleij@linaro.org, gregkh@linuxfoundation.org,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
linux@armlinux.org.uk, adrian.hunter@intel.com,
jirislaby@kernel.org, giulio.benetti@benettiengineering.com,
nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver
Date: Tue, 11 Jan 2022 00:48:10 +0200 [thread overview]
Message-ID: <Ydy3qvT5w6IWnR7s@abelvesa> (raw)
In-Reply-To: <20220110201201.C1E37C36AE9@smtp.kernel.org>
On 22-01-10 12:12:00, Stephen Boyd wrote:
> Quoting Jesse Taube (2022-01-09 11:07:42)
> > >> +
> > >> + clk_hw_data->num = IMXRT1050_CLK_END;
> > >> + hws = clk_hw_data->hws;
> > >> +
> > >> + hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc"));
> > >
> > > Use clk_parent_data instead and reference the binding name with .fw_name
> >
> > Hi Stephen, sorry to bother you again.
> > I'm wondering if adding `clk_parent_data` is necessary as it seems like
> > it wold be a big change and the other IMX boards haven't implemented
> > this yet would it be okay if I don't do this, or if it is necessary
> > could you link to a patch set to change it.
> >
>
> Is it a big change because the imx_clk_hw*() APIs aren't prepared for
> non-string parents? Can you make some clk_parent_data based APIs and
> migrate things over gradually? This is really a question for i.MX folks
> to see if anyone is working on moving away from the string names.
I'm currently looking into it. I would suggest we take this patch as is
and I'll switch it later on to clk_parent_data.
next prev parent reply other threads:[~2022-01-10 22:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 23:39 [PATCH v7 0/7] Add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Jesse Taube
2022-01-03 23:39 ` [PATCH v7 1/7] ARM: imx: Add initial support for i.MXRT10xx family Jesse Taube
2022-01-03 23:39 ` [PATCH v7 2/7] ARM: dts: imxrt1050-pinfunc: Add pinctrl binding header Jesse Taube
2022-01-04 19:06 ` Rob Herring
2022-01-03 23:39 ` [PATCH v7 3/7] dt-bindings: imx: Add clock binding for i.MXRT1050 Jesse Taube
2022-01-04 19:07 ` Rob Herring
2022-01-03 23:39 ` [PATCH v7 4/7] dt-bindings: clock: imx: Add documentation for i.MXRT1050 clock Jesse Taube
2022-01-04 19:07 ` Rob Herring
2022-01-03 23:39 ` [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver Jesse Taube
[not found] ` <20220105235157.8ED80C36AEB@smtp.kernel.org>
2022-01-06 21:22 ` Jesse Taube
2022-01-09 19:07 ` Jesse Taube
[not found] ` <20220110201201.C1E37C36AE9@smtp.kernel.org>
2022-01-10 22:48 ` Abel Vesa [this message]
2022-01-11 0:18 ` Jesse Taube
2022-01-11 20:52 ` Abel Vesa
2022-01-03 23:39 ` [PATCH v7 6/7] ARM: dts: imx: Add i.MXRT1050-EVK support Jesse Taube
2022-01-03 23:39 ` [PATCH v7 7/7] ARM: imxrt_defconfig: Add i.MXRT family defconfig Jesse Taube
2022-01-11 21:25 [PATCH v7 0/7] Add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Jesse Taube
2022-01-11 21:26 ` [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050 clock driver Jesse Taube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydy3qvT5w6IWnR7s@abelvesa \
--to=abel.vesa@nxp.com \
--cc=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mr.bossman075@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=stefan@agner.ch \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).