Re: [PATCH 0/7] dt-bindings: Convert multiple Qualcomm OPP and CPUFreq bindings to DT schema

From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Yassine Oudjana <y.oudjana@protonmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Ilia Lin <ilia.lin@kernel.org>,
	Niklas Cassel <nks@flawful.org>, Andy Gross <agross@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] dt-bindings: Convert multiple Qualcomm OPP and CPUFreq bindings to DT schema
Date: Mon, 31 Jan 2022 16:06:44 -0600	[thread overview]
Message-ID: <YfhddMNAL1mQGtKU@builder.lan> (raw)
In-Reply-To: <20220104132618.391799-1-y.oudjana@protonmail.com>

On Tue 04 Jan 07:27 CST 2022, Yassine Oudjana wrote:

> This series is a compilation of DT schema conversions of multiple Qualcomm
> OPP and CPUFreq bindings:
> - qcom-cpufreq-nvmem (operating-points-v2-kryo-cpu)
> - qcom-opp (operating-points-v2-qcom-level)
> - qcom,cpr
> 
> Converting each one to DT schema introduces new dt_binding_check and
> dtbs_check errors to the others, so it was better to combine them into
> a series. Some errors were also caused by a couple of device trees having
> OPP tables with names that do not follow opp-v2-base, so these got fixed
> in this series as well. Finally, the lack of MSM8996 compatibles in
> arm/qcom.yaml caused an error in the opp-v2-kryo-cpu example, so they were
> added to the schema as well as to the msm8996-mtp device tree, which only
> had qcom,msm8996-mtp as its compatible.
> 
> PATCH 4/7 is a new version of a patch[1] that was sent as part of
> a different series before, and PATCH 7/7 is a new version of a patch[2]
> that was first sent alone.
> 
> Changes since v1 (PATCH v2 4/7):
>  - Split the schema into an OPP schema and a CPUFreq schema. 
> 
> Changes since v1 (PATCH v2 7/7):
>  - Remove allOf from compatible.
> 

The mixed versioning in this series confuses b4 - and thereby me as
well.  Can you please resubmit this with all patches of the same version
(e.g. v3).

Thanks,
Bjorn

> Yassine Oudjana (7):
>   dt-bindings: arm: qcom: Add msm8996 and apq8096 compatibles
>   arm64: dts: qcom: msm8996-mtp: Add msm8996 compatible
>   dt-bindings: opp: qcom-opp: Convert to DT schema
>   dt-bindings: opp: Convert qcom-nvmem-cpufreq to DT schema
>   arm64: dts: qcom: msm8996: Rename cluster OPP tables
>   arm64: dts: qcom: qcs404: Rename CPU and CPR OPP tables
>   dt-bindings: power: avs: qcom,cpr: Convert to DT schema
> 
>  .../devicetree/bindings/arm/qcom.yaml         |  16 +-
>  .../bindings/cpufreq/qcom-cpufreq-nvmem.yaml  | 166 ++++
>  .../bindings/opp/opp-v2-kryo-cpu.yaml         | 257 ++++++
>  .../bindings/opp/opp-v2-qcom-level.yaml       |  60 ++
>  .../bindings/opp/qcom-nvmem-cpufreq.txt       | 796 ------------------
>  .../devicetree/bindings/opp/qcom-opp.txt      |  19 -
>  .../bindings/power/avs/qcom,cpr.txt           | 130 ---
>  .../bindings/power/avs/qcom,cpr.yaml          | 160 ++++
>  MAINTAINERS                                   |   5 +-
>  arch/arm64/boot/dts/qcom/msm8996-mtp.dts      |   2 +-
>  arch/arm64/boot/dts/qcom/msm8996.dtsi         |   4 +-
>  arch/arm64/boot/dts/qcom/qcs404.dtsi          |   4 +-
>  12 files changed, 666 insertions(+), 953 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
>  create mode 100644 Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml
>  create mode 100644 Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
>  delete mode 100644 Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
>  delete mode 100644 Documentation/devicetree/bindings/opp/qcom-opp.txt
>  delete mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.txt
>  create mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
> 
> [1] https://lore.kernel.org/linux-arm-msm/20211014083016.137441-6-y.oudjana@protonmail.com/
> [2]	https://lore.kernel.org/linux-arm-msm/20211221133937.173618-1-y.oudjana@protonmail.com/
> -- 
> 2.34.1
> 
> 