From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org, Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: gpio: davinci: list contents of GPIO hogs
Date: Thu, 31 Mar 2022 19:44:04 -0500 [thread overview]
Message-ID: <YkZK1OzF5Wq2bDma@robh.at.kernel.org> (raw)
In-Reply-To: <20220328191153.171241-1-krzysztof.kozlowski@linaro.org>
On Mon, Mar 28, 2022 at 09:11:53PM +0200, Krzysztof Kozlowski wrote:
> The hogs children should list allowed properties, otherwise any property
> would be accepted. Simplify also GPIO hog node name pattern.
Only if 'gpio-hog' is missing, because the gpio-hog.yaml schema will
check every node with that property.
Hogs are allowed on any GPIO controller, but I don't think we to
duplicate what's here on every schema.
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/gpio/gpio-davinci.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> index f32e09ef937c..e5b91c65dcb0 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> @@ -76,12 +76,21 @@ properties:
> const: 2
>
> patternProperties:
> - "^(.+-hog(-[0-9]+)?)$":
> + "^.+-hog(-[0-9]+)?$":
> type: object
> + properties:
> + gpio-hog: true
> + gpios: true
> + input: true
> + output-high: true
> + output-low: true
> + line-name: true
>
> required:
> - gpio-hog
>
> + additionalProperties: false
> +
> required:
> - compatible
> - reg
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2022-04-01 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 19:11 [PATCH] dt-bindings: gpio: davinci: list contents of GPIO hogs Krzysztof Kozlowski
2022-04-01 0:44 ` Rob Herring [this message]
2022-04-01 6:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkZK1OzF5Wq2bDma@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).