From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36A0C433EF for ; Mon, 6 Jun 2022 20:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229584AbiFFU5F (ORCPT ); Mon, 6 Jun 2022 16:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234306AbiFFU4s (ORCPT ); Mon, 6 Jun 2022 16:56:48 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E060106A65 for ; Mon, 6 Jun 2022 13:45:54 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id f65so3700875pgc.7 for ; Mon, 06 Jun 2022 13:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I1MYgC5T5e5Y+j3sUQDRFkx2mXQdu9/FeqjllZOguTI=; b=Nb68eKSk0EqDzcMgyGdZaXPHSOspFn2UrOnyBXqnGbXVO9SyCXhbm4OFKVpLBB21v8 L+rv1FTctVUSpwHRCj07ceZR/MV0Sv3QT/e3z3OPpnc4FtLUoEIRWUjrFSFqZqVr/KkU XIVxbDE2+37Dp4hVlnQ+42fmsnuyM8gOe1LDM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I1MYgC5T5e5Y+j3sUQDRFkx2mXQdu9/FeqjllZOguTI=; b=qMEgdk8iAMMQ48XZR6qoXmqxlUmyPc4Rv1DMeFtxgJ1qtgVX0uEFkFtgxmrRkm/WWk utGSLbHi3oJitY53IT/0Te7A96a06VM0VvkHp3RCgVUq/AZACjBH8SoqxKEtZ5ALtIr4 lesOkDzQDvyCMnf9W+ovYn1WL/A2+VHROGMNWNZ5YsnAC9Sljcf9NSqaHBON0serK0X9 qtyvVb4FOEKl6uEgFOq7d0ezr2z4vA2pPxlULwS3eQ6uUNxSWZvR52RmeAbWFZ1lFGcY w2rSqQDFHte5Pc16Au5HU0fm3IGamtVpNT59ZfVMfJVYbhUesWtZedD0Svs4GLGhCH1n moow== X-Gm-Message-State: AOAM532xs/nom7lj9USBxt8GVcGcfpj7reuRRaxun1sTf4AQ0vHc44lL QMKvzpnug7Rq3gIamtSriCgZrw== X-Google-Smtp-Source: ABdhPJwWjV+ZcZBiw7her510xIgFT3A3gR32FqSTa4dJg1oykKnZusf5iQQ2b9OYed3KiAyxFPGanA== X-Received: by 2002:a05:6a00:1485:b0:518:e601:dffb with SMTP id v5-20020a056a00148500b00518e601dffbmr26087994pfu.38.1654548353983; Mon, 06 Jun 2022 13:45:53 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:196:a14c:7344:f6db]) by smtp.gmail.com with UTF8SMTPSA id u2-20020a170902714200b001621cd83e49sm10954415plm.92.2022.06.06.13.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 13:45:53 -0700 (PDT) Date: Mon, 6 Jun 2022 13:45:51 -0700 From: Matthias Kaehlcke To: Krishna Kurapati Cc: Krzysztof Kozlowski , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Mathias Nyman , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, Sandeep Maheswaram Subject: Re: [PATCH v20 2/5] usb: dwc3: core: Host wake up support from system suspend Message-ID: References: <1654158277-12921-1-git-send-email-quic_kriskura@quicinc.com> <1654158277-12921-3-git-send-email-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 02, 2022 at 12:35:42PM -0700, Matthias Kaehlcke wrote: > Hi Krishna, > > with this version I see xHCI errors on my SC7180 based system, like > these: > > [ 65.352605] xhci-hcd xhci-hcd.13.auto: xHC error in resume, USBSTS 0x401, Reinit > > [ 101.307155] xhci-hcd xhci-hcd.13.auto: WARN: xHC CMD_RUN timeout > > After resume a downstream hub isn't enumerated again. > > So far I didn't see those with v13, but I aso saw the first error with > v16. It also happens with v13, but only when a wakeup capable vUSB <= 2 device is plugged in. Initially I used a wakeup capable USB3 to Ethernet adapter to trigger the wakeup case, however older versions of this series that use usb_wakeup_enabled_descendants() to check for wakeup capable devices didn't actually check for vUSB > 2 devices. So the case were the controller/PHYs is powered down works, but the controller is unhappy when the runtime PM path is used during system suspend. > On Thu, Jun 02, 2022 at 01:54:34PM +0530, Krishna Kurapati wrote: > > From: Sandeep Maheswaram > > > > Check wakeup-source property for dwc3 core node to set the > > wakeup capability. Drop the device_init_wakeup call from > > runtime suspend and resume. > > > > If the dwc3 is wakeup capable, don't power down the USB PHY(s). > > The glue drivers are expected to take care of configuring the > > additional wakeup settings if needed based on the dwc3 wakeup > > capability status. In some SOC designs, powering off the PHY is > > resulting in higher leakage, so this patch save power on such boards. > > > > Signed-off-by: Sandeep Maheswaram > > Signed-off-by: Krishna Kurapati > > Reviewed-by: Pavankumar Kondeti > > --- > > drivers/usb/dwc3/core.c | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index e027c04..b99d3c2 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -1787,6 +1787,7 @@ static int dwc3_probe(struct platform_device *pdev) > > > > platform_set_drvdata(pdev, dwc); > > dwc3_cache_hwparams(dwc); > > + device_init_wakeup(&pdev->dev, of_property_read_bool(dev->of_node, "wakeup-source")); > > > > spin_lock_init(&dwc->lock); > > mutex_init(&dwc->mutex); > > @@ -1948,7 +1949,7 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > > dwc3_core_exit(dwc); > > break; > > case DWC3_GCTL_PRTCAP_HOST: > > - if (!PMSG_IS_AUTO(msg)) { > > + if (!PMSG_IS_AUTO(msg) && !device_can_wakeup(dwc->dev)) { > > dwc3_core_exit(dwc); > > break; > > } > > @@ -2009,7 +2010,7 @@ static int dwc3_resume_common(struct dwc3 *dwc, pm_message_t msg) > > spin_unlock_irqrestore(&dwc->lock, flags); > > break; > > case DWC3_GCTL_PRTCAP_HOST: > > - if (!PMSG_IS_AUTO(msg)) { > > + if (!PMSG_IS_AUTO(msg) && !device_can_wakeup(dwc->dev)) { > > ret = dwc3_core_init_for_resume(dwc); > > if (ret) > > return ret; > > @@ -2086,8 +2087,6 @@ static int dwc3_runtime_suspend(struct device *dev) > > if (ret) > > return ret; > > > > - device_init_wakeup(dev, true); > > - > > return 0; > > } > > > > @@ -2096,8 +2095,6 @@ static int dwc3_runtime_resume(struct device *dev) > > struct dwc3 *dwc = dev_get_drvdata(dev); > > int ret; > > > > - device_init_wakeup(dev, false); > > - > > ret = dwc3_resume_common(dwc, PMSG_AUTO_RESUME); > > if (ret) > > return ret; > > -- > > 2.7.4 > >