From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dylan Van Assche <me@dylanvanassche.be>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom/sdm845-shift-axolotl: Enable pmi9889 LPG LED
Date: Thu, 30 Jun 2022 16:56:42 -0500 [thread overview]
Message-ID: <Yr4cGj7MujkXZ161@builder.lan> (raw)
In-Reply-To: <20220512054439.13971-1-me@dylanvanassche.be>
On Thu 12 May 00:44 CDT 2022, Dylan Van Assche wrote:
> Enables the RGB notification LED on the SHIFT 6mq (sdm845-shift-axolotl)
> with the Qualcomm Light Pulse Generator bindings by Bjorn Andersson [1].
> Patches are merged in for-next branch of linux-leds.
> Tested these changes on the SHIFT 6mq.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=a8e53db46f19f67be6a26488aafb7d10c78e33bd
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
> .../boot/dts/qcom/sdm845-shift-axolotl.dts | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 847f6217a77b..af412ac2c9d0 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -2,11 +2,13 @@
> /*
> * Copyright (c) 2022, Alexander Martinz <amartinz@shiftphones.com>
> * Copyright (c) 2022, Caleb Connolly <caleb@connolly.tech>
> + * Copyright (c) 2022, Dylan Van Assche <me@dylanvanassche.be>
> */
>
> /dts-v1/;
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sdm845.dtsi"
> #include "pm8998.dtsi"
> @@ -554,6 +556,33 @@ &pmi8998_smb2 {
> monitored-battery = <&battery>;
> };
>
> +&pmi8998_lpg {
We don't have this node, because no one has reviewed
https://lore.kernel.org/all/20220505022706.1692554-1-bjorn.andersson@linaro.org/#t
yet.
If anyone could take a look I'd be happy to merge this as well.
Thanks,
Bjorn
> + status = "okay";
> +
> + multi-led {
> + color = <LED_COLOR_ID_RGB>;
> + function = LED_FUNCTION_STATUS;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@3 {
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + };
> +
> + led@4 {
> + reg = <4>;
> + color = <LED_COLOR_ID_GREEN>;
> + };
> +
> + led@5 {
> + reg = <5>;
> + color = <LED_COLOR_ID_RED>;
> + };
> + };
> +};
> +
> &qup_uart9_default {
> pinconf-rx {
> pins = "gpio5";
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-06-30 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 5:44 [PATCH] arm64: dts: qcom/sdm845-shift-axolotl: Enable pmi9889 LPG LED Dylan Van Assche
2022-06-08 16:53 ` Caleb Connolly
2022-06-09 9:15 ` Alexander Martinz
2022-06-30 21:56 ` Bjorn Andersson [this message]
2022-07-01 6:09 ` Dylan Van Assche
2022-07-07 2:31 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr4cGj7MujkXZ161@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).