From: John Keeping <john@metanate.com>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: heiko@sntech.de, ardb@kernel.org, herbert@gondor.apana.org.au,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v7 00/33] crypto: rockchip: permit to pass self-tests
Date: Mon, 20 Jun 2022 12:08:43 +0100 [thread overview]
Message-ID: <YrBVO+2TWufDOrtH@donbot> (raw)
In-Reply-To: <YqceGFafq7QoT+8w@Red>
On Mon, Jun 13, 2022 at 01:23:04PM +0200, LABBE Corentin wrote:
> Le Sun, May 08, 2022 at 06:59:24PM +0000, Corentin Labbe a écrit :
> > The rockchip crypto driver is broken and do not pass self-tests.
> > This serie's goal is to permit to become usable and pass self-tests.
> >
> > This whole serie is tested on a rk3328-rock64, rk3288-miqi and
> > rk3399-khadas-edge-v with selftests (with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y)
> >
> > Regards
> >
>
> This is a gentle ping since this serie has now, no comment to address.
I've just replied to patch 14 with a comment, but other than that I
agree that patches 1-24 look good. It would be good to get these merged
soon as crypto acceleration on Rockchip hardware has been totally broken
for several releases now.
Patches 1-13 and 15-24 are:
Reviewed-by: John Keeping <john@metanate.com>
I'm less sure about patches 25-33 as I don't really know much about the
crypto API, but it seems strange that dispatching requests to two
(nearly) identical accelerators should need so much special handling in
the driver and that there isn't some higher level management for this.
next prev parent reply other threads:[~2022-06-20 11:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 18:59 [PATCH v7 00/33] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 01/33] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 02/33] crypto: rockchip: do not use uninitialized variable Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 03/33] crypto: rockchip: do not do custom power management Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 04/33] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 05/33] crypto: rockchip: do not store mode globally Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 06/33] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 07/33] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 08/33] crypto: rockchip: better handle cipher key Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 09/33] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 10/33] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 11/33] crypto: rockchip: rewrite type Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 12/33] crypto: rockchip: add debugfs Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 13/33] crypto: rockchip: introduce PM Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 14/33] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-06-20 11:04 ` John Keeping
2022-06-21 8:05 ` LABBE Corentin
2022-06-21 13:37 ` John Keeping
2022-06-30 14:51 ` LABBE Corentin
2022-05-08 18:59 ` [PATCH v7 15/33] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 16/33] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 17/33] crypto: rockchip: use read_poll_timeout Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 18/33] crypto: rockchip: fix style issue Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 19/33] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 20/33] crypto: rockchip: rename ablk functions to cipher Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 21/33] crypto: rockchip: rework rk_handle_req function Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 22/33] crypto: rockchip: use a rk_crypto_info variable instead of lot of indirection Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 23/33] crypto: rockchip: use the rk_crypto_info given as parameter Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings Corentin Labbe
2022-05-09 7:23 ` Krzysztof Kozlowski
2022-05-08 18:59 ` [PATCH v7 26/33] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 27/33] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 28/33] arm64: dts: rockchip: rk3399: add " Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 29/33] crypto: rockchip: store crypto_info in request context Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 30/33] crypto: rockchip: Check for clocks numbers and their frequencies Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 31/33] crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 32/33] crypto: rockchip: permit to have more than one reset Corentin Labbe
2022-05-08 18:59 ` [PATCH v7 33/33] crypto: rockchip: Add support for RK3399 Corentin Labbe
2022-06-13 11:23 ` [PATCH v7 00/33] crypto: rockchip: permit to pass self-tests LABBE Corentin
2022-06-20 11:08 ` John Keeping [this message]
2022-07-02 13:10 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrBVO+2TWufDOrtH@donbot \
--to=john@metanate.com \
--cc=ardb@kernel.org \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).