From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E51B0C433EF for ; Tue, 21 Jun 2022 08:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346477AbiFUIGC (ORCPT ); Tue, 21 Jun 2022 04:06:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbiFUIGB (ORCPT ); Tue, 21 Jun 2022 04:06:01 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C29581115A for ; Tue, 21 Jun 2022 01:05:59 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id p6-20020a05600c1d8600b0039c630b8d96so7324202wms.1 for ; Tue, 21 Jun 2022 01:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=GsCQyeSS9WqgWVTSCSRei8+jKy0pNjIeX7QnW7mozH8=; b=jibc9DU08V3+hmlKpMeuFBDRViUNOmAqhLv6bBMBvot6Y1y5fIwWhHP50ijPfYjSkP dofNHKktUMXyQWgFL3kXgkNcCMI2EyGV7jpxsE895xWHEcXseYPy3ALYyk3QO/N0mUp0 vdtIIlaM3jdF4mNnqhGbeiMjdwIE1RoqzlR0jkpN01OXtm8YiT2z6tDuzLLchasFD2w2 Mkh6LtyCFJWejhKMxgykZsEQj/x8fiEINVD1qJbJOxZgN2YH/UWuZMuMZW32iBeGtvQq /lW7BLRvhMJx91EGYj8g/3IgB34BAKrk4wE5Qh21ccOj72gocm1+GPBZgzZ2TTnx2Dna r2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GsCQyeSS9WqgWVTSCSRei8+jKy0pNjIeX7QnW7mozH8=; b=D/AojtyUE6WAHfl4Kr0yfypzNeHyvpAf90tN0ACYg5BNVhz25Nnqjkh4nsBiu4DZ3C fORDAo5SqIGeB3WiaPEpLc3aUivwffIyfkgqKmTbA6xSSP374Mmv718BeYQ4POdgQrhu nCR8u/K3V7UixTjOG3kaCWtg8haTOSF9s4MGUq9jqQfhge91AedYioBHdSl7t2S4l2GQ T2VQag48LymqRvXnBpcFWtjtp60LY4MLCQk+Wmzm2Eay9TPIs7hqFtBIULGca4hronE9 aguYLVny2hIdRUoQA93x84h4o7ZLYTNhE4o+yw2qmm4sRM5zDhONdFjagD4mkGZzco8m c2sw== X-Gm-Message-State: AJIora8Ll3TCGmpXEcisj8qnJkSIZSV8dBK1WkXqXi6mQUbxaQOtDk5O YNHqhUIo4j7D37ZHUgAEE4OLSA== X-Google-Smtp-Source: AGRyM1uyuBI4yQO8I87mv5kU872kiOSXmbKPq5Tg/yiYqqbU8VShLy0QcRaY062PjM90XL8FvpDVSQ== X-Received: by 2002:a05:600c:1c10:b0:39c:4708:648d with SMTP id j16-20020a05600c1c1000b0039c4708648dmr28938957wms.85.1655798758346; Tue, 21 Jun 2022 01:05:58 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id t5-20020a05600001c500b0020d106c0386sm7043231wrx.89.2022.06.21.01.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 01:05:57 -0700 (PDT) Date: Tue, 21 Jun 2022 10:05:54 +0200 From: LABBE Corentin To: John Keeping Cc: heiko@sntech.de, ardb@kernel.org, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v7 14/33] crypto: rockchip: handle reset also in PM Message-ID: References: <20220508185957.3629088-1-clabbe@baylibre.com> <20220508185957.3629088-15-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le Mon, Jun 20, 2022 at 12:04:24PM +0100, John Keeping a écrit : > On Sun, May 08, 2022 at 06:59:38PM +0000, Corentin Labbe wrote: > > reset could be handled by PM functions. > > Is there any further rationale for this? > > After this change there is no longer a guaranteed reset pulse on probe > since the reset control may already be de-asserted. This is normally > the most important case for a reset as it's the only time when the state > of the hardware is unknown. > > The original use of devm_add_action_or_reset() seems a bit weird already > since there doesn't seem to be any need to assert reset when the driver > is unloaded. > I am not an hw engineer, so my knowledge on reset is low. So why not having a reset pulse on probe is a problem ? Do you mean I must put reset asserted on probe ?