From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: andersson@kernel.org, Thinh.Nguyen@synopsys.com,
gregkh@linuxfoundation.org, mathias.nyman@intel.com,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 5/5] usb: dwc3: qcom: Allow runtime PM
Date: Tue, 28 Mar 2023 15:35:29 +0200 [thread overview]
Message-ID: <ZCLtITAsPiCnmndQ@hovoldconsulting.com> (raw)
In-Reply-To: <20230328125705.GG5695@thinkpad>
On Tue, Mar 28, 2023 at 06:27:05PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Mar 28, 2023 at 02:18:16PM +0200, Johan Hovold wrote:
> > > > > @@ -948,6 +948,8 @@ static int dwc3_qcom_remove(struct platform_device *pdev)
> > > > > struct device *dev = &pdev->dev;
> > > > > int i;
> > > > >
> > > > > + pm_runtime_get_sync(dev);
> > > >
> > > > This call needs to be balanced. But this is a fix for a bug in the
> > > > current implementation that should go in a separate patch.
> > >
> > > Ok. For balancing I could add pm_runtime_put_noidle() before pm_runtime_disable.
> >
> > You should do it after disabling runtime pm.
>
> May I know why?
The usage counter should be balanced after disabling runtime PM so that
there is no window where you could get a racing suspend request.
> > > > > +
> > > > > device_remove_software_node(&qcom->dwc3->dev);
> > > > > of_platform_depopulate(dev);
> > > > >
> > > > > @@ -960,7 +962,6 @@ static int dwc3_qcom_remove(struct platform_device *pdev)
> > > > > dwc3_qcom_interconnect_exit(qcom);
> > > > > reset_control_assert(qcom->resets);
> > > > >
> > > > > - pm_runtime_allow(dev);
> > > > > pm_runtime_disable(dev);
> > > > >
> > > > > return 0;
Johan
next prev parent reply other threads:[~2023-03-28 13:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 16:52 [PATCH 0/5] usb: dwc3: qcom: Allow runtime PM Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 1/5] arm64: dts: qcom: sc8280xp: Add missing dwc3 quirks Manivannan Sadhasivam
2023-03-28 8:54 ` Johan Hovold
2023-03-28 9:38 ` Manivannan Sadhasivam
2023-03-29 5:26 ` Manivannan Sadhasivam
2023-03-29 8:34 ` Johan Hovold
2023-03-29 11:24 ` Konrad Dybcio
2023-03-29 12:15 ` Johan Hovold
2023-03-29 13:23 ` Manivannan Sadhasivam
2023-04-04 11:25 ` Johan Hovold
2023-03-25 16:52 ` [PATCH 2/5] xhci: host: Use 200ms autosuspend delay for runtime suspend Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 3/5] usb: dwc3: qcom: Fix null ptr access during runtime_suspend() Manivannan Sadhasivam
2023-03-28 9:23 ` Johan Hovold
2023-03-28 9:47 ` Manivannan Sadhasivam
2023-03-28 9:51 ` Johan Hovold
2023-03-28 10:08 ` Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 4/5] usb: dwc3: qcom: Clear pending interrupt before enabling wake interrupt Manivannan Sadhasivam
2023-03-28 9:28 ` Johan Hovold
2023-03-28 9:50 ` Manivannan Sadhasivam
2023-03-25 16:52 ` [PATCH 5/5] usb: dwc3: qcom: Allow runtime PM Manivannan Sadhasivam
2023-03-28 9:46 ` Johan Hovold
2023-03-28 10:05 ` Manivannan Sadhasivam
2023-03-28 12:18 ` Johan Hovold
2023-03-28 12:57 ` Manivannan Sadhasivam
2023-03-28 13:35 ` Johan Hovold [this message]
2023-03-27 9:01 ` [PATCH 0/5] " Konrad Dybcio
2023-03-27 9:17 ` Manivannan Sadhasivam
2023-03-27 9:24 ` Konrad Dybcio
2023-03-27 10:10 ` Manivannan Sadhasivam
2023-03-27 10:33 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCLtITAsPiCnmndQ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).