From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4AAC43603 for ; Thu, 19 Dec 2019 21:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30A4821D7D for ; Thu, 19 Dec 2019 21:12:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="e+qOP6Lo"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vsijnZkH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbfLSVMZ (ORCPT ); Thu, 19 Dec 2019 16:12:25 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36977 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726967AbfLSVMZ (ORCPT ); Thu, 19 Dec 2019 16:12:25 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3923122614; Thu, 19 Dec 2019 16:12:24 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Thu, 19 Dec 2019 16:12:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=eznQB8qUZinkMYctriI1OeMIbCpVh3R vgB+uxFjKcWw=; b=e+qOP6LoW0qwuw9Uy2AdChYbjp/8fd4FmeD+84lql6Nzysg Q5EEtzLFgHTT4ZLHh61HJ3qfKWvstLoYMaQrkZDYYqDwd+/zKtbxRnfqHZvssd91 sa37bQFA3ZnScxeTGmW9ZjFJJ6S6BUXGfzGwne2LNEp2+t39dMIey0l/kcEqJ/jf KuoHCdqSRnnlSJE6K2MO0oGjIlnYwDst1a6oCn20bsFT7pkrRDNexhBRPrYEp4pF AeUu0E7nVJPmFPYwutsxS2gCIpHJQ1LEeEeNPgqn9lu21kUEwM2L/Dtg8atJzYcx rXLZ8tlvkMR91AXdifiCjEFsx63JqF1zjoUPimg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eznQB8 qUZinkMYctriI1OeMIbCpVh3RvgB+uxFjKcWw=; b=vsijnZkHJ3FMzCkUiKcL/U 9L2QM7/PfasuZQQGhBbkj6zuYKUg9J4j6/FtNjCRMvQgwzsHNR+mgyg4WOr/3+6D jroxkgIdapQ337qTg8dFfeorONhrceuRpKegqiNJ/CGVUasNQJJgxjhrTTf1Ouas 0yf4CYMM66dvboAwxoJbnEVpsfoH/8vTuyZQfw9K+Ooa1cW02iYSsar+rNxoYkvH uyLPbv2DjLJ6PvMf234WqpBZ7KQjTnwHnFyDRugNHU/6Hzt0CFHp8fvxABEf+jRt 2wwRdtzJQHdlw5nrI7fojEYgc43hr6xs6XrySKUtfa6OVS0ih8duOsQrRFJqVjrQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdduuddgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfrrg hrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A5516E00A3; Thu, 19 Dec 2019 16:12:22 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-694-gd5bab98-fmstable-20191218v1 Mime-Version: 1.0 Message-Id: In-Reply-To: <45cabf88-063d-aea1-6c2b-fa8cc0d8cbd3@linux.ibm.com> References: <1576681778-18737-1-git-send-email-eajames@linux.ibm.com> <1576681778-18737-6-git-send-email-eajames@linux.ibm.com> <73cbffea-89f1-4212-99af-10c32968cf15@www.fastmail.com> <45cabf88-063d-aea1-6c2b-fa8cc0d8cbd3@linux.ibm.com> Date: Fri, 20 Dec 2019 07:44:05 +1030 From: "Andrew Jeffery" To: "Eddie James" , linux-aspeed@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, "Jason Cooper" , "Marc Zyngier" , "Rob Herring" , tglx@linutronix.de, "Joel Stanley" Subject: Re: [PATCH v3 05/12] dt-bindings: soc: Add Aspeed XDMA Engine Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 20 Dec 2019, at 02:18, Eddie James wrote: > > On 12/18/19 5:12 PM, Andrew Jeffery wrote: > > > > On Thu, 19 Dec 2019, at 01:39, Eddie James wrote: > >> Document the bindings for the Aspeed AST25XX and AST26XX XDMA engine. > >> > >> Signed-off-by: Eddie James > >> Reviewed-by: Rob Herring > >> --- > >> Changes since v2: > >> - Remove 'sdmc', rename 'vga-mem' to 'memory' > >> > >> .../devicetree/bindings/soc/aspeed/xdma.txt | 40 +++++++++++++++++++ > >> MAINTAINERS | 6 +++ > >> 2 files changed, 46 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/xdma.txt > >> > >> diff --git a/Documentation/devicetree/bindings/soc/aspeed/xdma.txt > >> b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt > >> new file mode 100644 > >> index 000000000000..58253ea1587b > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt > >> @@ -0,0 +1,40 @@ > >> +Aspeed AST25XX and AST26XX XDMA Engine > >> + > >> +The XDMA Engine embedded in the AST2500 and AST2600 SOCs can perform > >> automatic > >> +DMA operations over PCI between the SOC (acting as a BMC) and a host > >> processor. > >> + > >> +Required properties: > >> + - compatible : must be "aspeed,ast2500-xdma" or > >> + "aspeed,ast2600-xdma" > >> + - reg : contains the address and size of the memory region > >> + associated with the XDMA engine registers > >> + - clocks : clock specifier for the clock associated with the > >> + XDMA engine > >> + - resets : reset specifier for the syscon reset associated with > >> + the XDMA engine > >> + - interrupts-extended : two interrupt cells; the first specifies the > >> global > >> + interrupt for the XDMA engine and the second > >> + specifies the PCI-E reset or PERST interrupt. > >> + - scu : a phandle to the syscon node for the system control > >> + unit of the SOC > > I think this should be aspeed,scu. > > > Sure. > > > > > >> + - memory : contains the address and size of the memory area to > >> + be used by the XDMA engine for DMA operations > > Hmm, I was thinking more like a phandle to a reserved memory region, > > like we have in the aspeed-lpc-ctrl binding. > > > I think I mentioned before, but that doesn't work with the VGA memory. > Linux can't reserve it. I haven't quite understood what happens in the > memory system but I've tried it and it didn't work. > Yeah, I think you have mentioned that before, sorry for the noise. Andrew