From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>,
agross@kernel.org
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CHROMIUM: arm64: dts: qcom: Add sc7180-gelarshie
Date: Wed, 30 Mar 2022 19:25:45 +0200 [thread overview]
Message-ID: <a0eb6bf9-256a-29b1-2211-496df710f531@linaro.org> (raw)
In-Reply-To: <20220330090947.9100-1-chenxiangrui@huaqin.corp-partner.google.com>
On 30/03/2022 11:09, Mars Chen wrote:
> Initial attempt at Gelarshie device tree.
>
> BUG=b:225756600
> TEST=emerge-strongbad chromeos-kernel-5_4
>
> Signed-off-by: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../dts/qcom/sc7180-trogdor-gelarshie-r0.dts | 15 +
> .../dts/qcom/sc7180-trogdor-gelarshie.dtsi | 304 ++++++++++++++++++
> 3 files changed, 320 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index f9e6343acd03..cf8f88b065c3 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -57,6 +57,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-gelarshie-r0.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
> new file mode 100644
> index 000000000000..027d6d563a5f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Gelarshie board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/dts-v1/;
> +
> +#include "sc7180-trogdor-gelarshie.dtsi"
> +
> +/ {
> + model = "Google Gelarshie (rev0+)";
> + compatible = "google,gelarshie", "qcom,sc7180";
Missing bindings. Please document the compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-30 17:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 9:09 [PATCH] CHROMIUM: arm64: dts: qcom: Add sc7180-gelarshie Mars Chen
2022-03-30 14:21 ` kernel test robot
2022-03-30 17:16 ` Matthias Kaehlcke
2022-03-30 17:23 ` Krzysztof Kozlowski
2022-03-30 22:57 ` Rob Clark
2022-03-30 17:25 ` Krzysztof Kozlowski [this message]
2022-04-13 21:48 ` Doug Anderson
2022-04-14 7:10 ` Krzysztof Kozlowski
2022-04-14 17:36 ` Doug Anderson
2022-04-19 15:47 ` Krzysztof Kozlowski
2022-04-19 16:55 ` Doug Anderson
2022-05-03 15:53 ` Krzysztof Kozłowski
2022-05-03 16:13 ` Doug Anderson
2022-05-04 7:04 ` Krzysztof Kozlowski
2022-05-04 23:56 ` Julius Werner
2022-05-06 21:33 ` Doug Anderson
2022-05-07 17:04 ` Krzysztof Kozlowski
2022-05-07 17:11 ` Krzysztof Kozlowski
2022-05-11 2:39 ` Julius Werner
2022-05-11 7:20 ` Krzysztof Kozlowski
2022-05-11 16:09 ` Doug Anderson
2022-05-11 16:57 ` Bjorn Andersson
2022-05-11 17:36 ` Krzysztof Kozlowski
2022-05-11 17:49 ` Doug Anderson
2022-05-12 16:08 ` Doug Anderson
2022-03-30 19:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0eb6bf9-256a-29b1-2211-496df710f531@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chenxiangrui@huaqin.corp-partner.google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).