From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergiu Moga <sergiu.moga@microchip.com>,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com
Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kavyasree.Kotagiri@microchip.com,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH] dt-bindings: spi: convert spi_atmel to json-schema
Date: Wed, 29 Jun 2022 15:23:52 +0200 [thread overview]
Message-ID: <a2422718-2ec4-dbad-0245-1d78dbb39f25@linaro.org> (raw)
In-Reply-To: <20220629125804.137099-1-sergiu.moga@microchip.com>
On 29/06/2022 14:58, Sergiu Moga wrote:
> Convert SPI binding for Atmel/Microchip SoCs to Device Tree Schema
> format.
>
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> ---
> .../devicetree/bindings/spi/atmel,spi.yaml | 82 +++++++++++++++++++
> .../devicetree/bindings/spi/spi_atmel.txt | 36 --------
> 2 files changed, 82 insertions(+), 36 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/atmel,spi.yaml
> delete mode 100644 Documentation/devicetree/bindings/spi/spi_atmel.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/atmel,spi.yaml b/Documentation/devicetree/bindings/spi/atmel,spi.yaml
> new file mode 100644
> index 000000000000..751618a47235
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/atmel,spi.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/atmel,spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel SPI device
> +
> +maintainers:
> + - Mark Brown <broonie@kernel.org>
This should be rather someone from Microchip.
> +
> +allOf:
> + - $ref: "spi-controller.yaml#"
No need for quotes.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: atmel,at91rm9200-spi
> + - items:
These are not items, just single entry. Should be combined with above
and made an 'enum'.
> + - const: microchip,sam9x60-spi
> + - items:
> + - const: microchip,sam9x60-spi
> + - const: atmel,at91rm9200-spi
This is wrong. Either this is a fallback or it is not. It's not the
Schroedinger's cat... Maybe your DTS are wrong.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + cs-gpios: true
No need, coming from spi-controller.yaml.
> +
> + clock-names:
> + description:
> + Tuple listing input clock names, "spi_clk" is a required element.
Skip description.
> + contains:
> + const: spi_clk
> + additionalItems: true
no additionalItems.
> +
> + clocks:
> + maxItems: 1
> +
> + atmel,fifo-size:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Maximum number of data the RX and TX FIFOs can store for FIFO
> + capable SPI controllers.
minimum and maximum for values, if it is known.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clock-names
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + spi1: spi@fffcc000 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0xfffcc000 0x4000>;
> + interrupts = <13 IRQ_TYPE_LEVEL_HIGH 5>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&spi1_clk>;
> + clock-names = "spi_clk", "str2";
This does not make really sense. You have one clock.
> + cs-gpios = <&pioB 3 GPIO_ACTIVE_HIGH>;
> + atmel,fifo-size = <32>;
> +
> + mmc@0 {
> + compatible = "mmc-spi-slot";
> + reg = <0>;
> + gpios = <&pioC 4 GPIO_ACTIVE_HIGH>; /* CD */
> + spi-max-frequency = <25000000>;
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-29 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 12:58 [PATCH] dt-bindings: spi: convert spi_atmel to json-schema Sergiu Moga
2022-06-29 13:23 ` Krzysztof Kozlowski [this message]
2022-06-29 15:01 ` Nicolas Ferre
2022-06-30 6:07 ` Sergiu.Moga
2022-06-30 5:59 ` Sergiu.Moga
2022-06-29 14:12 ` Mark Brown
2022-06-29 22:36 ` Rob Herring
2022-06-29 22:45 ` Conor.Dooley
2022-06-30 21:12 ` Rob Herring
2022-06-30 22:22 ` Conor.Dooley
2022-07-01 7:41 ` Nicolas Ferre
2022-07-01 7:50 ` Conor.Dooley
2022-07-01 7:56 ` Nicolas Ferre
2022-06-30 6:05 ` Sergiu.Moga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2422718-2ec4-dbad-0245-1d78dbb39f25@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sergiu.moga@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).