From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215F9C433DF for ; Fri, 16 Oct 2020 05:14:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2DAE20897 for ; Fri, 16 Oct 2020 05:14:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="rkMkit/d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730586AbgJPFOc (ORCPT ); Fri, 16 Oct 2020 01:14:32 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:10312 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726334AbgJPFOc (ORCPT ); Fri, 16 Oct 2020 01:14:32 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 15 Oct 2020 22:14:19 -0700 Received: from [10.25.98.225] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Oct 2020 05:14:19 +0000 Subject: Re: [PATCH v3 09/13] ASoC: dt-bindings: tegra: Add schema for audio graph card From: Sameer Pujar To: Rob Herring CC: , , , , , , , , , , , , , , , , , , , , References: <1601573587-15288-1-git-send-email-spujar@nvidia.com> <1601573587-15288-10-git-send-email-spujar@nvidia.com> <20201006203433.GA2786434@bogus> Message-ID: Date: Fri, 16 Oct 2020 10:44:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602825259; bh=58G5hh5VTCRWNjS2NbwxGT+Sa6kUqX0udY4utQfHKx4=; h=Subject:From:To:CC:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=rkMkit/dwJWZjwBML9DdGRm+RNMv9B5Kz7OUNznxWxt1JLSqpH5lHP4OWCQNRdJf5 AvU6R5Buf8OP2UclEUIXoAAcYfYNqtLZCpZxiqF4Vr/t5ZyBOAvFO259diZQnwxnJ5 PJmLj17dQgUYtijjaRy7Do2j9Vh9oOKDAwkbsfnwQXY5XW5giTTuJZEAV4eRyc43/w 0jw6nBHxUXE6faiST7IY30d425/tOOWm01PXWSimZhXK8ylwk0U93tJCaanvdekoBw EpmB7r5c/s+z2Wtg7z5FB+uZ+rhTx9Y7nKpHbzotX2CXRHWigkuDKq9OxDo6w9Dp0e lqPyJ9p8O8KmQ== Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org >>> Add YAML schema for Tegra audio graph sound card DT bindings. It=20 >>> uses the >>> same DT bindings provided by generic audio graph driver. Along with=20 >>> this >>> few standard clock DT bindings are added which are specifically=20 >>> required >>> for Tegra audio. >>> >>> Signed-off-by: Sameer Pujar >>> --- >>> =C2=A0 .../sound/nvidia,tegra-audio-graph-card.yaml | 70=20 >>> ++++++++++++++++++++++ >>> =C2=A0 1 file changed, 70 insertions(+) >>> =C2=A0 create mode 100644=20 >>> Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.y= aml >>> >>> diff --git=20 >>> a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card= .yaml=20 >>> b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card= .yaml=20 >>> >>> new file mode 100644 >>> index 0000000..b73fbe5 >>> --- /dev/null >>> +++=20 >>> b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card= .yaml >>> @@ -0,0 +1,70 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id:=20 >>> http://devicetree.org/schemas/sound/nvidia,tegra-audio-graph-card.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Audio Graph based Tegra sound card driver >>> + >>> +description: | >>> +=C2=A0 This is based on generic audio graph card driver along with=20 >>> additional >>> +=C2=A0 customizations for Tegra platforms. It uses the same bindings w= ith >>> +=C2=A0 additional standard clock DT bindings required for Tegra. >>> + >>> +=20 >>> See{LINUX}/Documentation/devicetree/bindings/sound/audio-graph-card.txt >>> + >>> +maintainers: >>> +=C2=A0 - Jon Hunter >>> +=C2=A0 - Sameer Pujar >>> + >>> +properties: >>> +=C2=A0 compatible: >>> +=C2=A0=C2=A0=C2=A0 oneOf: >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: nvidia,tegra210-audio-graph-ca= rd >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: nvidia,tegra186-audio-graph-ca= rd >>> + >>> +=C2=A0 clocks: >>> +=C2=A0=C2=A0 minItems: 2 >>> + >>> +=C2=A0 clock-names: >>> +=C2=A0=C2=A0 minItems: 2 >>> +=C2=A0=C2=A0 items: >>> +=C2=A0=C2=A0=C2=A0=C2=A0 - const: pll_a >>> +=C2=A0=C2=A0=C2=A0=C2=A0 - const: plla_out0 >>> + >>> +=C2=A0 assigned-clocks: >>> +=C2=A0=C2=A0=C2=A0 minItems: 1 >>> +=C2=A0=C2=A0=C2=A0 maxItems: 3 >>> + >>> +=C2=A0 assigned-clock-parents: >>> +=C2=A0=C2=A0=C2=A0 minItems: 1 >>> +=C2=A0=C2=A0=C2=A0 maxItems: 3 >>> + >>> +=C2=A0 assigned-clock-rates: >>> +=C2=A0=C2=A0=C2=A0 minItems: 1 >>> +=C2=A0=C2=A0=C2=A0 maxItems: 3 >>> + >>> +required: >>> +=C2=A0 - compatible >>> +=C2=A0 - clocks >>> +=C2=A0 - clock-names >>> +=C2=A0 - assigned-clocks >>> +=C2=A0 - assigned-clock-parents >> Where's the graph? You need to define the ports and reference the common >> schema. > > I am looking to reference the bindings used in below doc which is not=20 > yet in YAML format. Only additional properties I listed here. > {LINUX}/Documentation/devicetree/bindings/sound/audio-graph-card.txt > > Should I keep this doc to *.txt format as well and later move to YAML=20 > or is there a way to reference *.txt doc here? The dependency here is like below, Tegra audio graph card -> generic audio graph card=20 (audio-graph-card.txt) -> graph (graph.txt) I plan to convert dependencies to json-schema in next revision and then=20 refer these for Tegra audio graph card.