From: Jon Hunter <jonathanh@nvidia.com>
To: Akhil R <akhilrajeev@nvidia.com>, Rob Herring <robh@kernel.org>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Krishna Yarlagadda <kyarlagadda@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Rajesh Gumasta <rgumasta@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"vkoul@kernel.org" <vkoul@kernel.org>
Subject: Re: [PATCH v13 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma
Date: Wed, 1 Dec 2021 14:33:31 +0000 [thread overview]
Message-ID: <ad8e88ba-f105-adb5-007e-2458440b9717@nvidia.com> (raw)
In-Reply-To: <c9379e5f-232f-7d9e-68c4-1aa5cc15b74a@nvidia.com>
On 30/11/2021 09:34, Jon Hunter wrote:
...
>>>> +title: NVIDIA Tegra GPC DMA Controller Device Tree Bindings
>>>> +
>>>> +description: |
>>>> + The Tegra General Purpose Central (GPC) DMA controller is used for
>>>> +faster
>>>> + data transfers between memory to memory, memory to device and
>>>> +device to
>>>> + memory.
>>>> +
>>>> +maintainers:
>>>> + - Jon Hunter <jonathanh@nvidia.com>
>>>> + - Rajesh Gumasta <rgumasta@nvidia.com>
>>>> +
>>>> +allOf:
>>>> + - $ref: "dma-controller.yaml#"
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + oneOf:
>>>> + - const: nvidia,tegra186-gpcdma
>>>> + - items:
>>>> + - const: nvidia,tegra186-gpcdma
>>>> + - const: nvidia,tegra194-gpcdma
>>>
>>> Still not how 'compatible' works nor what I wrote out for you.
>> I thought '186' and '194' got interchanged in your previous comment
>> because it is 194
>> which is the superset of 186 and have got more features than 186.
>> Or probably I did not understand the idea correctly yet.
>
> Hi Rob, this is the way around that we want it. Tegra194 is backward
> compatible with Tegra186. The above does align with what you mentioned
> before, so I am also not clear what the issue is with the above?
Now I think I understand. It is the order of the 'items' here that is
key. So what we want is ...
compatible:
oneOf:
- const: nvidia,tegra186-gpcdma
- items:
- const: nvidia,tegra194-gpcdma
- const: nvidia,tegra186-gpcdma
At least this makes the dt_binding_check happy :-)
Jon
--
nvpublic
next prev parent reply other threads:[~2021-12-01 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 9:28 [PATCH v13 0/4] Add NVIDIA Tegra GPC-DMA driver Akhil R
2021-11-22 9:28 ` [PATCH v13 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2021-11-23 16:34 ` Rob Herring
2021-11-28 16:06 ` Rob Herring
2021-11-29 5:01 ` Akhil R
2021-11-30 9:34 ` Jon Hunter
2021-12-01 14:33 ` Jon Hunter [this message]
2021-11-22 9:28 ` [PATCH v13 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2021-11-23 23:00 ` kernel test robot
2021-11-25 13:42 ` kernel test robot
2021-11-27 8:41 ` kernel test robot
2021-11-22 9:28 ` [PATCH v13 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2021-11-22 9:28 ` [PATCH v13 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
2021-11-30 9:46 ` Jon Hunter
2021-12-01 13:16 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad8e88ba-f105-adb5-007e-2458440b9717@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rgumasta@nvidia.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).