From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Subject: Re: [PATCH 06/14] ARM: dts: sun8i: Add cpu0 label to sun8i-h3.dtsi Date: Sat, 25 Jun 2016 00:51:56 +0200 Message-ID: References: <20160623192104.18720-1-megous@megous.com> <20160623192104.18720-7-megous@megous.com> Reply-To: megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ed9KVGgkMQsBIIRWiJKKOe4WPQtRggLgK" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: dev , linux-arm-kernel , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ed9KVGgkMQsBIIRWiJKKOe4WPQtRggLgK Content-Type: multipart/mixed; boundary="LRFX8xEArsnxflkUErXEqtrLVX5mLiDUk" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Chen-Yu Tsai Cc: dev , linux-arm-kernel , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Message-ID: Subject: Re: [PATCH 06/14] ARM: dts: sun8i: Add cpu0 label to sun8i-h3.dtsi References: <20160623192104.18720-1-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> <20160623192104.18720-7-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> In-Reply-To: --LRFX8xEArsnxflkUErXEqtrLVX5mLiDUk Content-Type: text/plain; charset=UTF-8 Hello, comments below. On 24.6.2016 05:48, Chen-Yu Tsai wrote: > On Fri, Jun 24, 2016 at 3:20 AM, wrote: >> From: Ondrej Jirman >> >> Add label to the first cpu so that it can be referenced >> from derived dts files. >> >> Signed-off-by: Ondrej Jirman >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> index 9938972..82faefc 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -52,7 +52,7 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> >> - cpu@0 { >> + cpu0: cpu@0 { >> compatible = "arm,cortex-a7"; >> device_type = "cpu"; >> reg = <0>; > > Can you also set the cpu clock here? It is part of the SoC > and does not belong in the board DTS files. Do you mean operating-points, or something else? Different SBCs will probably require different combinations of operating points just for safety's sake, because they have different regulators and [some have botched] thermal designs, so it might make sense to customize it for differnt boards, and I don't feel adventurous enough setting it for all H3 boards out there. Or is this comment related to the missing cpu clock rate message I see on every boot? [ 0.058912] /cpus/cpu@0 missing clock-frequency property regards, Ondrej > Otherwise this one looks good. > > ChenYu > >> -- >> 2.9.0 >> -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --LRFX8xEArsnxflkUErXEqtrLVX5mLiDUk-- --ed9KVGgkMQsBIIRWiJKKOe4WPQtRggLgK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXbbmMAAoJEG5kJsZ3z+/xuO0P/j0n3nkJiey0tKAPAoHCIyW9 6DLytqoj+QK6hZ+K/UujfUH0pKVyBZZ41wgjh/p3SQ3YipoTQZJi9duCabawjnJr qNJoZXwpUsLN+T6PRah/0CpGw8IvsGqFaeYIKcpr3xNOnm41P+8yw680GUn7KvZk 61/Ju/uqo5mpSdgN4KxoMtB1U/tCQ05+qD6FkfBvHecdWPWOMch+7+W8FrvZVMq3 7YYmUQ87YnknPJBTzew4SGNCh2uWq0CO4fpqgjCjPpuOzV1BN98XdvEJZKLLWKo+ 5olQxCS8VsM5v2H5oFLfGtDmEMZq1/vDLR6uymj29SdgBT/FhPOk4xLaLvIAOt8d yq1iJd4b5438QXY0IxWz0I+dywy49s1/1MPEyx0dGYC/APRJOEtQOrj3EV/aMsJw 9gHa907eZobpQU+5JElZ5rE35aM/VPBf8UVll1GDXmTKxLUicfvE56HrbvwhCwYs ErqBrRDrlAbhp8OiPvCAdFm88vLEXhRhbVNPlB+LmYzz35XkyiNuFQIq+4H5UwCe GUqLpMPrGMzUHB/WZHxzJSCfQpclsWHW1B4Zp53b4pTvbYnz0vV5CnLV3rNB95XC f+x6fdZfsc3ZCUP8fSOoIB5fhbNnuZj5UPRiqVhGzmjztTBFyfqaiAEyqeSe1sv8 b/d/r8nNEpBQcv2ELbxF =Mq7b -----END PGP SIGNATURE----- --ed9KVGgkMQsBIIRWiJKKOe4WPQtRggLgK--