archive mirror
 help / color / mirror / Atom feed
From: Ben Dooks <>
To: Neil Armstrong
Subject: Re: AMLogic RTC series (second round)
Date: Tue, 28 Jun 2016 11:19:47 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <577225A3.9010409-rdvid1DuHRBWk0Htik3J/>

On 28/06/16 08:22, Neil Armstrong wrote:
> On 06/27/2016 06:44 PM, Ben Dooks wrote:
>> Apologies, forgot to put the RTC driver through checkpatch
>> before sending. This gets rid of most of the warnings.
>> _______________________________________________
>> linux-amlogic mailing list
> Hi Ben,
> The patchset looks good but misses some quick introduction on how
> the RTC works, it seems to be connected to an internal serial bus,
> do you have some informations about this ?

I might add a few lines into the rtc-meson.c driver, but that's all
detailed in the datasheet (for once this seems to be documented enough
to be able to function)

> Then, the cover letter of your patchset should contain much more informations
> that "git format-patch --cover-letter" generates.

I may just re-submit once patch to add the RTC and the binding
documentation, and then wait until the reset controller bits have
landed before submitting the

> My personal workflow when I have a set ready is :
> * run checkpatch on C files and check my changes
> # scripts/ -f path/to/my/driver.c
> * I identify the number of patches to include
> * I generate the patches with cover-letter, signoff and eventually subject-prefix, here for 4 commits
> # git format-patch --cover-letter -s -4 --subject-prefix "PATCH v2" -o my_drivers_patches_v2
> * Then I complete the cover letter in my_drivers_patches_v2/0000-cover-letter
> * I also reference a small changelog between patchset version and identify the previous cover letter via it's message id
> Use the service to reference a message-id, i.e this email I answer would be referenced by :

I keep a copy of sent email anyway, so can get the message-ids out of it.

> while looking at the email headers at :
> Message-Id: <>
> * Then I look again all the patches and check all the descriptions
> * I re-run a on all the patches (and ignore errors on the cover letter)
> # scripts/ my_drivers_patches_v2/*
> * I identify all the maintainers and mailing lists
> # scripts/ my_drivers_patches_v2/*
> * Personally, I fill the CC: and To: in the headers of each patches, only adding the devicetree mailing list on DT related patches
> * Then I send them via git send-email
> # git send-email my_drivers_patches_v2/*
> => here you can also select the recipients
> => you can also do a dry run or send yourself the patchset to check before final sending

I got sparse and checkpatch confused, and only did sparse on the series.

Ben Dooks
Senior Engineer				Codethink - Providing Genius

You received this message because you are subscribed to "rtc-linux".
Membership options at .
Please read
before submitting a driver.
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/
For more options, visit

      parent reply	other threads:[~2016-06-28 10:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 16:44 Ben Dooks
     [not found] ` <>
2016-06-27 16:44   ` [PATCH v2 1/4] rtc: support for amlogic meson rtc Ben Dooks
2016-06-27 16:44   ` [PATCH v2 2/4] meson-rtc: add device-tree binding Ben Dooks
     [not found]     ` <>
2016-06-28 20:57       ` Rob Herring
2016-06-27 16:44   ` [PATCH v2 3/4] ARM: dts: amlogic: add rtc node for meson8b Ben Dooks
2016-06-27 16:44   ` [PATCH v2 4/4] ARM: meson: enable RTC for ODroid-C1 Ben Dooks
2016-06-28  7:22   ` AMLogic RTC series (second round) Neil Armstrong
     [not found]     ` <577225A3.9010409-rdvid1DuHRBWk0Htik3J/>
2016-06-28 10:19       ` Ben Dooks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --cc=alexandre.belloni-wi1+55ScJUtKEb57/ \ \ \ \ \
    --cc=narmstrong-rdvid1DuHRBWk0Htik3J/ \ \
    --cc=rtc-linux-/ \
    --subject='Re: AMLogic RTC series (second round)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox