From: John Garry <john.garry@huawei.com>
To: Joe Perches <joe@perches.com>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Mark Rutland <mark.rutland@arm.com>,
Olof Johansson <olof@lixom.net>,
Hanjun Guo <hanjun.guo@linaro.org>,
"dann.frazier@canonical.com" <dann.frazier@canonical.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
Linux PCI <linux-pci@vger.kernel.org>,
Corey Minyard <minyard@acm.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-arch <linux-arch@>
Subject: Re: [PATCH v12 7/9] ACPI: Translate the I/O range of non-MMIO devices before scanning
Date: Mon, 5 Feb 2018 12:17:20 +0000 [thread overview]
Message-ID: <af37de60-a016-f8e3-9e17-d4e7d345f3fb@huawei.com> (raw)
In-Reply-To: <1517832650.7489.256.camel@perches.com>
On 05/02/2018 12:10, Joe Perches wrote:
> On Mon, 2018-02-05 at 11:01 +0000, John Garry wrote:
>> On 04/02/2018 07:45, Rafael J. Wysocki wrote:
>>> + /* translate the I/O resources */
>>>> + for (i = 0; i < count; i++) {
>>>> + if (resources[i].flags & IORESOURCE_IO) {
>>>> + ret = acpi_translate_logicio_res(adev, host,
>>>> + &resources[i]);
>>>
>>> You don't need to break this line as far as I'm concerned.
>>
>> This is just to keep checkpatch happy. I could move the complete
>> function call to a single line. And also shortening some symbols will help.
>
> This could also use continue as well
>
> /* translate the I/O resources */
> for (i = 0; i < count; i++) {
> if (!(resources[i].flags & IORESOURCE_IO))
> continue;
> ret = acpi_translate_logicio_res(adev, host, &resources[i]);
> if (ret) {
> kfree(resources);
> dev_err(child, "Translate I/O range failed (%d)!\n",
> ret);
> return ret;
> }
> }
Sure, that reduces the indentation as well.
cheers
>
>
> .
>
next prev parent reply other threads:[~2018-02-05 12:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 16:36 [PATCH v12 0/9] LPC: legacy ISA I/O support John Garry
2018-01-23 16:36 ` [PATCH v12 1/9] LIB: Introduce a generic PIO mapping method John Garry
2018-01-23 16:36 ` [PATCH v12 2/9] PCI: Remove unused __weak attribute in pci_register_io_range() John Garry
2018-01-23 16:36 ` [PATCH v12 3/9] PCI: Add fwnode handler as input param of pci_register_io_range() John Garry
2018-01-30 15:11 ` Rob Herring
2018-01-23 16:36 ` [PATCH v12 4/9] PCI: Apply the new generic I/O management on PCI IO hosts John Garry
2018-01-23 16:36 ` [PATCH v12 5/9] OF: Add missing I/O range exception for indirect-IO devices John Garry
2018-01-23 16:36 ` [PATCH v12 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings John Garry
2018-02-13 18:41 ` dann frazier
2018-02-14 11:35 ` John Garry
2018-01-23 16:36 ` [PATCH v12 7/9] ACPI: Translate the I/O range of non-MMIO devices before scanning John Garry
2018-02-01 11:32 ` John Garry
[not found] ` <0a30452f-34eb-d0b5-2001-ab6b866c53e2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-02-05 13:16 ` Andy Shevchenko
2018-02-05 14:25 ` John Garry
2018-02-06 19:44 ` Andy Shevchenko
2018-02-04 7:45 ` Rafael J. Wysocki
2018-02-05 11:01 ` John Garry
2018-02-05 12:10 ` Joe Perches
2018-02-05 12:17 ` John Garry [this message]
2018-01-23 16:36 ` [PATCH v12 8/9] LPC, ACPI: Add the HISI LPC ACPI support John Garry
2018-01-23 16:36 ` [PATCH v12 9/9] MAINTAINERS: Add maintainer for HiSilicon LPC driver John Garry
2018-02-08 1:02 ` [PATCH v12 0/9] LPC: legacy ISA I/O support dann frazier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af37de60-a016-f8e3-9e17-d4e7d345f3fb@huawei.com \
--to=john.garry@huawei.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=dann.frazier@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=hanjun.guo@linaro.org \
--cc=joe@perches.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=minyard@acm.org \
--cc=olof@lixom.net \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).