From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5949CC33CAC for ; Thu, 6 Feb 2020 16:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1621220720 for ; Thu, 6 Feb 2020 16:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L5Ofpsxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727703AbgBFQqm (ORCPT ); Thu, 6 Feb 2020 11:46:42 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:38796 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbgBFQqm (ORCPT ); Thu, 6 Feb 2020 11:46:42 -0500 Received: by mail-wm1-f65.google.com with SMTP id a9so806482wmj.3 for ; Thu, 06 Feb 2020 08:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=loAhNVzsToCeFUtt4Vedin+3l88IYbYUEEJOgJLXKKQ=; b=L5OfpsxnjoEDYBIyYUTzAo7zosppZZUJ8kJHjeUACZsXoPWR8SKkQUeq6LppLGKR6M mnSEjWYZqSpbLbRema8M0rmg0kR1aQbjDXHseKLfCZnshvsaN8QB1dSF7FHMLOSfZcE6 DD4UFj4ZFEvYLtpwHzP4HUOy/8NP8bG4K0unxTECGHq3823dWCrH/XB1xhdxXgAAPZVi EQpvoP3K3kAaHMRaYvpz2uYeJbhGd8hSR1XdBajUri03bLMH6F03fHG2J5YHyuRxmAgV 2qTf2k/aMNwTUAorK20DCJ5+X0oj9PyHl2i2l8+wUz/fiJi2r1SGXuEaPuFGqKGCLBV9 1Msg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=loAhNVzsToCeFUtt4Vedin+3l88IYbYUEEJOgJLXKKQ=; b=Xcl5mN3C0p4tKmfnxA0oraA14h2RkK7/ipJUJjfwMYOVIIuynwQ5Giynln6cg161AN /Fh3Q7OkSl5d2LgFjssAa+QEjIUPubmXuu306p+iGNPN+fnUgYs/BVYgwnbaTtiDn1M8 EwObHB+XOxoA1kx0L2ScNVmBU29R+E2YdZZ7A71eHefUynSuTzqp74BywHIkAfVCLVun VfoDkdAISWp7JZzCjtgOiIDJlZbQS/R1cwR+dgAvIXOTjjtpFFH/L30ciYw92wUtl2zB 5Wd6Ff1kGLs+PCqzYwvusJIGnQVtdZE+VQ2qGFKKkc/aQARiXWjh9xNY/3vlRlFtbyNf UHTw== X-Gm-Message-State: APjAAAUHc+7cAmJm8rvK0kpA0F+NYJeYMUkT0MsfPFMjKl222b9z2YfQ dwvqV/zisMmWiDBop2GLQOcWew== X-Google-Smtp-Source: APXvYqxUIGgf+91RMGU87pH6ddlf8OdSzFvpq7OzlYWuVQVnJEXRmpnLXxWRpBO01WNSdSgh4m7AEw== X-Received: by 2002:a1c:4383:: with SMTP id q125mr5516331wma.88.1581007598592; Thu, 06 Feb 2020 08:46:38 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:3889:2de0:ee2:ab1f? ([2a01:e34:ed2f:f020:3889:2de0:ee2:ab1f]) by smtp.googlemail.com with ESMTPSA id f189sm114612wmf.16.2020.02.06.08.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 08:46:38 -0800 (PST) Subject: Re: [PATCH v8 0/7] add thermal sensor driver for A64, A83T, H3, H5, H6, R40 To: Amit Kucheria , Vasily Khoruzhick Cc: Yangtao Li , Zhang Rui , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lakml , =?UTF-8?Q?Ond=c5=99ej_Jirman?= , LKML References: <20191219172823.1652600-1-anarsoul@gmail.com> From: Daniel Lezcano Autocrypt: addr=daniel.lezcano@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFv/yykBEADDdW8RZu7iZILSf3zxq5y8YdaeyZjI/MaqgnvG/c3WjFaunoTMspeusiFE sXvtg3ehTOoyD0oFjKkHaia1Zpa1m/gnNdT/WvTveLfGA1gH+yGes2Sr53Ht8hWYZFYMZc8V 2pbSKh8wepq4g8r5YI1XUy9YbcTdj5mVrTklyGWA49NOeJz2QbfytMT3DJmk40LqwK6CCSU0 9Ed8n0a+vevmQoRZJEd3Y1qXn2XHys0F6OHCC+VLENqNNZXdZE9E+b3FFW0lk49oLTzLRNIq 0wHeR1H54RffhLQAor2+4kSSu8mW5qB0n5Eb/zXJZZ/bRiXmT8kNg85UdYhvf03ZAsp3qxcr xMfMsC7m3+ADOtW90rNNLZnRvjhsYNrGIKH8Ub0UKXFXibHbafSuq7RqyRQzt01Ud8CAtq+w P9EftUysLtovGpLSpGDO5zQ++4ZGVygdYFr318aGDqCljKAKZ9hYgRimPBToDedho1S1uE6F 6YiBFnI3ry9+/KUnEP6L8Sfezwy7fp2JUNkUr41QF76nz43tl7oersrLxHzj2dYfWUAZWXva wW4IKF5sOPFMMgxoOJovSWqwh1b7hqI+nDlD3mmVMd20VyE9W7AgTIsvDxWUnMPvww5iExlY eIC0Wj9K4UqSYBOHcUPrVOKTcsBVPQA6SAMJlt82/v5l4J0pSQARAQABzSpEYW5pZWwgTGV6 Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz7Cwa4EEwEIAEECGwEFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4ACGQEWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXAkeagUJDRnjhwAh CRCP9LjScWdVJxYhBCTWJvJTvp6H5s5b9I/0uNJxZ1Un69gQAJK0ODuKzYl0TvHPU8W7uOeu U7OghN/DTkG6uAkyqW+iIVi320R5QyXN1Tb6vRx6+yZ6mpJRW5S9fO03wcD8Sna9xyZacJfO UTnpfUArs9FF1pB3VIr95WwlVoptBOuKLTCNuzoBTW6jQt0sg0uPDAi2dDzf+21t/UuF7I3z KSeVyHuOfofonYD85FkQJN8lsbh5xWvsASbgD8bmfI87gEbt0wq2ND5yuX+lJK7FX4lMO6gR ZQ75g4KWDprOO/w6ebRxDjrH0lG1qHBiZd0hcPo2wkeYwb1sqZUjQjujlDhcvnZfpDGR4yLz 5WG+pdciQhl6LNl7lctNhS8Uct17HNdfN7QvAumYw5sUuJ+POIlCws/aVbA5+DpmIfzPx5Ak UHxthNIyqZ9O6UHrVg7SaF3rvqrXtjtnu7eZ3cIsfuuHrXBTWDsVwub2nm1ddZZoC530BraS d7Y7eyKs7T4mGwpsi3Pd33Je5aC/rDeF44gXRv3UnKtjq2PPjaG/KPG0fLBGvhx0ARBrZLsd 5CTDjwFA4bo+pD13cVhTfim3dYUnX1UDmqoCISOpzg3S4+QLv1bfbIsZ3KDQQR7y/RSGzcLE z164aDfuSvl+6Myb5qQy1HUQ0hOj5Qh+CzF3CMEPmU1v9Qah1ThC8+KkH/HHjPPulLn7aMaK Z8t6h7uaAYnGzjMEXZLIEhYJKwYBBAHaRw8BAQdAGdRDglTydmxI03SYiVg95SoLOKT5zZW1 7Kpt/5zcvt3CwhsEGAEIACAWIQQk1ibyU76eh+bOW/SP9LjScWdVJwUCXZLIEgIbAgCvCRCP 9LjScWdVJ40gBBkWCAAdFiEEbinX+DPdhovb6oob3uarTi9/eqYFAl2SyBIAIQkQ3uarTi9/ eqYWIQRuKdf4M92Gi9vqihve5qtOL396pnZGAP0c3VRaj3RBEOUGKxHzcu17ZUnIoJLjpHdk NfBnWU9+UgD/bwTxE56Wd8kQZ2e2UTy4BM8907FsJgAQLL4tD2YZggwWIQQk1ibyU76eh+bO W/SP9LjScWdVJ5CaD/0YQyfUzjpR1GnCSkbaLYTEUsyaHuWPI/uSpKTtcbttpYv+QmYsIwD9 8CeH3zwY0Xl/1fE9Hy59z6Vxv9YVapLx0nPDOA1zDVNq2MnutxHb8t+Imjz4ERCxysqtfYrv gao3E/h0c8SEeh+bh5MkjwmU8CwZ3doWyiVdULKESe7/Gs5OuhFzaDVPCpWdsKdCAGyUuP/+ qRWwKGVpWP0Rrt6MTK24Ibeu3xEZO8c3XOEXH5d9nf6YRqBEIizAecoCr00E9c+6BlRS0AqR OQC3/Mm7rWtco3+WOridqVXkko9AcZ8AiM5nu0F8AqYGKg0y7vkL2LOP8us85L0p57MqIR1u gDnITlTY0x4RYRWJ9+k7led5WsnWlyv84KNzbDqQExTm8itzeZYW9RvbTS63r/+FlcTa9Cz1 5fW3Qm0BsyECvpAD3IPLvX9jDIR0IkF/BQI4T98LQAkYX1M/UWkMpMYsL8tLObiNOWUl4ahb PYi5Yd8zVNYuidXHcwPAUXqGt3Cs+FIhihH30/Oe4jL0/2ZoEnWGOexIFVFpue0jdqJNiIvA F5Wpx+UiT5G8CWYYge5DtHI3m5qAP9UgPuck3N8xCihbsXKX4l8bdHfziaJuowief7igeQs/ WyY9FnZb0tl29dSa7PdDKFWu+B+ZnuIzsO5vWMoN6hMThTl1DxS+jc7ATQRb/8z6AQgAvSkg 5w7dVCSbpP6nXc+i8OBz59aq8kuL3YpxT9RXE/y45IFUVuSc2kuUj683rEEgyD7XCf4QKzOw +XgnJcKFQiACpYAowhF/XNkMPQFspPNM1ChnIL5KWJdTp0DhW+WBeCnyCQ2pzeCzQlS/qfs3 dMLzzm9qCDrrDh/aEegMMZFO+reIgPZnInAcbHj3xUhz8p2dkExRMTnLry8XXkiMu9WpchHy XXWYxXbMnHkSRuT00lUfZAkYpMP7La2UudC/Uw9WqGuAQzTqhvE1kSQe0e11Uc+PqceLRHA2 bq/wz0cGriUrcCrnkzRmzYLoGXQHqRuZazMZn2/pSIMZdDxLbwARAQABwsGNBBgBCAAgFiEE JNYm8lO+nofmzlv0j/S40nFnVScFAlv/zPoCGwwAIQkQj/S40nFnVScWIQQk1ibyU76eh+bO W/SP9LjScWdVJ/g6EACFYk+OBS7pV9KZXncBQYjKqk7Kc+9JoygYnOE2wN41QN9Xl0Rk3wri qO7PYJM28YjK3gMT8glu1qy+Ll1bjBYWXzlsXrF4szSqkJpm1cCxTmDOne5Pu6376dM9hb4K l9giUinI4jNUCbDutlt+Cwh3YuPuDXBAKO8YfDX2arzn/CISJlk0d4lDca4Cv+4yiJpEGd/r BVx2lRMUxeWQTz+1gc9ZtbRgpwoXAne4iw3FlR7pyg3NicvR30YrZ+QOiop8psWM2Fb1PKB9 4vZCGT3j2MwZC50VLfOXC833DBVoLSIoL8PfTcOJOcHRYU9PwKW0wBlJtDVYRZ/CrGFjbp2L eT2mP5fcF86YMv0YGWdFNKDCOqOrOkZVmxai65N9d31k8/O9h1QGuVMqCiOTULy/h+FKpv5q t35tlzA2nxPOX8Qj3KDDqVgQBMYJRghZyj5+N6EKAbUVa9Zq8xT6Ms2zz/y7CPW74G1GlYWP i6D9VoMMi6ICko/CXUZ77OgLtMsy3JtzTRbn/wRySOY2AsMgg0Sw6yJ0wfrVk6XAMoLGjaVt X4iPTvwocEhjvrO4eXCicRBocsIB2qZaIj3mlhk2u4AkSpkKm9cN0KWYFUxlENF4/NKWMK+g fGfsCsS3cXXiZpufZFGr+GoHwiELqfLEAQ9AhlrHGCKcgVgTOI6NHg== Message-ID: Date: Thu, 6 Feb 2020 17:46:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Amit, On 06/02/2020 15:13, Amit Kucheria wrote: > Hi Vasily, > > For this entire series, the DTS files don't contain any trip points. > Did I miss some other series? > > At a minimum, you should add some "hot" or "critical" trip points > since then don't require a cooling-map with throttling actions. If you > have "passive" trip points, then you need to provide cooling-maps. Except I'm misunderstanding the bindings, a thermal zone must define these required properties: - polling-delay - polling-delay-passive - thermal-sensors - trips - cooling-maps > Since this series has been merged, could you please follow up with a > fixup series to add the trip points? > > Regards, > Amit > p.s. We should catch all this automatically, I'll send out yaml > bindings for the thermal framework soon that should catch this stuff. +1 There was a small discussion about converting the binding to a schema: https://www.spinics.net/lists/devicetree/msg332424.html > On Thu, Dec 19, 2019 at 10:58 PM Vasily Khoruzhick wrote: >> >> This patchset adds driver for thermal sensor in A64, A83T, H3, H5, >> H6 and R40 SoCs. >> >> v8: >> - [vasily] Address more Maxime's comments for dt-schema >> - [vasily] Add myself to MAINTAINERS for the driver and schema >> - [vasily] Round calibration data size to word boundary for H6 and A64 >> - [vasily] Change offset for A64 since it reports too low temp otherwise. >> Likely conversion formula in user manual is not correct. >> >> v7: >> - [vasily] Address Maxime's comments for dt-schema >> - [vasily] Move common part of H3 and H5 dts into sunxi-h3-h5.dtsi >> - [vasily] Add Maxime's a-b to the driver patch >> >> v6: >> - [ondrej, vasily] Squash all driver related changes into a >> single patch >> - [ondrej] Rename calib -> calibration >> - [ondrej] Fix thermal zone registration check >> - [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor >> - [ondrej] Rework scale/offset values, H6 calibration >> - [ondrej] Explicitly set mod clock to 24 MHz >> - [ondrej] Set undocumented bits in CTRL0 for H6 >> - [ondrej] Add support for A83T >> - [ondrej] Add dts changes for A83T, H3, H5, H6 >> - [vasily] Add dts changes for A64 >> - [vasily] Address Maxime's comments for YAML scheme >> - [vasily] Make .calc_temp callback mandatory >> - [vasily] Set .max_register in regmap config, so regs can be >> inspected using debugfs >> >> Ondrej Jirman (4): >> ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones >> ARM: dts: sun8i-h3: Add thermal sensor and thermal zones >> arm64: dts: allwinner: h5: Add thermal sensor and thermal zones >> arm64: dts: allwinner: h6: Add thermal sensor and thermal zones >> >> Vasily Khoruzhick (1): >> arm64: dts: allwinner: a64: Add thermal sensors and thermal zones >> >> Yangtao Li (2): >> thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 >> dt-bindings: thermal: add YAML schema for sun8i-thermal driver >> bindings >> >> .../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ >> MAINTAINERS | 8 + >> arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + >> arch/arm/boot/dts/sun8i-h3.dtsi | 20 + >> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ >> arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + >> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + >> drivers/thermal/Kconfig | 14 + >> drivers/thermal/Makefile | 1 + >> drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ >> 11 files changed, 985 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml >> create mode 100644 drivers/thermal/sun8i_thermal.c >> >> -- >> 2.24.1 >> -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog