From: Stefano Stabellini <stefano.stabellini@xilinx.com>
To: Ben Levinsky <ben.levinsky@xilinx.com>
Cc: stefanos@xilinx.com, michals@xilinx.com,
devicetree@vger.kernel.org, mathieu.poirier@linaro.org,
ed.mooring@xilinx.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
wendy.liang@xilinx.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/5] firmware: xilinx: Add shutdown/wakeup APIs
Date: Thu, 13 Aug 2020 13:35:31 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2008131103230.15669@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20200811033213.20088-3-ben.levinsky@xilinx.com>
On Mon, 10 Aug 2020, Ben Levinsky wrote:
> Add shutdown/wakeup a resource eemi operations to shutdown
> or bringup a resource.
>
> Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
> ---
> v3:
> - add xilinx-related platform mgmt fn's instead of wrapping around
> function pointer in xilinx eemi ops struct
> - fix formatting
> v4:
> - add default values for enumv3:
> - add xilinx-related platform mgmt fn's instead of wrapping around
> function pointer in xilinx eemi ops struct
> - fix formatting
> v4:
> - add default values for enum
> ---
> drivers/firmware/xilinx/zynqmp.c | 35 ++++++++++++++++++++++++++++
> include/linux/firmware/xlnx-zynqmp.h | 22 +++++++++++++++++
> 2 files changed, 57 insertions(+)
>
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index 8d1ff2454e2e..f1a0bd35deeb 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -846,6 +846,41 @@ int zynqmp_pm_release_node(const u32 node)
> }
> EXPORT_SYMBOL_GPL(zynqmp_pm_release_node);
>
> +/**
> + * zynqmp_pm_force_powerdown - PM call to request for another PU or subsystem to
> + * be powered down forcefully
> + * @target: Node ID of the targeted PU or subsystem
> + * @ack: Flag to specify whether acknowledge is requested
> + *
> + * Return: status, either success or error+reason
> + */
> +int zynqmp_pm_force_powerdown(const u32 target,
If the target is really the node id, why not calling it "node", the same
way as below?
> + const enum zynqmp_pm_request_ack ack)
> +{
> + return zynqmp_pm_invoke_fn(PM_FORCE_POWERDOWN, target, ack, 0, 0, NULL);
> +}
> +EXPORT_SYMBOL_GPL(zynqmp_pm_force_powerdown);
> +
> +/**
> + * zynqmp_pm_request_wakeup - PM call to wake up selected master or subsystem
> + * @node: Node ID of the master or subsystem
> + * @set_addr: Specifies whether the address argument is relevant
> + * @address: Address from which to resume when woken up
> + * @ack: Flag to specify whether acknowledge requested
> + *
> + * Return: status, either success or error+reason
> + */
> +int zynqmp_pm_request_wakeup(const u32 node,
> + const bool set_addr,
> + const u64 address,
> + const enum zynqmp_pm_request_ack ack)
> +{
> + /* set_addr flag is encoded into 1st bit of address */
> + return zynqmp_pm_invoke_fn(PM_REQUEST_WAKEUP, node, address | set_addr,
> + address >> 32, ack, NULL);
> +}
> +EXPORT_SYMBOL_GPL(zynqmp_pm_request_wakeup);
> +
> /**
> * zynqmp_pm_set_requirement() - PM call to set requirement for PM slaves
> * @node: Node ID of the slave
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index bb347dfe4ba4..4d83a7d69c4c 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -64,6 +64,8 @@
>
> enum pm_api_id {
> PM_GET_API_VERSION = 1,
> + PM_FORCE_POWERDOWN = 8,
> + PM_REQUEST_WAKEUP = 10,
> PM_SYSTEM_SHUTDOWN = 12,
> PM_REQUEST_NODE = 13,
> PM_RELEASE_NODE,
> @@ -376,6 +378,12 @@ int zynqmp_pm_write_pggs(u32 index, u32 value);
> int zynqmp_pm_read_pggs(u32 index, u32 *value);
> int zynqmp_pm_system_shutdown(const u32 type, const u32 subtype);
> int zynqmp_pm_set_boot_health_status(u32 value);
> +int zynqmp_pm_force_powerdown(const u32 target,
> + const enum zynqmp_pm_request_ack ack);
> +int zynqmp_pm_request_wakeup(const u32 node,
> + const bool set_addr,
> + const u64 address,
> + const enum zynqmp_pm_request_ack ack);
> #else
> static inline struct zynqmp_eemi_ops *zynqmp_pm_get_eemi_ops(void)
> {
> @@ -526,6 +534,20 @@ static inline int zynqmp_pm_set_boot_health_status(u32 value)
> {
> return -ENODEV;
> }
> +
> +static inline int zynqmp_pm_force_powerdown(const u32 target,
> + const enum zynqmp_pm_request_ack ack)
> +{
> + return -ENODEV;
> +}
> +
> +static inline int zynqmp_pm_request_wakeup(const u32 node,
> + const bool set_addr,
> + const u64 address,
> + const enum zynqmp_pm_request_ack ack)
code style
> +{
> + return -ENODEV;
> +}
> #endif
>
> #endif /* __FIRMWARE_ZYNQMP_H__ */
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2020-08-13 20:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 3:32 [PATCH v8 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP Ben Levinsky
2020-08-11 3:32 ` [PATCH v8 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky
2020-08-11 3:32 ` [PATCH v8 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky
2020-08-13 20:35 ` Stefano Stabellini [this message]
2020-08-18 14:24 ` Ben Levinsky
2020-08-24 23:34 ` Ben Levinsky
2020-08-25 0:30 ` Stefano Stabellini
2020-08-11 3:32 ` [PATCH v8 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky
2020-08-13 20:35 ` Stefano Stabellini
2020-08-18 14:26 ` Ben Levinsky
2020-08-25 20:59 ` Michael Auchter
2020-08-11 3:32 ` [PATCH v8 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky
2020-08-11 3:32 ` [PATCH v8 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky
2020-08-13 20:35 ` Stefano Stabellini
2020-08-18 14:56 ` Ben Levinsky
2020-08-19 21:21 ` Stefano Stabellini
2020-08-20 15:13 ` Ben Levinsky
2020-08-24 21:19 ` Ben Levinsky
2020-08-25 21:09 ` Michael Auchter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2008131103230.15669@sstabellini-ThinkPad-T480s \
--to=stefano.stabellini@xilinx.com \
--cc=ben.levinsky@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=ed.mooring@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michals@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=stefanos@xilinx.com \
--cc=wendy.liang@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).