From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Quentin Perret <qperret@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Amit Kucheria <amitk@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Dietmar Eggemann <Dietmar.Eggemann@arm.com>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
"Nayak, Rajendra" <rnayak@codeaurora.org>
Subject: Re: [PATCH v2 0/3] Clarify abstract scale usage for power values in Energy Model, EAS and IPA
Date: Fri, 16 Oct 2020 14:50:29 +0200 [thread overview]
Message-ID: <b3c6d7a5-0564-6e84-77ff-9afe10d7ee27@linaro.org> (raw)
In-Reply-To: <20201016121844.GA2420691@google.com>
On 16/10/2020 14:18, Quentin Perret wrote:
> On Friday 16 Oct 2020 at 13:48:33 (+0200), Daniel Lezcano wrote:
>> If the SCMI is returning abstract numbers, the thermal IPA governor will
>> use these numbers as a reference to mitigate the temperature at the
>> specified sustainable power which is expressed in mW in the DT. So it
>> does not work and we can not detect such conflict.
>>
>> That is why I'm advocating to keep mW for the energy model and make the
>> SCMI and DT power numbers incompatible.
>
> I think it's fair to say SCMI-provided number should only be compared to
> other SCMI-provided numbers, so +1 on that. But what I don't understand
> is why specifying the EM in mW helps with that?
It is already specified in mW. I'm just saying to not add the
'scale'/'abstract'/'bogoWatt' in the documentation.
> Can we not let the providers specify the unit?
Yes, it is possible but the provider must give the 'unit' and the energy
model must store this information along with the "power" numbers, so we
can compare apple with apple.
Today, the energy model is using the mW unit only and the providers are
not telling the 'unit', so both are missing.
Because both are missing, it does not make sense to talk about
'abstract' values in the energy model documentation until the above is
fixed.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-10-16 12:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 11:44 [PATCH v2 0/3] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Lukasz Luba
2020-10-02 11:44 ` [PATCH v2 1/3] docs: Clarify abstract scale usage for power values in Energy Model Lukasz Luba
2020-10-02 11:44 ` [PATCH v2 2/3] PM / EM: update the comments related to power scale Lukasz Luba
2020-10-02 11:44 ` [PATCH v2 3/3] dt-bindings: thermal: update sustainable-power with abstract scale Lukasz Luba
2020-10-02 14:31 ` Doug Anderson
2020-10-02 15:12 ` Lukasz Luba
2020-10-02 15:47 ` Doug Anderson
2020-10-02 16:40 ` Lukasz Luba
2020-10-02 17:39 ` Doug Anderson
2020-10-06 22:24 ` Rob Herring
2020-10-07 1:17 ` Doug Anderson
2020-10-07 13:26 ` Rob Herring
2020-10-07 21:40 ` Doug Anderson
2020-10-08 14:20 ` Lukasz Luba
2020-10-08 16:41 ` Doug Anderson
2020-10-07 9:03 ` Lukasz Luba
2020-10-05 13:58 ` Rob Herring
2020-10-05 16:14 ` Lukasz Luba
2020-10-09 9:16 ` [PATCH v2 0/3] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Lukasz Luba
2020-10-14 8:22 ` Daniel Lezcano
2020-10-14 9:08 ` Lukasz Luba
2020-10-14 11:23 ` Daniel Lezcano
2020-10-14 15:24 ` Lukasz Luba
2020-10-14 17:10 ` Daniel Lezcano
2020-10-15 9:00 ` Lukasz Luba
2020-10-15 10:21 ` Daniel Lezcano
2020-10-15 13:40 ` Rafael J. Wysocki
2020-10-15 15:04 ` Quentin Perret
2020-10-16 11:48 ` Daniel Lezcano
2020-10-16 12:18 ` Quentin Perret
2020-10-16 12:50 ` Daniel Lezcano [this message]
2020-10-16 13:09 ` Quentin Perret
2020-10-16 14:36 ` Doug Anderson
2020-10-16 15:55 ` Quentin Perret
2020-10-16 14:42 ` Lukasz Luba
2020-10-16 16:02 ` Quentin Perret
2020-10-19 10:35 ` Lukasz Luba
2020-10-15 13:33 ` Rafael J. Wysocki
2020-10-15 13:39 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c6d7a5-0564-6e84-77ff-9afe10d7ee27@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=Dietmar.Eggemann@arm.com \
--cc=amitk@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mka@chromium.org \
--cc=qperret@google.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).