From: sthella@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: nvmem: add binding for QTI SPMI SDAM
Date: Fri, 10 Jan 2020 14:24:57 +0530 [thread overview]
Message-ID: <b4f2fcc0d0a6724d77947f917f114d80@codeaurora.org> (raw)
In-Reply-To: <CAL_JsqL5Gh2A3KfCgRFv+B50Y4PPF1b+qq8vY6yKhbea6KPAkw@mail.gmail.com>
On 2020-01-09 21:01, Rob Herring wrote:
> On Thu, Jan 9, 2020 at 4:57 AM <sthella@codeaurora.org> wrote:
>>
>> On 2020-01-08 22:09, Rob Herring wrote:
>> > On Tue, Dec 24, 2019 at 11:02:12AM +0530, Shyam Kumar Thella wrote:
>> >> QTI SDAM allows PMIC peripherals to access the shared memory that is
>> >> available on QTI PMICs. Add documentation for it.
>> >>
>> >> Signed-off-by: Shyam Kumar Thella <sthella@codeaurora.org>
>> >> ---
>> >> .../devicetree/bindings/nvmem/qcom,spmi-sdam.yaml | 79
>> >> ++++++++++++++++++++++
>> >> 1 file changed, 79 insertions(+)
>> >> create mode 100644
>> >> Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
>> >>
>> >> diff --git
>> >> a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
>> >> b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
>> >> new file mode 100644
>> >> index 0000000..8961a99
>> >> --- /dev/null
>> >> +++ b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
>> >> @@ -0,0 +1,79 @@
>> >> +# SPDX-License-Identifier: GPL-2.0
>> >
>> > Dual license new bindings:
>> >
>> > (GPL-2.0-only OR BSD-2-Clause)
>> >
>> > Please spread the word in QCom.
>> Sure. I will add Dual license in next patchset.
>> >
>> >> +%YAML 1.2
>> >> +---
>> >> +$id: http://devicetree.org/schemas/nvmem/qcom,spmi-sdam.yaml#
>> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> >> +
>> >> +title: Qualcomm Technologies, Inc. SPMI SDAM DT bindings
>> >> +
>> >> +maintainers:
>> >> + - Shyam Kumar Thella <sthella@codeaurora.org>
>> >> +
>> >> +description: |
>> >> + The SDAM provides scratch register space for the PMIC clients. This
>> >> + memory can be used by software to store information or communicate
>> >> + to/from the PBUS.
>> >> +
>> >> +allOf:
>> >> + - $ref: "nvmem.yaml#"
>> >> +
>> >> +properties:
>> >> + compatible:
>> >> + enum:
>> >> + - qcom,spmi-sdam
>> >> +
>> >> + reg:
>> >> + maxItems: 1
>> >> +
>> >> + "#address-cells":
>> >> + const: 1
>> >> +
>> >> + "#size-cells":
>> >> + const: 1
>> >
>> > ranges? The child addresses should be translateable I assume.
>> The addresses are not memory mapped on the CPU's address domain. They
>> are the SPMI addresses which can be accessed over SPMI controller.
>
> Doesn't have to be a CPU address. Are the child offsets within the
> range defined in the parent 'reg'? If so, then it should have
> 'ranges'.
Yes the child offsets fall within parent reg's address space.
I will add ranges in the next patch set.
>
>> >
>> >> +
>> >> +required:
>> >> + - compatible
>> >> + - reg
>> >> +
>> >> +patternProperties:
>> >> + "^.*@[0-9a-f]+$":
>> >> + type: object
>> >> +
>> >> + properties:
>> >> + reg:
>> >> + maxItems: 1
>> >> + description:
>> >> + Offset and size in bytes within the storage device.
>> >> +
>> >> + bits:
>> >
>> > Needs a type reference.
>> Yes. I will add a reference in the next patch set.
>> >
>> >> + maxItems: 1
>> >> + items:
>> >> + items:
>> >> + - minimum: 0
>> >> + maximum: 7
>> >> + description:
>> >> + Offset in bit within the address range specified by
>> >> reg.
>> >> + - minimum: 1
>> >
>> > max is 7?
>> I don't think it is limited to 7 as it is the size within the address
>> range specified by reg. If the address range is more than a byte size
>> can be more.
>
> Then why is the maximum offset 7?
I see. Offset can be more than 7 within the address range specified in
case
of data cells with more than a byte. I will remove maximum in the next
patch set.
>
> Rob
next prev parent reply other threads:[~2020-01-10 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 5:32 [PATCH] dt-bindings: nvmem: add binding for QTI SPMI SDAM Shyam Kumar Thella
2019-12-29 3:01 ` Bjorn Andersson
2019-12-31 6:43 ` sthella
2020-01-08 16:39 ` Rob Herring
2020-01-09 10:57 ` sthella
2020-01-09 15:31 ` Rob Herring
2020-01-10 8:54 ` sthella [this message]
2020-01-13 15:42 ` Rob Herring
2020-01-14 7:07 ` sthella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f2fcc0d0a6724d77947f917f114d80@codeaurora.org \
--to=sthella@codeaurora.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).