From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [BUG] [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver Date: Fri, 23 Aug 2019 17:42:05 +0200 Message-ID: References: <1566531931-9772-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1566531931-9772-3-git-send-email-hsin-hsiung.wang@mediatek.com> <0A87F427-2D81-412A-9549-09A51A021799@public-files.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0A87F427-2D81-412A-9549-09A51A021799@public-files.de> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: frank-w@public-files.de, linux-mediatek@lists.infradead.org, Hsin-Hsiung Wang Cc: Mark Rutland , Alessandro Zummo , Alexandre Belloni , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , Sean Wang , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Richard Fontana , Mark Brown , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Thomas Gleixner , Eddie Huang , Lee Jones , Kate Stewart , linux-rtc@vger.kernel.org List-Id: devicetree@vger.kernel.org On 23/08/2019 17:26, Frank Wunderlich wrote: > > > Am 23. August 2019 16:56:13 MESZ schrieb Matthias Brugger : >> are you sure that you provide the correct chip_id here? I saw 0x2023 >> (if I >> remember correctly), while this switch checks for 0x23, 0x91 and 0x97, >> so I'm >> not sure if the problem really lies here. I didn't dig into the code to >> find out >> how the chip_id is created. > > The chip-id 0x2023 is reported with 5.3-rc5, next-code says 0x0. So i guess the chipid is read out/calculated the wrong way. If calculation is not changed the read is changed compared to 5.3 > I suppose that's because 3/10 has code that should be in 2/10 and for some reason 3/10 was not pushed for linux-next inclusion. Although it has the same Acked-for-mfd-by tag. @Frank, can you test if adding 3/10 to your code base fixes the issue? Regards, Matthias