Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node

From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node
Date: Thu, 17 Nov 2022 15:57:15 +0100	[thread overview]
Message-ID: <b5fcd010-76bf-9ec3-bf52-6ed51c655afa@linaro.org> (raw)
In-Reply-To: <Y1jGjCU47+tOBLus@matsya>


On 26/10/2022 07:33, Vinod Koul wrote:
> On 24-10-22, 21:58, Dmitry Baryshkov wrote:
>> On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 24/10/2022 12:48, Dmitry Baryshkov wrote:
>>>> On 24/10/2022 19:46, Krzysztof Kozlowski wrote:
>>>>> On 24/10/2022 12:45, Dmitry Baryshkov wrote:
>>>>>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote:
>>>>>>> On 09/12/2021 05:35, Vinod Koul wrote:
>>>>>>>> Add the spmi bus as found in the SM8450 SoC
>>>>>>>>
>>>>>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>>>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>>>>>>>> ---
>>>>>>>>     arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++
>>>>>>>>     1 file changed, 18 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>>>>> index f75de777f6ea..b80e34fd3fe1 100644
>>>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 {
>>>>>>>>                            interrupt-controller;
>>>>>>>>                    };
>>>>>>>>
>>>>>>>> +         spmi_bus: spmi@c42d000 {
>>>>>>>> +                 compatible = "qcom,spmi-pmic-arb";
>>>>>>>> +                 reg = <0x0 0x0c400000 0x0 0x00003000>,
>>>>>>>> +                       <0x0 0x0c500000 0x0 0x00400000>,
>>>>>>>> +                       <0x0 0x0c440000 0x0 0x00080000>,
>>>>>>>> +                       <0x0 0x0c4c0000 0x0 0x00010000>,
>>>>>>>> +                       <0x0 0x0c42d000 0x0 0x00010000>;
>>>>>>>
>>>>>>> This is a patch from December 2021. Is there anything blocking it from
>>>>>>> being merged?
>>>>>>>
>>>>>>> The same applies to several other patches here.
>>>>>>
>>>>>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support
>>>>>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT
>>>>>> parts.
>>>>>
>>>>> Why we cannot merge DTS? How is DTS with new nodes depending on any
>>>>> driver changes?
>>>>
>>>> In this particular case, there was an open question, what should be the
>>>> bindings for the PMIC ARB v7.
>>>
>>> Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait
>>> with this one. I just had an impression that it's about driver changes...
>>
>> Yes, it's about binding. Thus we have been waiting for quite some time.
> 
> Yes sadly Steven has stopped responding to emails or IRC.. I am not
> sure whats going on!
> 
> Even the SPMI tree is not being actively maintained with only few
> patches which were picked in last cycle since this year!
It's in -next now and 8450 boots and works fine. If the binding 
situation has been resolved, I say merge this ASAP! :)

Konrad
>