From: Neil Armstrong <narmstrong@baylibre.com>
To: "shunzhou.jiang@amlogic.com" <shunzhou.jiang@amlogic.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
khilman <khilman@baylibre.com>, jbrunet <jbrunet@baylibre.com>
Subject: Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller
Date: Thu, 20 Jan 2022 09:59:03 +0100 [thread overview]
Message-ID: <b846de5f-cf30-c000-ea37-61d79bcd4e7e@baylibre.com> (raw)
In-Reply-To: <2022011810264745683311@amlogic.com>
Hi Shunzhou,
On 18/01/2022 03:26, shunzhou.jiang@amlogic.com wrote:
> Dears Neil & Martin:
> Sorry for my late reply
> S4_VPU_HDMI: for vpu domain, this domain provide power to many moudles(osd, vpp, hdr, dv, di), if close, will cause system crash
> S4_USB_COMB domain: for usb, if not always on, all usb status will clear to 0, that's not right status for usb
> S4_ETH: for ethernet online wakeup, and if power down, status also not right
>>> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON),
>>> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON),
>>> + SEC_PD(S4_GE2D, 0),
>>> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON),
Thanks for clarifications, can you resend the patchset with those infos in comments like it was done for A1 ?
Thanks,
Neil
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Shunzhou Jiang
> SW Department
>
>
> *From:* Neil Armstrong <mailto:narmstrong@baylibre.com>
> *Date:* 2022-01-12 16:36
> *To:* Martin Blumenstingl <mailto:martin.blumenstingl@googlemail.com>; Shunzhou.Jiang <mailto:shunzhou.jiang@amlogic.com>
> *CC:* devicetree <mailto:devicetree@vger.kernel.org>; linux-arm-kernel <mailto:linux-arm-kernel@lists.infradead.org>; linux-amlogic <mailto:linux-amlogic@lists.infradead.org>; linux-kernel <mailto:linux-kernel@vger.kernel.org>; khilman <mailto:khilman@baylibre.com>; jbrunet <mailto:jbrunet@baylibre.com>
> *Subject:* Re: [PATCH V2 2/2] soc: s4: Add support for power domains controller
> [ EXTERNAL EMAIL ]
>
> Hi Shunzhou,
>
> On 30/12/2021 23:15, Martin Blumenstingl wrote:
> > On Thu, Dec 30, 2021 at 10:44 AM Shunzhou.Jiang
> > <shunzhou.jiang@amlogic.com> wrote:
> >>
> >> From: Shunzhou Jiang <shunzhou.jiang@amlogic.com>
> >>
> >> Add support s4 Power controller. In s4, power control
> >> registers are in secure domain, and should be accessed by smc.
> >>
> >> Signed-off-by: Shunzhou Jiang <shunzhou.jiang@amlogic.com>
> > Also here I don't have any datasheet to compare this with, so this gets my:
> > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> >
> > [...]
> >> + SEC_PD(S4_VPU_HDMI, GENPD_FLAG_ALWAYS_ON),
> >> + SEC_PD(S4_USB_COMB, GENPD_FLAG_ALWAYS_ON),
> >> + SEC_PD(S4_GE2D, 0),
> >> + SEC_PD(S4_ETH, GENPD_FLAG_ALWAYS_ON),
> > For the A1 SoC's UART entry we have the following comment which
> > explains why we want to to be "always on":
> > UART should keep working in ATF after suspend and before resume
> >
> > If for some reason you need to re-send this series then it would be
> > great if you could add a comment above each entry with
> > GENPD_FLAG_ALWAYS_ON.
> > It will help others (like me) understand these SoCs better.
>
> Can you resend with those comments added so I can apply the patches ?
>
> Thanks,
> Neil
>
> >
> >
> > Best regards,
> > Martin
> >
>
>
prev parent reply other threads:[~2022-01-20 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211230094434.3053195-1-shunzhou.jiang@amlogic.com>
[not found] ` <20211230094434.3053195-2-shunzhou.jiang@amlogic.com>
2021-12-30 22:11 ` [PATCH V2 1/2] dt-bindings: power: add Amlogic s4 power domains bindings Martin Blumenstingl
[not found] ` <20211230094434.3053195-3-shunzhou.jiang@amlogic.com>
2021-12-30 22:15 ` [PATCH V2 2/2] soc: s4: Add support for power domains controller Martin Blumenstingl
2022-01-12 8:36 ` Neil Armstrong
[not found] ` <2022011810264745683311@amlogic.com>
2022-01-20 8:59 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b846de5f-cf30-c000-ea37-61d79bcd4e7e@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=shunzhou.jiang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).