From: "Alessandrelli, Daniele" <daniele.alessandrelli@intel.com>
To: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Cc: "Khurana, Prabhjot" <prabhjot.khurana@intel.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"ardb@kernel.org" <ardb@kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [RFC PATCH 0/6] Keem Bay OCS ECC crypto driver
Date: Fri, 22 Jan 2021 12:07:27 +0000 [thread overview]
Message-ID: <b8fdb83a067d603d1e5644721be035ebeeac6ea3.camel@intel.com> (raw)
In-Reply-To: <20210121200257.GB27184@gondor.apana.org.au>
On Fri, 2021-01-22 at 07:02 +1100, Herbert Xu wrote:
> On Thu, Jan 21, 2021 at 04:13:51PM +0000, Alessandrelli, Daniele
> wrote:
> > As expected, the second implementation does not pass self-tests and
> > crypto_alloc_kpp() returns -ELIBBAD when trying to allocate it, but
> > I've seen that I can avoid the error (and have it allocated
> > properly)
> > by passing the CRYPTO_ALG_TESTED flag in the 'type' argument, like
> > below:
>
> Did you set your algorithm's name to ecdh? I think Ard was suggesting
> you to not do that. As long as you're not using the same name as a
> recognised algorithm, then you won't need to pass any self-tests at
> all.
>
Oh, looks like I misunderstood Ard suggestion.
I will change the second implementation to use a different algorithm
name (cra_name), something like 'ecdh-keembay-ocs'.
Thanks,
Daniele
prev parent reply other threads:[~2021-01-22 12:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 17:20 [RFC PATCH 0/6] Keem Bay OCS ECC crypto driver Daniele Alessandrelli
2020-12-17 17:20 ` [RFC PATCH 1/6] crypto: engine - Add KPP Support to Crypto Engine Daniele Alessandrelli
2020-12-17 17:20 ` [RFC PATCH 2/6] crypto: ecc - Move ecc.h to include/crypto/internal Daniele Alessandrelli
2020-12-17 17:20 ` [RFC PATCH 3/6] crypto: ecc - Export additional helper functions Daniele Alessandrelli
2020-12-17 17:20 ` [RFC PATCH 4/6] crypto: ecdh - Add Curve ID for NIST P-384 Daniele Alessandrelli
2020-12-17 17:21 ` [RFC PATCH 5/6] dt-bindings: crypto: Add Keem Bay ECC bindings Daniele Alessandrelli
2020-12-21 22:52 ` Rob Herring
2020-12-17 17:21 ` [RFC PATCH 6/6] crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver Daniele Alessandrelli
2021-01-04 8:04 ` [RFC PATCH 0/6] Keem Bay OCS ECC crypto driver Reshetova, Elena
2021-01-04 11:31 ` Herbert Xu
2021-01-04 14:40 ` Reshetova, Elena
2021-01-14 10:25 ` Reshetova, Elena
2021-01-14 18:26 ` Ard Biesheuvel
2021-01-18 11:55 ` Reshetova, Elena
2021-01-18 12:09 ` Ard Biesheuvel
2021-01-19 10:47 ` Reshetova, Elena
2021-01-20 19:00 ` Alessandrelli, Daniele
2021-01-21 9:52 ` Ard Biesheuvel
2021-01-21 16:13 ` Alessandrelli, Daniele
2021-01-21 20:02 ` Herbert Xu
2021-01-22 12:07 ` Alessandrelli, Daniele [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8fdb83a067d603d1e5644721be035ebeeac6ea3.camel@intel.com \
--to=daniele.alessandrelli@intel.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=elena.reshetova@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=prabhjot.khurana@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).